* linux-4.5-rc3/arch/arm/mach-ux500/cpu-db8500.c:89: statement after return ?
@ 2016-02-08 15:50 David Binderman
2016-02-15 22:01 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2016-02-08 15:50 UTC (permalink / raw)
To: linux-arm-kernel
Hello there,
[linux-4.5-rc3/arch/arm/mach-ux500/cpu-db8500.c:89]: (style) Statements following return, break, continue, goto or throw will never be executed.
Source code is
??? return kasprintf(GFP_KERNEL, "%08x%08x%08x%08x%08x",
???????????? readl((u32 *)uid+0),
???????????? readl((u32 *)uid+1), readl((u32 *)uid+2),
???????????? readl((u32 *)uid+3), readl((u32 *)uid+4));
??? iounmap(uid);
}
This looks like a cut-n-paste error to me. Suggest rework.
Regards
David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread
* linux-4.5-rc3/arch/arm/mach-ux500/cpu-db8500.c:89: statement after return ?
2016-02-08 15:50 linux-4.5-rc3/arch/arm/mach-ux500/cpu-db8500.c:89: statement after return ? David Binderman
@ 2016-02-15 22:01 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-02-15 22:01 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 8, 2016 at 4:50 PM, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
> [linux-4.5-rc3/arch/arm/mach-ux500/cpu-db8500.c:89]: (style) Statements following return, break, continue, goto or throw will never be executed.
>
> Source code is
>
> return kasprintf(GFP_KERNEL, "%08x%08x%08x%08x%08x",
> readl((u32 *)uid+0),
> readl((u32 *)uid+1), readl((u32 *)uid+2),
> readl((u32 *)uid+3), readl((u32 *)uid+4));
> iounmap(uid);
> }
>
> This looks like a cut-n-paste error to me. Suggest rework.
I sent a patch for this, nice catch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-15 22:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-08 15:50 linux-4.5-rc3/arch/arm/mach-ux500/cpu-db8500.c:89: statement after return ? David Binderman
2016-02-15 22:01 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.