* [PATCH -next] gpio: pxa: Make two symbols static
@ 2019-04-16 14:56 ` Yue Haibing
0 siblings, 0 replies; 3+ messages in thread
From: Yue Haibing @ 2019-04-16 14:56 UTC (permalink / raw)
To: robert.jarzmik, linus.walleij, bgolaszewski
Cc: linux-kernel, linux-gpio, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warnings:
drivers/gpio/gpio-pxa.c:580:29: warning:
symbol 'pxa_irq_domain_ops' was not declared. Should it be static?
drivers/gpio/gpio-pxa.c:819:20: warning:
symbol 'pxa_gpio_syscore_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpio/gpio-pxa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index dd47960..26f77fd 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -577,7 +577,7 @@ static int pxa_irq_domain_map(struct irq_domain *d, unsigned int irq,
return 0;
}
-const struct irq_domain_ops pxa_irq_domain_ops = {
+static const struct irq_domain_ops pxa_irq_domain_ops = {
.map = pxa_irq_domain_map,
.xlate = irq_domain_xlate_twocell,
};
@@ -812,7 +812,7 @@ static void pxa_gpio_resume(void)
#define pxa_gpio_resume NULL
#endif
-struct syscore_ops pxa_gpio_syscore_ops = {
+static struct syscore_ops pxa_gpio_syscore_ops = {
.suspend = pxa_gpio_suspend,
.resume = pxa_gpio_resume,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next] gpio: pxa: Make two symbols static
@ 2019-04-16 14:56 ` Yue Haibing
0 siblings, 0 replies; 3+ messages in thread
From: Yue Haibing @ 2019-04-16 14:56 UTC (permalink / raw)
To: robert.jarzmik, linus.walleij, bgolaszewski
Cc: linux-kernel, linux-gpio, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warnings:
drivers/gpio/gpio-pxa.c:580:29: warning:
symbol 'pxa_irq_domain_ops' was not declared. Should it be static?
drivers/gpio/gpio-pxa.c:819:20: warning:
symbol 'pxa_gpio_syscore_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpio/gpio-pxa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index dd47960..26f77fd 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -577,7 +577,7 @@ static int pxa_irq_domain_map(struct irq_domain *d, unsigned int irq,
return 0;
}
-const struct irq_domain_ops pxa_irq_domain_ops = {
+static const struct irq_domain_ops pxa_irq_domain_ops = {
.map = pxa_irq_domain_map,
.xlate = irq_domain_xlate_twocell,
};
@@ -812,7 +812,7 @@ static void pxa_gpio_resume(void)
#define pxa_gpio_resume NULL
#endif
-struct syscore_ops pxa_gpio_syscore_ops = {
+static struct syscore_ops pxa_gpio_syscore_ops = {
.suspend = pxa_gpio_suspend,
.resume = pxa_gpio_resume,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] gpio: pxa: Make two symbols static
2019-04-16 14:56 ` Yue Haibing
(?)
@ 2019-04-23 11:02 ` Linus Walleij
-1 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-04-23 11:02 UTC (permalink / raw)
To: Yue Haibing
Cc: Robert Jarzmik, Bartosz Golaszewski, linux-kernel,
open list:GPIO SUBSYSTEM
On Tue, Apr 16, 2019 at 4:56 PM Yue Haibing <yuehaibing@huawei.com> wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/gpio/gpio-pxa.c:580:29: warning:
> symbol 'pxa_irq_domain_ops' was not declared. Should it be static?
> drivers/gpio/gpio-pxa.c:819:20: warning:
> symbol 'pxa_gpio_syscore_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-23 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-16 14:56 [PATCH -next] gpio: pxa: Make two symbols static Yue Haibing
2019-04-16 14:56 ` Yue Haibing
2019-04-23 11:02 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.