[PATCH] remoteproc/ste: remove abandoned include file

[PATCH] remoteproc/ste: remove abandoned include file

[Andrzej Hajda]

STE modem driver has been removed in 2016. This include has no
users since then.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Cc: Jean Delvare <jdelvare@suse.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Suman Anna <s-anna@ti.com>
---
 include/linux/ste_modem_shm.h | 56 -----------------------------------
 1 file changed, 56 deletions(-)
 delete mode 100644 include/linux/ste_modem_shm.h

diff --git a/include/linux/ste_modem_shm.h b/include/linux/ste_modem_shm.h
deleted file mode 100644
index 8444a4eff1bb..000000000000
--- a/include/linux/ste_modem_shm.h
+++ /dev/null
@@ -1,56 +0,0 @@
-/*
- * Copyright (C) ST-Ericsson AB 2012
- * Author: Sjur Brendeland / sjur.brandeland@stericsson.com
- *
- * License terms: GNU General Public License (GPL) version 2
- */
-
-#ifndef __INC_MODEM_DEV_H
-#define __INC_MODEM_DEV_H
-#include <linux/types.h>
-#include <linux/platform_device.h>
-
-struct ste_modem_device;
-
-/**
- * struct ste_modem_dev_cb - Callbacks for modem initiated events.
- * @kick: Called when the modem kicks the host.
- *
- * This structure contains callbacks for actions triggered by the modem.
- */
-struct ste_modem_dev_cb {
-	void (*kick)(struct ste_modem_device *mdev, int notify_id);
-};
-
-/**
- * struct ste_modem_dev_ops - Functions to control modem and modem interface.
- *
- * @power:	Main power switch, used for cold-start or complete power off.
- * @kick:	Kick the modem.
- * @kick_subscribe: Subscribe for notifications from the modem.
- * @setup:	Provide callback functions to modem device.
- *
- * This structure contains functions used by the ste remoteproc driver
- * to manage the modem.
- */
-struct ste_modem_dev_ops {
-	int (*power)(struct ste_modem_device *mdev, bool on);
-	int (*kick)(struct ste_modem_device *mdev, int notify_id);
-	int (*kick_subscribe)(struct ste_modem_device *mdev, int notify_id);
-	int (*setup)(struct ste_modem_device *mdev,
-		     struct ste_modem_dev_cb *cfg);
-};
-
-/**
- * struct ste_modem_device - represent the STE modem device
- * @pdev: Reference to platform device
- * @ops: Operations used to manage the modem.
- * @drv_data: Driver private data.
- */
-struct ste_modem_device {
-	struct platform_device pdev;
-	struct ste_modem_dev_ops ops;
-	void *drv_data;
-};
-
-#endif /*INC_MODEM_DEV_H*/
-- 
2.17.0

Re: [PATCH] remoteproc/ste: remove abandoned include file

[Jean Delvare]

On Fri, 27 Apr 2018 14:16:38 +0200, Andrzej Hajda wrote:
> STE modem driver has been removed in 2016. This include has no
> users since then.
> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Suman Anna <s-anna@ti.com>
> ---
>  include/linux/ste_modem_shm.h | 56 -----------------------------------
>  1 file changed, 56 deletions(-)
>  delete mode 100644 include/linux/ste_modem_shm.h
> (...)

Good catch.

Acked-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] remoteproc/ste: remove abandoned include file

[Linus Walleij]

On Fri, Apr 27, 2018 at 2:16 PM, Andrzej Hajda <a.hajda@samsung.com> wrote:

> STE modem driver has been removed in 2016. This include has no
> users since then.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Suman Anna <s-anna@ti.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij