From: Linus Walleij <linus.walleij@linaro.org>
To: Rohit Vaswani <rvaswani@codeaurora.org>
Cc: David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] drivers: gpio: msm: Fix the error condition for reading ngpio
Date: Wed, 19 Jun 2013 21:45:01 +0200 [thread overview]
Message-ID: <CACRpkdbYimoG1H4U8gKTN=jkX2S6_SK8jtfii2-kKWhQW58drQ@mail.gmail.com> (raw)
In-Reply-To: <1371603747-27436-3-git-send-email-rvaswani@codeaurora.org>
On Wed, Jun 19, 2013 at 3:02 AM, Rohit Vaswani <rvaswani@codeaurora.org> wrote:
> of_property_read_u32 return 0 on success. The check was using a ! to
> return error. Fix the if condition.
>
> Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
I guess this is going through the MSM tree as well?
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-06-19 19:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 1:02 [PATCH 0/4] ARM: MSM: Consolidate GPIOMUX for 7x30 and 8x50 Rohit Vaswani
2013-06-19 1:02 ` [PATCH 1/4] ARM: msm: dts: Fix the gpio register address for msm8960 Rohit Vaswani
2013-06-19 1:02 ` [PATCH 2/4] drivers: gpio: msm: Fix the error condition for reading ngpio Rohit Vaswani
2013-06-19 19:45 ` Linus Walleij [this message]
2013-06-19 19:50 ` Rohit Vaswani
2013-06-19 1:02 ` [PATCH 3/4] ARM: msm: Consolidate gpiomux for older architectures Rohit Vaswani
2013-06-19 1:02 ` [PATCH 4/4] drivers: gpio: msm: Remove __devinit Rohit Vaswani
2013-06-19 8:41 ` Linus Walleij
2013-06-19 1:19 ` [PATCH 0/4] ARM: MSM: Consolidate GPIOMUX for 7x30 and 8x50 Rohit Vaswani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbYimoG1H4U8gKTN=jkX2S6_SK8jtfii2-kKWhQW58drQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=grant.likely@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rvaswani@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.