All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Alexandre TORGUE <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
Cc: Maxime Coquelin
	<mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Daniel Thompson
	<daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Bruno Herrera
	<bruherrera-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v5 6/9] pinctrl: Add IRQ support to STM32 gpios
Date: Tue, 13 Sep 2016 10:14:16 +0200	[thread overview]
Message-ID: <CACRpkdb_uDyDSfv=61+Dwa=HDbDqc9iNKEcOOp36VwGzUPV44Q@mail.gmail.com> (raw)
In-Reply-To: <1473432124-6784-7-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>

On Fri, Sep 9, 2016 at 4:42 PM, Alexandre TORGUE
<alexandre.torgue-qxv4g6HH51o@public.gmane.org> wrote:

> This patch adds IRQ support to STM32 gpios.
>
> The EXTI controller has 16 lines dedicated to GPIOs.
> EXTI line n can be connected to only line n of one of the GPIO ports, for
> example EXTI0 can be connected to either PA0, or PB0, or PC0...
> This port selection is done by specifying the port number into System
> Config registers.
>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue-qxv4g6HH51o@public.gmane.org>

Nicely isolated from the other irq stuff and abstracted.

It's complex but this is as clean as we can make it,
thanks for your efforts.

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Alexandre TORGUE <alexandre.torgue@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Bruno Herrera <bruherrera@gmail.com>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v5 6/9] pinctrl: Add IRQ support to STM32 gpios
Date: Tue, 13 Sep 2016 10:14:16 +0200	[thread overview]
Message-ID: <CACRpkdb_uDyDSfv=61+Dwa=HDbDqc9iNKEcOOp36VwGzUPV44Q@mail.gmail.com> (raw)
In-Reply-To: <1473432124-6784-7-git-send-email-alexandre.torgue@st.com>

On Fri, Sep 9, 2016 at 4:42 PM, Alexandre TORGUE
<alexandre.torgue@st.com> wrote:

> This patch adds IRQ support to STM32 gpios.
>
> The EXTI controller has 16 lines dedicated to GPIOs.
> EXTI line n can be connected to only line n of one of the GPIO ports, for
> example EXTI0 can be connected to either PA0, or PB0, or PC0...
> This port selection is done by specifying the port number into System
> Config registers.
>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

Nicely isolated from the other irq stuff and abstracted.

It's complex but this is as clean as we can make it,
thanks for your efforts.

Patch applied.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 6/9] pinctrl: Add IRQ support to STM32 gpios
Date: Tue, 13 Sep 2016 10:14:16 +0200	[thread overview]
Message-ID: <CACRpkdb_uDyDSfv=61+Dwa=HDbDqc9iNKEcOOp36VwGzUPV44Q@mail.gmail.com> (raw)
In-Reply-To: <1473432124-6784-7-git-send-email-alexandre.torgue@st.com>

On Fri, Sep 9, 2016 at 4:42 PM, Alexandre TORGUE
<alexandre.torgue@st.com> wrote:

> This patch adds IRQ support to STM32 gpios.
>
> The EXTI controller has 16 lines dedicated to GPIOs.
> EXTI line n can be connected to only line n of one of the GPIO ports, for
> example EXTI0 can be connected to either PA0, or PB0, or PC0...
> This port selection is done by specifying the port number into System
> Config registers.
>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

Nicely isolated from the other irq stuff and abstracted.

It's complex but this is as clean as we can make it,
thanks for your efforts.

Patch applied.

Yours,
Linus Walleij

  parent reply	other threads:[~2016-09-13  8:14 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 14:41 [PATCH v5 0/9] Add STM32 EXTI interrupt controller support Alexandre TORGUE
2016-09-09 14:41 ` Alexandre TORGUE
2016-09-09 14:41 ` Alexandre TORGUE
2016-09-09 14:41 ` [PATCH v5 1/9] Documentation: dt-bindings: Document STM32 EXTI controller bindings Alexandre TORGUE
2016-09-09 14:41   ` Alexandre TORGUE
2016-09-09 14:41   ` Alexandre TORGUE
2016-09-19 21:24   ` Rob Herring
2016-09-19 21:24     ` Rob Herring
2016-09-19 21:24     ` Rob Herring
2016-09-09 14:41 ` [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre TORGUE
2016-09-09 14:41   ` Alexandre TORGUE
2016-09-09 14:41   ` Alexandre TORGUE
     [not found]   ` <1473432124-6784-3-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2016-09-13  8:19     ` Marc Zyngier
2016-09-13  8:19       ` Marc Zyngier
2016-09-13  8:19       ` Marc Zyngier
2016-09-13 15:21   ` Thomas Gleixner
2016-09-13 15:21     ` Thomas Gleixner
2016-09-13 16:29     ` Alexandre Torgue
2016-09-13 16:29       ` Alexandre Torgue
2016-09-13 16:29       ` Alexandre Torgue
2016-09-14  9:19       ` Thomas Gleixner
2016-09-14  9:19         ` Thomas Gleixner
2016-09-14 13:05         ` Alexandre Torgue
2016-09-14 13:05           ` Alexandre Torgue
2016-09-14 13:05           ` Alexandre Torgue
2016-09-14 13:34           ` Thomas Gleixner
2016-09-14 13:34             ` Thomas Gleixner
2016-09-14 13:44             ` Alexandre Torgue
2016-09-14 13:44               ` Alexandre Torgue
2016-09-14 13:44               ` Alexandre Torgue
2016-09-20  9:48               ` Alexandre Torgue
2016-09-20  9:48                 ` Alexandre Torgue
2016-09-20  9:48                 ` Alexandre Torgue
2016-09-20  9:51                 ` Thomas Gleixner
2016-09-20  9:51                   ` Thomas Gleixner
2016-09-20 12:40                   ` Alexandre Torgue
2016-09-20 12:40                     ` Alexandre Torgue
2016-09-20 12:40                     ` Alexandre Torgue
2016-09-20 12:44                     ` Thomas Gleixner
2016-09-20 12:44                       ` Thomas Gleixner
2016-09-20 13:33                       ` Alexandre Torgue
2016-09-20 13:33                         ` Alexandre Torgue
2016-09-20 13:33                         ` Alexandre Torgue
2016-09-20 14:02                         ` Thomas Gleixner
2016-09-20 14:02                           ` Thomas Gleixner
2016-09-20 15:28                           ` Alexandre Torgue
2016-09-20 15:28                             ` Alexandre Torgue
2016-09-20 15:28                             ` Alexandre Torgue
2016-09-20 15:36                             ` Thomas Gleixner
2016-09-20 15:36                               ` Thomas Gleixner
2016-09-09 14:41 ` [PATCH v5 3/9] ARM: STM32: Select external interrupts controller Alexandre TORGUE
2016-09-09 14:41   ` Alexandre TORGUE
2016-09-09 14:41   ` Alexandre TORGUE
2016-09-09 14:41 ` [PATCH v5 4/9] ARM: dts: Add EXTI controller node to stm32f429 Alexandre TORGUE
2016-09-09 14:41   ` Alexandre TORGUE
2016-09-09 14:41   ` Alexandre TORGUE
2016-09-09 14:42 ` [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related properties of STM32 pinctrl Alexandre TORGUE
2016-09-09 14:42   ` Alexandre TORGUE
2016-09-09 14:42   ` Alexandre TORGUE
     [not found]   ` <1473432124-6784-6-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2016-09-13  8:12     ` Linus Walleij
2016-09-13  8:12       ` Linus Walleij
2016-09-13  8:12       ` Linus Walleij
2016-09-13  8:18   ` Linus Walleij
2016-09-13  8:18     ` Linus Walleij
2016-09-13  8:18     ` Linus Walleij
2016-09-13 12:34     ` Alexandre Torgue
2016-09-13 12:34       ` Alexandre Torgue
2016-09-13 12:34       ` Alexandre Torgue
2016-09-13 12:47       ` Linus Walleij
2016-09-13 12:47         ` Linus Walleij
2016-09-13 12:47         ` Linus Walleij
2016-09-09 14:42 ` [PATCH v5 6/9] pinctrl: Add IRQ support to STM32 gpios Alexandre TORGUE
2016-09-09 14:42   ` Alexandre TORGUE
2016-09-09 14:42   ` Alexandre TORGUE
     [not found]   ` <1473432124-6784-7-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2016-09-13  8:14     ` Linus Walleij [this message]
2016-09-13  8:14       ` Linus Walleij
2016-09-13  8:14       ` Linus Walleij
2016-09-09 14:42 ` [PATCH v5 7/9] ARM: dts: Add GPIO irq support to STM2F429 Alexandre TORGUE
2016-09-09 14:42   ` Alexandre TORGUE
2016-09-09 14:42   ` Alexandre TORGUE
     [not found] ` <1473432124-6784-1-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2016-09-09 14:42   ` [PATCH v5 8/9] ARM: dts: Declare push button as GPIO key on stm32f429 boards Alexandre TORGUE
2016-09-09 14:42     ` Alexandre TORGUE
2016-09-09 14:42     ` Alexandre TORGUE
2016-09-09 14:42 ` [PATCH v5 9/9] ARM: config: Enable GPIO Key driver in stm32_defconfig Alexandre TORGUE
2016-09-09 14:42   ` Alexandre TORGUE
2016-09-09 14:42   ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdb_uDyDSfv=61+Dwa=HDbDqc9iNKEcOOp36VwGzUPV44Q@mail.gmail.com' \
    --to=linus.walleij-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=alexandre.torgue-qxv4g6HH51o@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=bruherrera-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.