All of lore.kernel.org
 help / color / mirror / Atom feed
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/pl111: Fix regression from fbdev CMA helper
Date: Mon, 12 Feb 2018 16:53:18 +0100	[thread overview]
Message-ID: <CACRpkdbaCuhzuzkRgUpfwGmwJrJ61E0cK76WLAr=6f=pkX8TuQ@mail.gmail.com> (raw)
In-Reply-To: <139b8daa-26c9-1aff-60f0-26c8749eede6@tronnes.org>

On Mon, Feb 12, 2018 at 3:01 PM, Noralf Tr?nnes <noralf@tronnes.org> wrote:
> Den 12.02.2018 14.42, skrev Noralf Tr?nnes:
>> Den 12.02.2018 13.40, skrev Linus Walleij:

>>>         drm_mode_config_reset(dev);
>>>   -    drm_fb_cma_fbdev_init(dev, 32, 0);
>>> +    drm_fb_cma_fbdev_init(dev, 32, 1);
>>>         drm_kms_helper_poll_init(dev);

(...)

> I forgot to look at the change, and I don't understand how this broke
> anything,

My wrong.

I had some old codepaths in my out-of-tree stuff (sorry
the only thing that makes the hardware work...).

I was using the old drm_fbdev_cma_init() which isn't
as helpful as the new drm_fb_cma_fbdev_init() but
as the old function is still there it all just "worked"
except for this...

Theres is some confusion with these similarly named
functions :D

Sorry for the fuzz, I fixed my patch set to use the new
function now.

Let's just drop this patch.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm/pl111: Fix regression from fbdev CMA helper
Date: Mon, 12 Feb 2018 16:53:18 +0100	[thread overview]
Message-ID: <CACRpkdbaCuhzuzkRgUpfwGmwJrJ61E0cK76WLAr=6f=pkX8TuQ@mail.gmail.com> (raw)
In-Reply-To: <139b8daa-26c9-1aff-60f0-26c8749eede6@tronnes.org>

On Mon, Feb 12, 2018 at 3:01 PM, Noralf Trønnes <noralf@tronnes.org> wrote:
> Den 12.02.2018 14.42, skrev Noralf Trønnes:
>> Den 12.02.2018 13.40, skrev Linus Walleij:

>>>         drm_mode_config_reset(dev);
>>>   -    drm_fb_cma_fbdev_init(dev, 32, 0);
>>> +    drm_fb_cma_fbdev_init(dev, 32, 1);
>>>         drm_kms_helper_poll_init(dev);

(...)

> I forgot to look at the change, and I don't understand how this broke
> anything,

My wrong.

I had some old codepaths in my out-of-tree stuff (sorry
the only thing that makes the hardware work...).

I was using the old drm_fbdev_cma_init() which isn't
as helpful as the new drm_fb_cma_fbdev_init() but
as the old function is still there it all just "worked"
except for this...

Theres is some confusion with these similarly named
functions :D

Sorry for the fuzz, I fixed my patch set to use the new
function now.

Let's just drop this patch.

Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-02-12 15:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 12:40 [PATCH] drm/pl111: Fix regression from fbdev CMA helper Linus Walleij
2018-02-12 12:40 ` Linus Walleij
2018-02-12 13:42 ` Noralf Trønnes
2018-02-12 13:42   ` Noralf Trønnes
2018-02-12 14:01   ` Noralf Trønnes
2018-02-12 14:01     ` Noralf Trønnes
2018-02-12 15:53     ` Linus Walleij [this message]
2018-02-12 15:53       ` Linus Walleij
2018-02-12 16:02       ` Noralf Trønnes
2018-02-12 16:02         ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdbaCuhzuzkRgUpfwGmwJrJ61E0cK76WLAr=6f=pkX8TuQ@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.