All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Jianqun Xu <jay.xu@rock-chips.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] gpio/rockchip: fix get_direction value handling
Date: Sat, 18 Sep 2021 01:30:21 +0200	[thread overview]
Message-ID: <CACRpkdbcHi0+pe3jC6AkdBfZZv=EhA1prV1XAXfQKfi4fMtg+A@mail.gmail.com> (raw)
In-Reply-To: <20210913224926.1260726-3-heiko@sntech.de>

On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner <heiko@sntech.de> wrote:

> The function uses the newly introduced rockchip_gpio_readl_bit()
> which directly returns the actual value of the requeste bit.
> So using the existing bit-wise check for the bit inside the value
> will always return 0.
>
> Fix this by dropping the bit manipulation on the result.
>
> Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID
From: Linus Walleij <linus.walleij@linaro.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Jianqun Xu <jay.xu@rock-chips.com>,
	 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] gpio/rockchip: fix get_direction value handling
Date: Sat, 18 Sep 2021 01:30:21 +0200	[thread overview]
Message-ID: <CACRpkdbcHi0+pe3jC6AkdBfZZv=EhA1prV1XAXfQKfi4fMtg+A@mail.gmail.com> (raw)
In-Reply-To: <20210913224926.1260726-3-heiko@sntech.de>

On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner <heiko@sntech.de> wrote:

> The function uses the newly introduced rockchip_gpio_readl_bit()
> which directly returns the actual value of the requeste bit.
> So using the existing bit-wise check for the bit inside the value
> will always return 0.
>
> Fix this by dropping the bit manipulation on the result.
>
> Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID
From: Linus Walleij <linus.walleij@linaro.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Jianqun Xu <jay.xu@rock-chips.com>,
	 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] gpio/rockchip: fix get_direction value handling
Date: Sat, 18 Sep 2021 01:30:21 +0200	[thread overview]
Message-ID: <CACRpkdbcHi0+pe3jC6AkdBfZZv=EhA1prV1XAXfQKfi4fMtg+A@mail.gmail.com> (raw)
In-Reply-To: <20210913224926.1260726-3-heiko@sntech.de>

On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner <heiko@sntech.de> wrote:

> The function uses the newly introduced rockchip_gpio_readl_bit()
> which directly returns the actual value of the requeste bit.
> So using the existing bit-wise check for the bit inside the value
> will always return 0.
>
> Fix this by dropping the bit manipulation on the result.
>
> Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-17 23:30 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 22:49 [PATCH 0/4] gpio/pinctrl-rockchip: Fixes for the recently separated gpio/pinctrl driver Heiko Stuebner
2021-09-13 22:49 ` Heiko Stuebner
2021-09-13 22:49 ` Heiko Stuebner
2021-09-13 22:49 ` [PATCH 1/4] gpio/rockchip: extended debounce support is only available on v2 Heiko Stuebner
2021-09-13 22:49   ` Heiko Stuebner
2021-09-13 22:49   ` Heiko Stuebner
2021-09-17 22:34   ` Linus Walleij
2021-09-17 22:34     ` Linus Walleij
2021-09-17 22:34     ` Linus Walleij
2021-09-22  9:45   ` Bartosz Golaszewski
2021-09-22  9:45     ` Bartosz Golaszewski
2021-09-22  9:45     ` Bartosz Golaszewski
2021-09-13 22:49 ` [PATCH 2/4] gpio/rockchip: fix get_direction value handling Heiko Stuebner
2021-09-13 22:49   ` Heiko Stuebner
2021-09-13 22:49   ` Heiko Stuebner
2021-09-17 23:30   ` Linus Walleij [this message]
2021-09-17 23:30     ` Linus Walleij
2021-09-17 23:30     ` Linus Walleij
2021-09-22  9:46   ` Bartosz Golaszewski
2021-09-22  9:46     ` Bartosz Golaszewski
2021-09-22  9:46     ` Bartosz Golaszewski
2021-09-13 22:49 ` [PATCH 3/4] pinctrl/rockchip: add a queue for deferred pin output settings on probe Heiko Stuebner
2021-09-13 22:49   ` Heiko Stuebner
2021-09-13 22:49   ` Heiko Stuebner
2021-09-17 23:35   ` Linus Walleij
2021-09-17 23:35     ` Linus Walleij
2021-09-17 23:35     ` Linus Walleij
2021-09-13 22:49 ` [PATCH 4/4] gpio/rockchip: fetch deferred " Heiko Stuebner
2021-09-13 22:49   ` Heiko Stuebner
2021-09-13 22:49   ` Heiko Stuebner
2021-09-17 23:38   ` Linus Walleij
2021-09-17 23:38     ` Linus Walleij
2021-09-17 23:38     ` Linus Walleij
2021-09-18  0:00     ` Heiko Stübner
2021-09-18  0:00       ` Heiko Stübner
2021-09-18  0:00       ` Heiko Stübner
2021-09-19 14:47       ` Linus Walleij
2021-09-19 14:47         ` Linus Walleij
2021-09-19 14:47         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdbcHi0+pe3jC6AkdBfZZv=EhA1prV1XAXfQKfi4fMtg+A@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=heiko@sntech.de \
    --cc=jay.xu@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.