From: Linus Walleij <linus.walleij@linaro.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: at91: Constify struct at91_pinctrl_mux_ops
Date: Tue, 25 May 2021 02:09:59 +0200 [thread overview]
Message-ID: <CACRpkdbciLfw2dOqaRwBAWQz3PF2cCzz=Kxkqf02G_G6qafRZQ@mail.gmail.com> (raw)
In-Reply-To: <20210512180140.33293-1-rikard.falkeborn@gmail.com>
On Wed, May 12, 2021 at 8:01 PM Rikard Falkeborn
<rikard.falkeborn@gmail.com> wrote:
> The at91_pinctrl_mux_ops struct is never modified by the driver. Make it
> const wherever it is possible to allow the compiler to put the static
> variables in read-only memory. Note that sam9x60_ops was already const,
> but the const was cast away when the return value of of_match_device() was
> cast to a pointer to a non-const struct at91_pinctrl_mux_ops.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Patch applied.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: at91: Constify struct at91_pinctrl_mux_ops
Date: Tue, 25 May 2021 02:09:59 +0200 [thread overview]
Message-ID: <CACRpkdbciLfw2dOqaRwBAWQz3PF2cCzz=Kxkqf02G_G6qafRZQ@mail.gmail.com> (raw)
In-Reply-To: <20210512180140.33293-1-rikard.falkeborn@gmail.com>
On Wed, May 12, 2021 at 8:01 PM Rikard Falkeborn
<rikard.falkeborn@gmail.com> wrote:
> The at91_pinctrl_mux_ops struct is never modified by the driver. Make it
> const wherever it is possible to allow the compiler to put the static
> variables in read-only memory. Note that sam9x60_ops was already const,
> but the const was cast away when the return value of of_match_device() was
> cast to a pointer to a non-const struct at91_pinctrl_mux_ops.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-25 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 18:01 [PATCH] pinctrl: at91: Constify struct at91_pinctrl_mux_ops Rikard Falkeborn
2021-05-12 18:01 ` Rikard Falkeborn
2021-05-25 0:09 ` Linus Walleij [this message]
2021-05-25 0:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbciLfw2dOqaRwBAWQz3PF2cCzz=Kxkqf02G_G6qafRZQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.