From: Linus Walleij <linus.walleij@linaro.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
john@phrozen.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v5 12/13] gpio: Add support for Airoha EN7523 GPIO controller
Date: Sun, 5 Dec 2021 00:57:24 +0100 [thread overview]
Message-ID: <CACRpkdbekZsKvoMmCtDV2Ui=ZyZA3ymZJL459Y0WgD=-mNyd=w@mail.gmail.com> (raw)
In-Reply-To: <c42f4ea0-2879-01cf-1db8-ed39844959fc@nbd.name>
On Thu, Dec 2, 2021 at 6:59 PM Felix Fietkau <nbd@nbd.name> wrote:
> I just looked at the datasheet and the driver code again, and I think
> EN7523 is too strange for proper generic GPIO support.
Yup I see that John explained it to me in the past, no problem.
Let's do it like this then, but just drop select GPIO_GENERIC
from KConfig since it's not used.
With that oneliner change:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
john@phrozen.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v5 12/13] gpio: Add support for Airoha EN7523 GPIO controller
Date: Sun, 5 Dec 2021 00:57:24 +0100 [thread overview]
Message-ID: <CACRpkdbekZsKvoMmCtDV2Ui=ZyZA3ymZJL459Y0WgD=-mNyd=w@mail.gmail.com> (raw)
In-Reply-To: <c42f4ea0-2879-01cf-1db8-ed39844959fc@nbd.name>
On Thu, Dec 2, 2021 at 6:59 PM Felix Fietkau <nbd@nbd.name> wrote:
> I just looked at the datasheet and the driver code again, and I think
> EN7523 is too strange for proper generic GPIO support.
Yup I see that John explained it to me in the past, no problem.
Let's do it like this then, but just drop select GPIO_GENERIC
from KConfig since it's not used.
With that oneliner change:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-12-04 23:58 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 15:33 [PATCH v5 00/13] Add support for Airoha EN7523 SoC Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 01/13] dt-bindings: Add vendor prefix for Airoha Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 02/13] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 03/13] ARM: dts: Add basic support for Airoha EN7523 Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 04/13] ARM: Add basic support for Airoha EN7523 SoC Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 05/13] ARM: multi_v7_defconfig: Add " Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 06/13] dt-bindings: Add en7523-scu device tree binding documentation Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 07/13] clk: en7523: Add clock driver for Airoha EN7523 SoC Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-12-02 17:34 ` kernel test robot
2021-12-02 17:34 ` kernel test robot
2021-12-02 17:34 ` kernel test robot
2021-12-03 8:03 ` Stephen Boyd
2021-12-03 8:03 ` Stephen Boyd
2021-11-29 15:33 ` [PATCH v5 08/13] dt-bindings: PCI: Add support for Airoha EN7532 Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 09/13] PCI: mediatek: allow selecting controller driver for airoha arch Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 23:55 ` Bjorn Helgaas
2021-11-29 23:55 ` Bjorn Helgaas
2021-11-29 23:55 ` Bjorn Helgaas
2021-12-06 20:06 ` Bjorn Helgaas
2021-12-06 20:06 ` Bjorn Helgaas
2021-12-06 20:06 ` Bjorn Helgaas
2021-11-29 15:33 ` [PATCH v5 10/13] ARM: dts: Add PCIe support for Airoha EN7523 Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 11/13] dt-bindings: arm: airoha: Add binding for Airoha GPIO controller Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-11-29 15:33 ` [PATCH v5 12/13] gpio: Add support for Airoha EN7523 " Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
2021-12-02 1:47 ` Linus Walleij
2021-12-02 1:47 ` Linus Walleij
2021-12-02 17:59 ` Felix Fietkau
2021-12-02 17:59 ` Felix Fietkau
2021-12-02 19:02 ` John Crispin
2021-12-02 19:02 ` John Crispin
2021-12-04 23:55 ` Linus Walleij
2021-12-04 23:55 ` Linus Walleij
2021-12-04 23:57 ` Linus Walleij [this message]
2021-12-04 23:57 ` Linus Walleij
2021-12-12 6:59 ` Felix Fietkau
2021-12-12 6:59 ` Felix Fietkau
2021-12-12 19:16 ` Andy Shevchenko
2021-12-12 19:16 ` Andy Shevchenko
2021-11-29 15:33 ` [PATCH v5 13/13] ARM: dts: add GPIO support for Airoha EN7523 Felix Fietkau
2021-11-29 15:33 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbekZsKvoMmCtDV2Ui=ZyZA3ymZJL459Y0WgD=-mNyd=w@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=brgl@bgdev.pl \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.