All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: pinctrl: mt8195: Fix name for mediatek,rsel-resistance-in-si-unit
@ 2022-06-30 12:23 ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-06-30 12:23 UTC (permalink / raw)
  To: linus.walleij
  Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sean.wang,
	linux-gpio, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel, nfraprado, AngeloGioacchino Del Regno

When this property was introduced, it contained underscores, but
the actual code wants dashes.

Change it from mediatek,rsel_resistance_in_si_unit to
mediatek,rsel-resistance-in-si-unit.

Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---

Note: No devicetree uses this property as of now.
      Even if any DT did, it wouldn't work, as the pinctrl code checks
      for 'mediatek,rsel-resistance-in-si-unit'.

 .../devicetree/bindings/pinctrl/pinctrl-mt8195.yaml    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
index 15989743afd2..b0fea44403e7 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
@@ -51,7 +51,7 @@ properties:
     description: The interrupt outputs to sysirq.
     maxItems: 1
 
-  mediatek,rsel_resistance_in_si_unit:
+  mediatek,rsel-resistance-in-si-unit:
     type: boolean
     description: |
       Identifying i2c pins pull up/down type which is RSEL. It can support
@@ -144,7 +144,7 @@ patternProperties:
               "MTK_PUPD_SET_R1R0_11" define in mt8195.
               For pull down type is RSEL, it can add RSEL define & resistance
               value(ohm) to set different resistance by identifying property
-              "mediatek,rsel_resistance_in_si_unit".
+              "mediatek,rsel-resistance-in-si-unit".
               It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
               & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011"
               & "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101"
@@ -163,7 +163,7 @@ patternProperties:
               };
               An example of using si unit resistance value(ohm):
               &pio {
-                mediatek,rsel_resistance_in_si_unit;
+                mediatek,rsel-resistance-in-si-unit;
               }
               pincontroller {
                 i2c0_pin {
@@ -192,7 +192,7 @@ patternProperties:
               "MTK_PUPD_SET_R1R0_11" define in mt8195.
               For pull up type is RSEL, it can add RSEL define & resistance
               value(ohm) to set different resistance by identifying property
-              "mediatek,rsel_resistance_in_si_unit".
+              "mediatek,rsel-resistance-in-si-unit".
               It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
               & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011"
               & "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101"
@@ -211,7 +211,7 @@ patternProperties:
               };
               An example of using si unit resistance value(ohm):
               &pio {
-                mediatek,rsel_resistance_in_si_unit;
+                mediatek,rsel-resistance-in-si-unit;
               }
               pincontroller {
                 i2c0-pins {
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] dt-bindings: pinctrl: mt8195: Fix name for mediatek,rsel-resistance-in-si-unit
@ 2022-06-30 12:23 ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-06-30 12:23 UTC (permalink / raw)
  To: linus.walleij
  Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sean.wang,
	linux-gpio, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel, nfraprado, AngeloGioacchino Del Regno

When this property was introduced, it contained underscores, but
the actual code wants dashes.

Change it from mediatek,rsel_resistance_in_si_unit to
mediatek,rsel-resistance-in-si-unit.

Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---

Note: No devicetree uses this property as of now.
      Even if any DT did, it wouldn't work, as the pinctrl code checks
      for 'mediatek,rsel-resistance-in-si-unit'.

 .../devicetree/bindings/pinctrl/pinctrl-mt8195.yaml    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
index 15989743afd2..b0fea44403e7 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
@@ -51,7 +51,7 @@ properties:
     description: The interrupt outputs to sysirq.
     maxItems: 1
 
-  mediatek,rsel_resistance_in_si_unit:
+  mediatek,rsel-resistance-in-si-unit:
     type: boolean
     description: |
       Identifying i2c pins pull up/down type which is RSEL. It can support
@@ -144,7 +144,7 @@ patternProperties:
               "MTK_PUPD_SET_R1R0_11" define in mt8195.
               For pull down type is RSEL, it can add RSEL define & resistance
               value(ohm) to set different resistance by identifying property
-              "mediatek,rsel_resistance_in_si_unit".
+              "mediatek,rsel-resistance-in-si-unit".
               It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
               & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011"
               & "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101"
@@ -163,7 +163,7 @@ patternProperties:
               };
               An example of using si unit resistance value(ohm):
               &pio {
-                mediatek,rsel_resistance_in_si_unit;
+                mediatek,rsel-resistance-in-si-unit;
               }
               pincontroller {
                 i2c0_pin {
@@ -192,7 +192,7 @@ patternProperties:
               "MTK_PUPD_SET_R1R0_11" define in mt8195.
               For pull up type is RSEL, it can add RSEL define & resistance
               value(ohm) to set different resistance by identifying property
-              "mediatek,rsel_resistance_in_si_unit".
+              "mediatek,rsel-resistance-in-si-unit".
               It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
               & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011"
               & "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101"
@@ -211,7 +211,7 @@ patternProperties:
               };
               An example of using si unit resistance value(ohm):
               &pio {
-                mediatek,rsel_resistance_in_si_unit;
+                mediatek,rsel-resistance-in-si-unit;
               }
               pincontroller {
                 i2c0-pins {
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: mt8195: Fix name for mediatek,rsel-resistance-in-si-unit
  2022-06-30 12:23 ` AngeloGioacchino Del Regno
@ 2022-07-01 20:11   ` Rob Herring
  -1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-07-01 20:11 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: nfraprado, devicetree, matthias.bgg, robh+dt, linux-mediatek,
	krzysztof.kozlowski+dt, linus.walleij, linux-kernel, sean.wang,
	linux-gpio, linux-arm-kernel

On Thu, 30 Jun 2022 14:23:34 +0200, AngeloGioacchino Del Regno wrote:
> When this property was introduced, it contained underscores, but
> the actual code wants dashes.
> 
> Change it from mediatek,rsel_resistance_in_si_unit to
> mediatek,rsel-resistance-in-si-unit.
> 
> Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> 
> Note: No devicetree uses this property as of now.
>       Even if any DT did, it wouldn't work, as the pinctrl code checks
>       for 'mediatek,rsel-resistance-in-si-unit'.
> 
>  .../devicetree/bindings/pinctrl/pinctrl-mt8195.yaml    | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: mt8195: Fix name for mediatek,rsel-resistance-in-si-unit
@ 2022-07-01 20:11   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-07-01 20:11 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: nfraprado, devicetree, matthias.bgg, robh+dt, linux-mediatek,
	krzysztof.kozlowski+dt, linus.walleij, linux-kernel, sean.wang,
	linux-gpio, linux-arm-kernel

On Thu, 30 Jun 2022 14:23:34 +0200, AngeloGioacchino Del Regno wrote:
> When this property was introduced, it contained underscores, but
> the actual code wants dashes.
> 
> Change it from mediatek,rsel_resistance_in_si_unit to
> mediatek,rsel-resistance-in-si-unit.
> 
> Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> 
> Note: No devicetree uses this property as of now.
>       Even if any DT did, it wouldn't work, as the pinctrl code checks
>       for 'mediatek,rsel-resistance-in-si-unit'.
> 
>  .../devicetree/bindings/pinctrl/pinctrl-mt8195.yaml    | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: mt8195: Fix name for mediatek,rsel-resistance-in-si-unit
  2022-06-30 12:23 ` AngeloGioacchino Del Regno
@ 2022-07-05 16:38   ` Nícolas F. R. A. Prado
  -1 siblings, 0 replies; 8+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-07-05 16:38 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: linus.walleij, robh+dt, krzysztof.kozlowski+dt, matthias.bgg,
	sean.wang, linux-gpio, devicetree, linux-arm-kernel,
	linux-mediatek, linux-kernel

On Thu, Jun 30, 2022 at 02:23:34PM +0200, AngeloGioacchino Del Regno wrote:
> When this property was introduced, it contained underscores, but
> the actual code wants dashes.
> 
> Change it from mediatek,rsel_resistance_in_si_unit to
> mediatek,rsel-resistance-in-si-unit.
> 
> Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
Nícolas

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: mt8195: Fix name for mediatek,rsel-resistance-in-si-unit
@ 2022-07-05 16:38   ` Nícolas F. R. A. Prado
  0 siblings, 0 replies; 8+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-07-05 16:38 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: linus.walleij, robh+dt, krzysztof.kozlowski+dt, matthias.bgg,
	sean.wang, linux-gpio, devicetree, linux-arm-kernel,
	linux-mediatek, linux-kernel

On Thu, Jun 30, 2022 at 02:23:34PM +0200, AngeloGioacchino Del Regno wrote:
> When this property was introduced, it contained underscores, but
> the actual code wants dashes.
> 
> Change it from mediatek,rsel_resistance_in_si_unit to
> mediatek,rsel-resistance-in-si-unit.
> 
> Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
Nícolas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: mt8195: Fix name for mediatek,rsel-resistance-in-si-unit
  2022-06-30 12:23 ` AngeloGioacchino Del Regno
@ 2022-07-11 11:58   ` Linus Walleij
  -1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2022-07-11 11:58 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sean.wang,
	linux-gpio, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel, nfraprado

On Thu, Jun 30, 2022 at 2:23 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:

> When this property was introduced, it contained underscores, but
> the actual code wants dashes.
>
> Change it from mediatek,rsel_resistance_in_si_unit to
> mediatek,rsel-resistance-in-si-unit.
>
> Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Patch applied!
Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: mt8195: Fix name for mediatek,rsel-resistance-in-si-unit
@ 2022-07-11 11:58   ` Linus Walleij
  0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2022-07-11 11:58 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sean.wang,
	linux-gpio, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel, nfraprado

On Thu, Jun 30, 2022 at 2:23 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:

> When this property was introduced, it contained underscores, but
> the actual code wants dashes.
>
> Change it from mediatek,rsel_resistance_in_si_unit to
> mediatek,rsel-resistance-in-si-unit.
>
> Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Patch applied!
Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-07-11 11:59 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-30 12:23 [PATCH] dt-bindings: pinctrl: mt8195: Fix name for mediatek,rsel-resistance-in-si-unit AngeloGioacchino Del Regno
2022-06-30 12:23 ` AngeloGioacchino Del Regno
2022-07-01 20:11 ` Rob Herring
2022-07-01 20:11   ` Rob Herring
2022-07-05 16:38 ` Nícolas F. R. A. Prado
2022-07-05 16:38   ` Nícolas F. R. A. Prado
2022-07-11 11:58 ` Linus Walleij
2022-07-11 11:58   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.