* [PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code
@ 2014-02-26 19:12 ` Stephen Boyd
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2014-02-26 19:12 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, Bjorn Andersson
The compatible string doesn't have an x in it. Fix it. Also
remove the "qcom" prefix from pins and functions as this binding
uses the generic pinctrl bindings for the pins and functions.
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
.../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
index 4c352be5dd61..9fb89e3f61ea 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
@@ -1,7 +1,7 @@
Qualcomm MSM8974 TLMM block
Required properties:
-- compatible: "qcom,msm8x74-pinctrl"
+- compatible: "qcom,msm8974-pinctrl"
- reg: Should be the base address and length of the TLMM block.
- interrupts: Should be the parent IRQ of the TLMM block.
- interrupt-controller: Marks the device node as an interrupt controller.
@@ -42,14 +42,14 @@ Non-empty subnodes must specify the 'pins' property.
Note that not all properties are valid for all pins.
-Valid values for qcom,pins are:
+Valid values for pins are:
gpio0-gpio145
Supports mux, bias and drive-strength
sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data
Supports bias and drive-strength
-Valid values for qcom,function are:
+Valid values for function are:
blsp_i2c2, blsp_i2c6, blsp_i2c11, blsp_spi1, blsp_uart2, blsp_uart8, slimbus
(Note that this is not yet the complete list of functions)
@@ -73,18 +73,18 @@ Example:
uart2_default: uart2_default {
mux {
- qcom,pins = "gpio4", "gpio5";
- qcom,function = "blsp_uart2";
+ pins = "gpio4", "gpio5";
+ function = "blsp_uart2";
};
tx {
- qcom,pins = "gpio4";
+ pins = "gpio4";
drive-strength = <4>;
bias-disable;
};
rx {
- qcom,pins = "gpio5";
+ pins = "gpio5";
drive-strength = <2>;
bias-pull-up;
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code
@ 2014-02-26 19:12 ` Stephen Boyd
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2014-02-26 19:12 UTC (permalink / raw)
To: linux-arm-kernel
The compatible string doesn't have an x in it. Fix it. Also
remove the "qcom" prefix from pins and functions as this binding
uses the generic pinctrl bindings for the pins and functions.
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
.../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
index 4c352be5dd61..9fb89e3f61ea 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
@@ -1,7 +1,7 @@
Qualcomm MSM8974 TLMM block
Required properties:
-- compatible: "qcom,msm8x74-pinctrl"
+- compatible: "qcom,msm8974-pinctrl"
- reg: Should be the base address and length of the TLMM block.
- interrupts: Should be the parent IRQ of the TLMM block.
- interrupt-controller: Marks the device node as an interrupt controller.
@@ -42,14 +42,14 @@ Non-empty subnodes must specify the 'pins' property.
Note that not all properties are valid for all pins.
-Valid values for qcom,pins are:
+Valid values for pins are:
gpio0-gpio145
Supports mux, bias and drive-strength
sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data
Supports bias and drive-strength
-Valid values for qcom,function are:
+Valid values for function are:
blsp_i2c2, blsp_i2c6, blsp_i2c11, blsp_spi1, blsp_uart2, blsp_uart8, slimbus
(Note that this is not yet the complete list of functions)
@@ -73,18 +73,18 @@ Example:
uart2_default: uart2_default {
mux {
- qcom,pins = "gpio4", "gpio5";
- qcom,function = "blsp_uart2";
+ pins = "gpio4", "gpio5";
+ function = "blsp_uart2";
};
tx {
- qcom,pins = "gpio4";
+ pins = "gpio4";
drive-strength = <4>;
bias-disable;
};
rx {
- qcom,pins = "gpio5";
+ pins = "gpio5";
drive-strength = <2>;
bias-pull-up;
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code
2014-02-26 19:12 ` Stephen Boyd
(?)
@ 2014-02-27 16:00 ` Bjorn Andersson
-1 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2014-02-27 16:00 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linus Walleij, linux-kernel, linux-arm-msm, linux-arm-kernel,
Bjorn Andersson
On Wed, Feb 26, 2014 at 11:12 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> The compatible string doesn't have an x in it. Fix it. Also
> remove the "qcom" prefix from pins and functions as this binding
> uses the generic pinctrl bindings for the pins and functions.
>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks Stephen, this looks good. Sorry for missing this before.
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code
@ 2014-02-27 16:00 ` Bjorn Andersson
0 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2014-02-27 16:00 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linus Walleij, linux-kernel, linux-arm-msm, linux-arm-kernel,
Bjorn Andersson
On Wed, Feb 26, 2014 at 11:12 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> The compatible string doesn't have an x in it. Fix it. Also
> remove the "qcom" prefix from pins and functions as this binding
> uses the generic pinctrl bindings for the pins and functions.
>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks Stephen, this looks good. Sorry for missing this before.
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code
@ 2014-02-27 16:00 ` Bjorn Andersson
0 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2014-02-27 16:00 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Feb 26, 2014 at 11:12 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> The compatible string doesn't have an x in it. Fix it. Also
> remove the "qcom" prefix from pins and functions as this binding
> uses the generic pinctrl bindings for the pins and functions.
>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks Stephen, this looks good. Sorry for missing this before.
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code
2014-02-26 19:12 ` Stephen Boyd
(?)
@ 2014-03-07 1:28 ` Linus Walleij
-1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2014-03-07 1:28 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, Bjorn Andersson
On Thu, Feb 27, 2014 at 3:12 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> The compatible string doesn't have an x in it. Fix it. Also
> remove the "qcom" prefix from pins and functions as this binding
> uses the generic pinctrl bindings for the pins and functions.
>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks Stephen, patch applied with Björn's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code
@ 2014-03-07 1:28 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2014-03-07 1:28 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, Bjorn Andersson
On Thu, Feb 27, 2014 at 3:12 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> The compatible string doesn't have an x in it. Fix it. Also
> remove the "qcom" prefix from pins and functions as this binding
> uses the generic pinctrl bindings for the pins and functions.
>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks Stephen, patch applied with Björn's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code
@ 2014-03-07 1:28 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2014-03-07 1:28 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 27, 2014 at 3:12 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> The compatible string doesn't have an x in it. Fix it. Also
> remove the "qcom" prefix from pins and functions as this binding
> uses the generic pinctrl bindings for the pins and functions.
>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks Stephen, patch applied with Bj?rn's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-03-07 1:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-26 19:12 [PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code Stephen Boyd
2014-02-26 19:12 ` Stephen Boyd
2014-02-27 16:00 ` Bjorn Andersson
2014-02-27 16:00 ` Bjorn Andersson
2014-02-27 16:00 ` Bjorn Andersson
2014-03-07 1:28 ` Linus Walleij
2014-03-07 1:28 ` Linus Walleij
2014-03-07 1:28 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.