* [PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text
@ 2018-05-01 3:00 Manivannan Sadhasivam
2018-05-01 4:23 ` Randy Dunlap
2018-05-02 11:49 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2018-05-01 3:00 UTC (permalink / raw)
To: linus.walleij, afaerber, rdunlap, sfr
Cc: linux-next, linux-gpio, linux-kernel, Manivannan Sadhasivam
1. Fix Kconfig dependency for Actions Semi S900 pinctrl driver which
generates below warning in x86:
WARNING: unmet direct dependencies detected for PINCTRL_OWL
Depends on [n]: PINCTRL [=y] && (ARCH_ACTIONS || COMPILE_TEST [=n]) && OF [=n]
Selected by [y]:
- PINCTRL_S900 [=y] && PINCTRL [=y]
2. Add help text for OWL pinctrl driver
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/pinctrl/actions/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/actions/Kconfig b/drivers/pinctrl/actions/Kconfig
index 1c7309c90f0d..ede97cdbbc12 100644
--- a/drivers/pinctrl/actions/Kconfig
+++ b/drivers/pinctrl/actions/Kconfig
@@ -1,12 +1,14 @@
config PINCTRL_OWL
- bool
+ bool "Actions Semi OWL pinctrl driver"
depends on (ARCH_ACTIONS || COMPILE_TEST) && OF
select PINMUX
select PINCONF
select GENERIC_PINCONF
+ help
+ Say Y here to enable Actions Semi OWL pinctrl driver
config PINCTRL_S900
bool "Actions Semi S900 pinctrl driver"
- select PINCTRL_OWL
+ depends on PINCTRL_OWL
help
Say Y here to enable Actions Semi S900 pinctrl driver
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text
2018-05-01 3:00 [PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text Manivannan Sadhasivam
@ 2018-05-01 4:23 ` Randy Dunlap
2018-05-02 11:49 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2018-05-01 4:23 UTC (permalink / raw)
To: Manivannan Sadhasivam, linus.walleij, afaerber, sfr
Cc: linux-next, linux-gpio, linux-kernel
On 04/30/2018 08:00 PM, Manivannan Sadhasivam wrote:
> 1. Fix Kconfig dependency for Actions Semi S900 pinctrl driver which
> generates below warning in x86:
>
> WARNING: unmet direct dependencies detected for PINCTRL_OWL
> Depends on [n]: PINCTRL [=y] && (ARCH_ACTIONS || COMPILE_TEST [=n]) && OF [=n]
> Selected by [y]:
> - PINCTRL_S900 [=y] && PINCTRL [=y]
>
> 2. Add help text for OWL pinctrl driver
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/pinctrl/actions/Kconfig | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/actions/Kconfig b/drivers/pinctrl/actions/Kconfig
> index 1c7309c90f0d..ede97cdbbc12 100644
> --- a/drivers/pinctrl/actions/Kconfig
> +++ b/drivers/pinctrl/actions/Kconfig
> @@ -1,12 +1,14 @@
> config PINCTRL_OWL
> - bool
> + bool "Actions Semi OWL pinctrl driver"
> depends on (ARCH_ACTIONS || COMPILE_TEST) && OF
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> + help
> + Say Y here to enable Actions Semi OWL pinctrl driver
>
> config PINCTRL_S900
> bool "Actions Semi S900 pinctrl driver"
> - select PINCTRL_OWL
> + depends on PINCTRL_OWL
> help
> Say Y here to enable Actions Semi S900 pinctrl driver
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text
2018-05-01 3:00 [PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text Manivannan Sadhasivam
2018-05-01 4:23 ` Randy Dunlap
@ 2018-05-02 11:49 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-05-02 11:49 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Andreas Färber, Randy Dunlap, Stephen Rothwell,
Linux-Next Mailing List, open list:GPIO SUBSYSTEM, linux-kernel
On Tue, May 1, 2018 at 5:00 AM, Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
> 1. Fix Kconfig dependency for Actions Semi S900 pinctrl driver which
> generates below warning in x86:
>
> WARNING: unmet direct dependencies detected for PINCTRL_OWL
> Depends on [n]: PINCTRL [=y] && (ARCH_ACTIONS || COMPILE_TEST [=n]) && OF [=n]
> Selected by [y]:
> - PINCTRL_S900 [=y] && PINCTRL [=y]
>
> 2. Add help text for OWL pinctrl driver
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Patch applied with Randy's tags.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-02 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 3:00 [PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text Manivannan Sadhasivam
2018-05-01 4:23 ` Randy Dunlap
2018-05-02 11:49 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.