From: Linus Walleij <linus.walleij@linaro.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Alexander Stein <alexander.stein@systec-electronic.com>,
Linux Input <linux-input@vger.kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Guenter Roeck <linux@roeck-us.net>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] gpiolib: handle probe deferrals better
Date: Wed, 6 Apr 2016 15:39:13 +0200 [thread overview]
Message-ID: <CACRpkdbzRPfEgdcPrQzDBQxVUnpdJFoGSFqeQ82tohfCAE11_g@mail.gmail.com> (raw)
In-Reply-To: <570294A4.2070801@ti.com>
On Mon, Apr 4, 2016 at 6:21 PM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
> Below is RFC patch to prove above consent. I've had offlist
> debugging session with Alexander and He mentioned that this change
> fixes boot issue for him.
Thanks for looking into this.
> Of course, there are some question to discuss:
> 1) [+] It should sync initialization of GPIOchip and GPIOirqchip
> 2) [+] This approach requires changes in gpiolib/gpio drivers only, from other side
> It will require to add fixes all over the Kernel if gpiod_to_irq() will
> start returning -EPROBE_DEFER.
Yes, so it will need to be cross-coordinated with IRQ maintainers
Marc and TGLX.
> 3) [-] has_irq might need to be initialized by non-DT drivers
Yes. Every driver in the kernel need to be audited.
> 4) [-] irq_ready might need to be set manually by drivers which do not use GPIO irq
> helpers (see change in gpio-mpc8xxx.c)
Yes. That too. Every driver in the kernel need to be audited.
> 4) irq_ready access synchronization on SMP? atomic?
Uhhh.... I don't even understand the question.
> job done with commit e6918cd 'gpiolib: handle probe deferrals better'
> reverted.
I have taken that out of my tree as well. My naive approach
doesn't work.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-04-06 13:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 11:44 [PATCH] gpiolib: handle probe deferrals better Linus Walleij
2016-04-01 12:16 ` Alexander Stein
2016-04-01 13:03 ` Linus Walleij
2016-04-01 13:42 ` Alexander Stein
2016-04-01 14:03 ` Grygorii Strashko
2016-04-01 14:35 ` Alexander Stein
2016-04-01 14:04 ` Guenter Roeck
2016-04-01 17:52 ` Bjorn Andersson
2016-04-01 12:42 ` Guenter Roeck
2016-04-01 13:28 ` Grygorii Strashko
2016-04-04 16:21 ` Grygorii Strashko
2016-04-06 13:39 ` Linus Walleij [this message]
2016-04-06 15:42 ` Grygorii Strashko
2016-04-07 17:09 ` Linus Walleij
2016-04-11 6:10 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbzRPfEgdcPrQzDBQxVUnpdJFoGSFqeQ82tohfCAE11_g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=acourbot@nvidia.com \
--cc=alexander.stein@systec-electronic.com \
--cc=bjorn.andersson@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.