All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kcov: do not instrument lib/stackdepot.c
@ 2016-09-23 14:29 Alexander Potapenko
  2016-09-23 14:38 ` Dmitry Vyukov
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Potapenko @ 2016-09-23 14:29 UTC (permalink / raw)
  To: dvyukov, kcc, akpm, andreyknvl; +Cc: linux-kernel, syzkaller

There's no point in collecting coverage from lib/stackdepot.c, as it is
not a function of syscall inputs. Disabling kcov instrumentation for
that file will reduce the coverage noise level.

Signed-off-by: Alexander Potapenko <glider@google.com>
---
 lib/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/Makefile b/lib/Makefile
index 5dc77a8..cbac596 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -180,6 +180,7 @@ obj-$(CONFIG_IRQ_POLL) += irq_poll.o
 
 obj-$(CONFIG_STACKDEPOT) += stackdepot.o
 KASAN_SANITIZE_stackdepot.o := n
+KCOV_INSTRUMENT_stackdepot.o := n
 
 libfdt_files = fdt.o fdt_ro.o fdt_wip.o fdt_rw.o fdt_sw.o fdt_strerror.o \
 	       fdt_empty_tree.o
-- 
2.8.0.rc3.226.g39d4020

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kcov: do not instrument lib/stackdepot.c
  2016-09-23 14:29 [PATCH] kcov: do not instrument lib/stackdepot.c Alexander Potapenko
@ 2016-09-23 14:38 ` Dmitry Vyukov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Vyukov @ 2016-09-23 14:38 UTC (permalink / raw)
  To: Alexander Potapenko
  Cc: Kostya Serebryany, Andrew Morton, Andrey Konovalov, LKML, syzkaller

On Fri, Sep 23, 2016 at 4:29 PM, Alexander Potapenko <glider@google.com> wrote:
> There's no point in collecting coverage from lib/stackdepot.c, as it is
> not a function of syscall inputs. Disabling kcov instrumentation for
> that file will reduce the coverage noise level.
>
> Signed-off-by: Alexander Potapenko <glider@google.com>

Acked-by: Dmitry Vyukov <dvyukov@google.com>


> ---
>  lib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 5dc77a8..cbac596 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -180,6 +180,7 @@ obj-$(CONFIG_IRQ_POLL) += irq_poll.o
>
>  obj-$(CONFIG_STACKDEPOT) += stackdepot.o
>  KASAN_SANITIZE_stackdepot.o := n
> +KCOV_INSTRUMENT_stackdepot.o := n
>
>  libfdt_files = fdt.o fdt_ro.o fdt_wip.o fdt_rw.o fdt_sw.o fdt_strerror.o \
>                fdt_empty_tree.o
> --
> 2.8.0.rc3.226.g39d4020
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-23 14:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-23 14:29 [PATCH] kcov: do not instrument lib/stackdepot.c Alexander Potapenko
2016-09-23 14:38 ` Dmitry Vyukov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.