All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Vyukov <dvyukov@google.com>
To: syzbot <syzbot+c613e88b3093ebf3686e@syzkaller.appspotmail.com>
Cc: anant.thazhemadam@gmail.com, bjorn.andersson@linaro.org,
	butterflyhuangxx@gmail.com, davem@davemloft.net,
	dragonjetli@gmail.com, hdanton@sina.com, kuba@kernel.org,
	linux-arm-msm@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org, mani@kernel.org,
	manivannan.sadhasivam@linaro.org, masahiroy@kernel.org,
	netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] WARNING: refcount bug in qrtr_node_lookup
Date: Mon, 30 Aug 2021 10:39:18 +0200	[thread overview]
Message-ID: <CACT4Y+Z1OG0bPB-bfMRS6vN4Ogx8n3_8v+e+WCshLwz7apvnHg@mail.gmail.com> (raw)
In-Reply-To: <00000000000069bb3e05caa2d1f8@google.com>

On Sat, 28 Aug 2021 at 20:32, syzbot
<syzbot+c613e88b3093ebf3686e@syzkaller.appspotmail.com> wrote:
>
> syzbot suspects this issue was fixed by commit:
>
> commit 7e78c597c3ebfd0cb329aa09a838734147e4f117
> Author: Xiaolong Huang <butterflyhuangxx@gmail.com>
> Date:   Thu Aug 19 19:50:34 2021 +0000
>
>     net: qrtr: fix another OOB Read in qrtr_endpoint_post
>
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=11279a4d300000
> start commit:   ba4f184e126b Linux 5.9-rc6
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=af502ec9a451c9fc
> dashboard link: https://syzkaller.appspot.com/bug?extid=c613e88b3093ebf3686e
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=12263dd9900000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13d77603900000
>
> If the result looks correct, please mark the issue as fixed by replying with:
>
> #syz fix: net: qrtr: fix another OOB Read in qrtr_endpoint_post
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Hi Hillf,

You posted some patch related to refcounts. Do you think "net: qrtr:
fix another OOB Read in qrtr_endpoint_post" is a plausible fix? Or is
there still something wrong with refcounts?

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Vyukov via Linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org>
To: syzbot <syzbot+c613e88b3093ebf3686e@syzkaller.appspotmail.com>
Cc: anant.thazhemadam@gmail.com, mani@kernel.org,
	butterflyhuangxx@gmail.com, linux-arm-msm@vger.kernel.org,
	manivannan.sadhasivam@linaro.org,
	syzkaller-bugs@googlegroups.com, hdanton@sina.com,
	bjorn.andersson@linaro.org, netdev@vger.kernel.org,
	dragonjetli@gmail.com, kuba@kernel.org, masahiroy@kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [syzbot] WARNING: refcount bug in qrtr_node_lookup
Date: Mon, 30 Aug 2021 10:39:18 +0200	[thread overview]
Message-ID: <CACT4Y+Z1OG0bPB-bfMRS6vN4Ogx8n3_8v+e+WCshLwz7apvnHg@mail.gmail.com> (raw)
In-Reply-To: <00000000000069bb3e05caa2d1f8@google.com>

On Sat, 28 Aug 2021 at 20:32, syzbot
<syzbot+c613e88b3093ebf3686e@syzkaller.appspotmail.com> wrote:
>
> syzbot suspects this issue was fixed by commit:
>
> commit 7e78c597c3ebfd0cb329aa09a838734147e4f117
> Author: Xiaolong Huang <butterflyhuangxx@gmail.com>
> Date:   Thu Aug 19 19:50:34 2021 +0000
>
>     net: qrtr: fix another OOB Read in qrtr_endpoint_post
>
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=11279a4d300000
> start commit:   ba4f184e126b Linux 5.9-rc6
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=af502ec9a451c9fc
> dashboard link: https://syzkaller.appspot.com/bug?extid=c613e88b3093ebf3686e
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=12263dd9900000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13d77603900000
>
> If the result looks correct, please mark the issue as fixed by replying with:
>
> #syz fix: net: qrtr: fix another OOB Read in qrtr_endpoint_post
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Hi Hillf,

You posted some patch related to refcounts. Do you think "net: qrtr:
fix another OOB Read in qrtr_endpoint_post" is a plausible fix? Or is
there still something wrong with refcounts?
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2021-08-30  8:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 21:18 WARNING: refcount bug in qrtr_node_lookup syzbot
2021-08-28 18:32 ` [syzbot] " syzbot
2021-08-28 18:32   ` syzbot
2021-08-30  8:39   ` Dmitry Vyukov [this message]
2021-08-30  8:39     ` Dmitry Vyukov via Linux-kernel-mentees
     [not found] <20210901030636.2336-1-hdanton@sina.com>
2021-09-01  3:41 ` syzbot
2021-09-01  4:26   ` Eric Dumazet
     [not found] <20210902005238.2413-1-hdanton@sina.com>
2021-09-02  2:32 ` syzbot
     [not found]   ` <20210902041238.2559-1-hdanton@sina.com>
2021-09-02 13:58     ` Paul Moore
2021-09-03  2:40       ` Paul Moore
     [not found] <20210903042820.2733-1-hdanton@sina.com>
2021-09-03 11:04 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACT4Y+Z1OG0bPB-bfMRS6vN4Ogx8n3_8v+e+WCshLwz7apvnHg@mail.gmail.com \
    --to=dvyukov@google.com \
    --cc=anant.thazhemadam@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=butterflyhuangxx@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dragonjetli@gmail.com \
    --cc=hdanton@sina.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=masahiroy@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+c613e88b3093ebf3686e@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.