* [syzbot] WARNING in qt2_attach/usb_submit_urb
@ 2021-05-24 9:12 syzbot
2021-05-24 9:18 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: syzbot @ 2021-05-24 9:12 UTC (permalink / raw)
To: gregkh, johan, linux-kernel, linux-usb, mathias.nyman, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: 5cc59c41 USB: core: WARN if pipe direction != setup packet..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=12dabf53d00000
kernel config: https://syzkaller.appspot.com/x/.config?x=1206ee92dd3d988d
dashboard link: https://syzkaller.appspot.com/bug?extid=19acce48d8344df49b3a
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1198ed07d00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1772f1ddd00000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+19acce48d8344df49b3a@syzkaller.appspotmail.com
usb 1-1: string descriptor 0 read error: -22
usb 1-1: New USB device found, idVendor=061d, idProduct=c170, bcdDevice=11.41
usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
quatech2 1-1:31.224: Quatech 2nd gen USB to Serial Driver converter detected
------------[ cut here ]------------
usb 1-1: BOGUS control dir, pipe 80000280 doesn't match bRequestType 40
WARNING: CPU: 1 PID: 2635 at drivers/usb/core/urb.c:410 usb_submit_urb+0x14aa/0x1830 drivers/usb/core/urb.c:410
Modules linked in:
CPU: 1 PID: 2635 Comm: kworker/1:2 Not tainted 5.13.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:usb_submit_urb+0x14aa/0x1830 drivers/usb/core/urb.c:410
Code: 84 4c 01 00 00 e8 a6 14 b3 fd 4c 89 f7 e8 4e a7 1b ff 45 89 e8 44 89 e1 48 89 ea 48 89 c6 48 c7 c7 c0 09 63 86 e8 18 f1 fb 01 <0f> 0b 49 8d 4f 5c 48 b8 00 00 00 00 00 fc ff df 48 89 ca 48 89 4c
RSP: 0018:ffffc900001b6e08 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff888116d8c058 RCX: 0000000000000000
RDX: ffff888114e61b40 RSI: ffffffff812a6013 RDI: fffff52000036db3
RBP: ffff888109d7e690 R08: 0000000000000001 R09: 0000000000000000
R10: ffffffff814b996b R11: 0000000000000000 R12: 0000000080000280
R13: 0000000000000040 R14: ffff888116d8c0a8 R15: ffff8881097ac900
FS: 0000000000000000(0000) GS:ffff8881f6900000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055777d5bd160 CR3: 00000001045ec000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
usb_start_wait_urb+0x101/0x4c0 drivers/usb/core/message.c:58
usb_internal_control_msg drivers/usb/core/message.c:102 [inline]
usb_control_msg+0x31c/0x4a0 drivers/usb/core/message.c:153
qt2_attach+0x82/0x550 drivers/usb/serial/quatech2.c:642
usb_serial_probe.cold+0x1229/0x292b drivers/usb/serial/usb-serial.c:1122
usb_probe_interface+0x315/0x7f0 drivers/usb/core/driver.c:396
really_probe+0x291/0xf60 drivers/base/dd.c:576
driver_probe_device+0x298/0x410 drivers/base/dd.c:763
__device_attach_driver+0x203/0x2c0 drivers/base/dd.c:870
bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431
__device_attach+0x228/0x4b0 drivers/base/dd.c:938
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491
device_add+0xbe0/0x2100 drivers/base/core.c:3320
usb_set_configuration+0x113f/0x1910 drivers/usb/core/message.c:2164
usb_generic_driver_probe+0xba/0x100 drivers/usb/core/generic.c:238
usb_probe_device+0xd9/0x2c0 drivers/usb/core/driver.c:293
really_probe+0x291/0xf60 drivers/base/dd.c:576
driver_probe_device+0x298/0x410 drivers/base/dd.c:763
__device_attach_driver+0x203/0x2c0 drivers/base/dd.c:870
bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431
__device_attach+0x228/0x4b0 drivers/base/dd.c:938
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491
device_add+0xbe0/0x2100 drivers/base/core.c:3320
usb_new_device.cold+0x721/0x1058 drivers/usb/core/hub.c:2556
hub_port_connect drivers/usb/core/hub.c:5297 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5437 [inline]
port_event drivers/usb/core/hub.c:5583 [inline]
hub_event+0x2357/0x4330 drivers/usb/core/hub.c:5665
process_one_work+0x98d/0x1580 kernel/workqueue.c:2275
worker_thread+0x64c/0x1120 kernel/workqueue.c:2421
kthread+0x38c/0x460 kernel/kthread.c:313
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [syzbot] WARNING in qt2_attach/usb_submit_urb
2021-05-24 9:12 [syzbot] WARNING in qt2_attach/usb_submit_urb syzbot
@ 2021-05-24 9:18 ` Johan Hovold
2021-05-25 9:04 ` Dmitry Vyukov
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2021-05-24 9:18 UTC (permalink / raw)
To: syzbot; +Cc: gregkh, linux-kernel, linux-usb, mathias.nyman, syzkaller-bugs
On Mon, May 24, 2021 at 02:12:25AM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 5cc59c41 USB: core: WARN if pipe direction != setup packet..
> git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> console output: https://syzkaller.appspot.com/x/log.txt?x=12dabf53d00000
> kernel config: https://syzkaller.appspot.com/x/.config?x=1206ee92dd3d988d
> dashboard link: https://syzkaller.appspot.com/bug?extid=19acce48d8344df49b3a
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1198ed07d00000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1772f1ddd00000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+19acce48d8344df49b3a@syzkaller.appspotmail.com
>
> usb 1-1: string descriptor 0 read error: -22
> usb 1-1: New USB device found, idVendor=061d, idProduct=c170, bcdDevice=11.41
> usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> quatech2 1-1:31.224: Quatech 2nd gen USB to Serial Driver converter detected
> ------------[ cut here ]------------
> usb 1-1: BOGUS control dir, pipe 80000280 doesn't match bRequestType 40
> WARNING: CPU: 1 PID: 2635 at drivers/usb/core/urb.c:410 usb_submit_urb+0x14aa/0x1830 drivers/usb/core/urb.c:410
> Modules linked in:
> CPU: 1 PID: 2635 Comm: kworker/1:2 Not tainted 5.13.0-rc2-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> Workqueue: usb_hub_wq hub_event
> RIP: 0010:usb_submit_urb+0x14aa/0x1830 drivers/usb/core/urb.c:410
> Code: 84 4c 01 00 00 e8 a6 14 b3 fd 4c 89 f7 e8 4e a7 1b ff 45 89 e8 44 89 e1 48 89 ea 48 89 c6 48 c7 c7 c0 09 63 86 e8 18 f1 fb 01 <0f> 0b 49 8d 4f 5c 48 b8 00 00 00 00 00 fc ff df 48 89 ca 48 89 4c
> RSP: 0018:ffffc900001b6e08 EFLAGS: 00010286
> RAX: 0000000000000000 RBX: ffff888116d8c058 RCX: 0000000000000000
> RDX: ffff888114e61b40 RSI: ffffffff812a6013 RDI: fffff52000036db3
> RBP: ffff888109d7e690 R08: 0000000000000001 R09: 0000000000000000
> R10: ffffffff814b996b R11: 0000000000000000 R12: 0000000080000280
> R13: 0000000000000040 R14: ffff888116d8c0a8 R15: ffff8881097ac900
> FS: 0000000000000000(0000) GS:ffff8881f6900000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 000055777d5bd160 CR3: 00000001045ec000 CR4: 00000000001506e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> usb_start_wait_urb+0x101/0x4c0 drivers/usb/core/message.c:58
> usb_internal_control_msg drivers/usb/core/message.c:102 [inline]
> usb_control_msg+0x31c/0x4a0 drivers/usb/core/message.c:153
> qt2_attach+0x82/0x550 drivers/usb/serial/quatech2.c:642
I had already found this one but not yet posted the v2. Should be fixed
here:
https://lore.kernel.org/r/20210524091705.4282-1-johan@kernel.org
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [syzbot] WARNING in qt2_attach/usb_submit_urb
2021-05-24 9:18 ` Johan Hovold
@ 2021-05-25 9:04 ` Dmitry Vyukov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Vyukov @ 2021-05-25 9:04 UTC (permalink / raw)
To: Johan Hovold
Cc: syzbot, Greg Kroah-Hartman, LKML, USB list, mathias.nyman,
syzkaller-bugs
On Mon, May 24, 2021 at 11:18 AM Johan Hovold <johan@kernel.org> wrote:
>
> On Mon, May 24, 2021 at 02:12:25AM -0700, syzbot wrote:
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit: 5cc59c41 USB: core: WARN if pipe direction != setup packet..
> > git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > console output: https://syzkaller.appspot.com/x/log.txt?x=12dabf53d00000
> > kernel config: https://syzkaller.appspot.com/x/.config?x=1206ee92dd3d988d
> > dashboard link: https://syzkaller.appspot.com/bug?extid=19acce48d8344df49b3a
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1198ed07d00000
> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1772f1ddd00000
> >
> > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > Reported-by: syzbot+19acce48d8344df49b3a@syzkaller.appspotmail.com
> >
> > usb 1-1: string descriptor 0 read error: -22
> > usb 1-1: New USB device found, idVendor=061d, idProduct=c170, bcdDevice=11.41
> > usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> > quatech2 1-1:31.224: Quatech 2nd gen USB to Serial Driver converter detected
> > ------------[ cut here ]------------
> > usb 1-1: BOGUS control dir, pipe 80000280 doesn't match bRequestType 40
> > WARNING: CPU: 1 PID: 2635 at drivers/usb/core/urb.c:410 usb_submit_urb+0x14aa/0x1830 drivers/usb/core/urb.c:410
> > Modules linked in:
> > CPU: 1 PID: 2635 Comm: kworker/1:2 Not tainted 5.13.0-rc2-syzkaller #0
> > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> > Workqueue: usb_hub_wq hub_event
> > RIP: 0010:usb_submit_urb+0x14aa/0x1830 drivers/usb/core/urb.c:410
> > Code: 84 4c 01 00 00 e8 a6 14 b3 fd 4c 89 f7 e8 4e a7 1b ff 45 89 e8 44 89 e1 48 89 ea 48 89 c6 48 c7 c7 c0 09 63 86 e8 18 f1 fb 01 <0f> 0b 49 8d 4f 5c 48 b8 00 00 00 00 00 fc ff df 48 89 ca 48 89 4c
> > RSP: 0018:ffffc900001b6e08 EFLAGS: 00010286
> > RAX: 0000000000000000 RBX: ffff888116d8c058 RCX: 0000000000000000
> > RDX: ffff888114e61b40 RSI: ffffffff812a6013 RDI: fffff52000036db3
> > RBP: ffff888109d7e690 R08: 0000000000000001 R09: 0000000000000000
> > R10: ffffffff814b996b R11: 0000000000000000 R12: 0000000080000280
> > R13: 0000000000000040 R14: ffff888116d8c0a8 R15: ffff8881097ac900
> > FS: 0000000000000000(0000) GS:ffff8881f6900000(0000) knlGS:0000000000000000
> > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > CR2: 000055777d5bd160 CR3: 00000001045ec000 CR4: 00000000001506e0
> > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> > Call Trace:
> > usb_start_wait_urb+0x101/0x4c0 drivers/usb/core/message.c:58
> > usb_internal_control_msg drivers/usb/core/message.c:102 [inline]
> > usb_control_msg+0x31c/0x4a0 drivers/usb/core/message.c:153
> > qt2_attach+0x82/0x550 drivers/usb/serial/quatech2.c:642
>
> I had already found this one but not yet posted the v2. Should be fixed
> here:
>
> https://lore.kernel.org/r/20210524091705.4282-1-johan@kernel.org
>
> Johan
Hi Johan,
Thanks for double checking.
Let's tell syzbot about the fix:
#syz fix: USB: serial: quatech2: fix control-request directions
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-25 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 9:12 [syzbot] WARNING in qt2_attach/usb_submit_urb syzbot
2021-05-24 9:18 ` Johan Hovold
2021-05-25 9:04 ` Dmitry Vyukov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.