[U-Boot] [PATCH 1/2] MIPS: use inline directive for __in*s functions

* [U-Boot] [PATCH 1/2] MIPS: use inline directive for __in*s functions
@ 2013-01-16 12:39 Gabor Juhos
  2013-01-16 12:39 ` [U-Boot] [PATCH 2/2] MIPS: convert IO port accessor functions to 'static inline' Gabor Juhos
  2013-01-22 20:50 ` [U-Boot] [PATCH 1/2] MIPS: use inline directive for __in*s functions Daniel Schwierzeck
  0 siblings, 2 replies; 4+ messages in thread
From: Gabor Juhos @ 2013-01-16 12:39 UTC (permalink / raw)
  To: u-boot

All other IO accessor functions are using the
'inline' directive. Use that also for the __in*s
to make it consistent with the other variants.

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Cc: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>

---
NOTE: checkpatch.pl throwns an error for the patch:

  0001-MIPS-use-inline-directive-for-__in-s-functions.patch:24: ERROR: open brace '{' following function declarations go on the next line
  total: 1 errors, 0 warnings, 8 lines checked

However that error is already present if the
'arch/mips/include/asm/io.h' file is checked
with checkpatch.pl. The cleanup should be
done in a separare patch.
---
 arch/mips/include/asm/io.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h
index 80eab75..50466f2 100644
--- a/arch/mips/include/asm/io.h
+++ b/arch/mips/include/asm/io.h
@@ -268,7 +268,7 @@ __OUT1(s##c_p) __OUT2(m) : : "r" (__ioswab##w(value)), "ir" (port), "r" (mips_io
 	SLOW_DOWN_IO; }
 
 #define __IN1(t,s) \
-extern __inline__ t __in##s(unsigned int port) { t _v;
+extern inline t __in##s(unsigned int port) { t _v;
 
 /*
  * Required nops will be inserted by the assembler
-- 
1.7.10

^ permalink raw reply related	[flat|nested] 4+ messages in thread