From: Ming Lei <tom.leiming@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@infradead.org>,
Hao Wang <pkuwangh@gmail.com>,
linux-nvme <Linux-nvme@lists.infradead.org>
Subject: Re: Data corruption when using multiple devices with NVMEoF TCP
Date: Tue, 12 Jan 2021 10:22:05 +0800 [thread overview]
Message-ID: <CACVXFVNwhFTq2Aq7bx7cwmhab4itkAntF-TKunv59XoZySy51w@mail.gmail.com> (raw)
In-Reply-To: <fcb56817-1f34-e307-e888-45ebb661c31d@grimberg.me>
On Tue, Jan 12, 2021 at 9:33 AM Sagi Grimberg <sagi@grimberg.me> wrote:
>
>
> > Hey Hao,
> >
> >> Here is the entire log (and it's a new one, i.e. above snippet not
> >> included):
> >> https://drive.google.com/file/d/16ArIs5-Jw4P2f17A_ftKLm1A4LQUFpmg/view?usp=sharing
> >>
> >>
> >> What I found is the data corruption does not always happen, especially
> >> when I copy a small directory. So I guess a lot of log entries should
> >> just look fine.
> >
> > So this seems to be a breakage that existed for some time now with
> > multipage bvecs that you have been the first one to report. This
> > seems to be related to bio merges, which is seems strange to me
> > why this just now comes up, perhaps it is the combination with
> > raid0 that triggers this, I'm not sure.
>
> OK, I think I understand what is going on. With multipage bvecs
> bios can split in the middle of a bvec entry, and then merge
> back with another bio.
IMO, bio split can be done in the middle of a bvec even though the bvec
is single page. The split may just be triggered in case of raid over nvme-tcp,
and I guess it might be triggered by device mapper too.
Thanks,
Ming
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-12 2:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 18:09 Data corruption when using multiple devices with NVMEoF TCP Hao Wang
2020-12-22 19:29 ` Sagi Grimberg
2020-12-22 19:58 ` Hao Wang
2020-12-23 8:41 ` Sagi Grimberg
2020-12-23 8:43 ` Christoph Hellwig
2020-12-23 21:23 ` Sagi Grimberg
2020-12-23 22:23 ` Hao Wang
2020-12-24 1:51 ` Hao Wang
2020-12-24 2:57 ` Sagi Grimberg
2020-12-24 10:28 ` Hao Wang
2020-12-24 17:56 ` Sagi Grimberg
2020-12-25 7:49 ` Hao Wang
2020-12-25 9:05 ` Sagi Grimberg
[not found] ` <CAJS6Edgb+yCW5q5dA=MEkL0eYs4MXoopdiz72nhkxpkd5Fe_cA@mail.gmail.com>
2020-12-29 1:25 ` Sagi Grimberg
2021-01-06 1:53 ` Sagi Grimberg
2021-01-06 8:21 ` Hao Wang
2021-01-11 8:56 ` Hao Wang
2021-01-11 10:11 ` Sagi Grimberg
[not found] ` <CAJS6Edi9Es1zR9QC+=kwVjAFAGYrEru4vibW42ffyWoMDutFhQ@mail.gmail.com>
2021-01-12 0:36 ` Sagi Grimberg
2021-01-12 1:29 ` Sagi Grimberg
2021-01-12 2:22 ` Ming Lei [this message]
2021-01-12 6:49 ` Sagi Grimberg
2021-01-12 8:55 ` Hao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACVXFVNwhFTq2Aq7bx7cwmhab4itkAntF-TKunv59XoZySy51w@mail.gmail.com \
--to=tom.leiming@gmail.com \
--cc=Linux-nvme@lists.infradead.org \
--cc=hch@infradead.org \
--cc=pkuwangh@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.