All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Jens Axboe" <axboe@kernel.dk>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Matias Bjørling" <m@bjorling.me>
Subject: Re: [PATCH] blk-mq: kick requeue list in blk_mq_requeue_request()
Date: Tue, 10 Jun 2014 22:47:13 +0800	[thread overview]
Message-ID: <CACVXFVO3XPd99ARZ+55ttas9ZKNNcUYkC0ckaaENvBGMrQnyUQ@mail.gmail.com> (raw)
In-Reply-To: <20140610124508.GA5671@lst.de>

On Tue, Jun 10, 2014 at 8:45 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Tue, Jun 10, 2014 at 07:45:47PM +0800, Ming Lei wrote:
>> OK, but the API name is a bit confusing, and that is easy to cause
>> misuse, like in nvme.
>>
>> Also requeue one request in completion handler may be a
>> common case, so maybe it is better to let blk_mq_requeue_request()
>> handle both adding to request list and kicking off, and introduce
>> blk_mq_prep_requeue_req()(or better name) to batch operations.
>
> For now please just add some documentation.  I'm happy to revisit
> these once we have a few user in tree, but for now I'd like to keep
> blk-mq a little more stable to not impact the merges of the major
> users.

There are two users: one is nvme, another is scsi-mq, and both
don't need batch operations now.


Thanks,
-- 
Ming Lei

      reply	other threads:[~2014-06-10 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10  4:52 [PATCH] blk-mq: kick requeue list in blk_mq_requeue_request() Ming Lei
2014-06-10 11:28 ` Christoph Hellwig
2014-06-10 11:45   ` Ming Lei
2014-06-10 12:45     ` Christoph Hellwig
2014-06-10 14:47       ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACVXFVO3XPd99ARZ+55ttas9ZKNNcUYkC0ckaaENvBGMrQnyUQ@mail.gmail.com \
    --to=tom.leiming@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@bjorling.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.