[entity-manager]Should I add min,max to legacy.json?

[entity-manager]Should I add min,max to legacy.json?

[Scron Chang (張仲延)]

Hi all,
 
  In my case, lots of dbus-sensors/PSUSensor are using. Refer to the hint in PSUSensorMain.cpp L576 to define the value of maximum/minimum, lots of objects like vout1_max, iout1_min… are defined in my configuration file. Even though it works (check by ipmitool sensor command), this json data can't pass to entity-manager/scripts/validate-configs.py. The reason should be there are no objects of PSU sensors' maximum and minimum in entity-manager/schema/legacy.json. Should I directly add those maximum and minimum objects to schema/legacy.json and submit schema/legacy.json to upstream?
 
Ref: https://github.com/openbmc/dbus-sensors/blob/23c96e7c249b41efecc10ba7acba82603a54b996/src/PSUSensorMain.cpp#L576
 
I would appreciate any suggestions.

Scron Chang
E-Mail  Scron.Chang@quantatw.com
Ext.    11936

Re: [entity-manager]Should I add min,max to legacy.json?

[Ed Tanous]

On Mon, Dec 28, 2020 at 5:57 AM Scron Chang (張仲延)
<Scron.Chang@quantatw.com> wrote:
>
> Hi all,
>
>   In my case, lots of dbus-sensors/PSUSensor are using. Refer to the hint in PSUSensorMain.cpp L576 to define the value of maximum/minimum, lots of objects like vout1_max, iout1_min… are defined in my configuration file. Even though it works (check by ipmitool sensor command), this json data can't pass to entity-manager/scripts/validate-configs.py. The reason should be there are no objects of PSU sensors' maximum and minimum in entity-manager/schema/legacy.json. Should I directly add those maximum and minimum objects to schema/legacy.json and submit schema/legacy.json to upstream?

I missed this in a recent code review to dbus sensors (I thought that
interface already existed);  Yes, please do the above.

>
> Ref: https://github.com/openbmc/dbus-sensors/blob/23c96e7c249b41efecc10ba7acba82603a54b996/src/PSUSensorMain.cpp#L576
>
> I would appreciate any suggestions.
>
> Scron Chang
> E-Mail  Scron.Chang@quantatw.com
> Ext.    11936
>

RE: [entity-manager]Should I add min,max to legacy.json?

[Scron Chang (張仲延)]

Hi Ed,

Thanks for your reply.

I has submitted a commit, and here is the link
https://gerrit.openbmc-project.xyz/c/openbmc/entity-manager/+/39287

Please take a look. Thanks again.

-----Original Message-----
From: Ed Tanous <ed@tanous.net> 
Sent: Tuesday, December 29, 2020 2:29 AM
To: Scron Chang (張仲延) <Scron.Chang@quantatw.com>
Cc: openbmc@lists.ozlabs.org
Subject: Re: [entity-manager]Should I add min,max to legacy.json?

On Mon, Dec 28, 2020 at 5:57 AM Scron Chang (張仲延)
<Scron.Chang@quantatw.com> wrote:
>
> Hi all,
>
>   In my case, lots of dbus-sensors/PSUSensor are using. Refer to the hint in PSUSensorMain.cpp L576 to define the value of maximum/minimum, lots of objects like vout1_max, iout1_min… are defined in my configuration file. Even though it works (check by ipmitool sensor command), this json data can't pass to entity-manager/scripts/validate-configs.py. The reason should be there are no objects of PSU sensors' maximum and minimum in entity-manager/schema/legacy.json. Should I directly add those maximum and minimum objects to schema/legacy.json and submit schema/legacy.json to upstream?

I missed this in a recent code review to dbus sensors (I thought that interface already existed);  Yes, please do the above.

>
> Ref: 
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Fopenbmc%2Fdbus-sensors%2Fblob%2F23c96e7c249b41efecc10ba7acba8
> 2603a54b996%2Fsrc%2FPSUSensorMain.cpp%23L576&amp;data=04%7C01%7CScron.
> Chang%40quantatw.com%7C115f1fe0949b438f668308d8ab5e7192%7C179b032707fc
> 4973ac738de7313561b2%7C1%7C0%7C637447769424304915%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7C1000&amp;sdata=PIQpxjwBrKy172Ibx3Enfugdyp9I3hoxp58gRrCjsro%3D&amp;r
> eserved=0
>
> I would appreciate any suggestions.
>
> Scron Chang
> E-Mail  Scron.Chang@quantatw.com
> Ext.    11936
>