* [PATCH] tee: optee: fix a print error on rng probing
@ 2023-01-18 15:38 Ilias Apalodimas
2023-01-18 16:53 ` Patrick DELAUNAY
0 siblings, 1 reply; 5+ messages in thread
From: Ilias Apalodimas @ 2023-01-18 15:38 UTC (permalink / raw)
To: u-boot
Cc: Ilias Apalodimas, Jens Wiklander, Patrick Delaunay,
Etienne Carriere, Patrice Chotard
If we fail to probe the optee-rng device, we print a wrong message
referring to the firmware tpm.
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
drivers/tee/optee/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index a813a84a4f16..88e23d252bcd 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev)
ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng",
dev_ofnode(dev), NULL);
if (ret)
- dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret);
+ dev_warn(dev, "optee-rng failed to bind: %d\n", ret);
}
return 0;
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tee: optee: fix a print error on rng probing
2023-01-18 15:38 [PATCH] tee: optee: fix a print error on rng probing Ilias Apalodimas
@ 2023-01-18 16:53 ` Patrick DELAUNAY
2023-01-18 18:54 ` Ilias Apalodimas
0 siblings, 1 reply; 5+ messages in thread
From: Patrick DELAUNAY @ 2023-01-18 16:53 UTC (permalink / raw)
To: Ilias Apalodimas, u-boot
Cc: Jens Wiklander, Etienne Carriere, Patrice Chotard
Hi
On 1/18/23 16:38, Ilias Apalodimas wrote:
> If we fail to probe the optee-rng device, we print a wrong message
> referring to the firmware tpm.
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
> drivers/tee/optee/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index a813a84a4f16..88e23d252bcd 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev)
> ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng",
> dev_ofnode(dev), NULL);
> if (ret)
> - dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret);
> + dev_warn(dev, "optee-rng failed to bind: %d\n", ret);
> }
>
> return 0;
I think you can add:
Fixes: 476a3d58dfeb ("tee: optee: don't fail probe because of optee-rng")
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tee: optee: fix a print error on rng probing
2023-01-18 16:53 ` Patrick DELAUNAY
@ 2023-01-18 18:54 ` Ilias Apalodimas
2023-01-18 22:51 ` Etienne Carriere
0 siblings, 1 reply; 5+ messages in thread
From: Ilias Apalodimas @ 2023-01-18 18:54 UTC (permalink / raw)
To: Patrick DELAUNAY
Cc: u-boot, Jens Wiklander, Etienne Carriere, Patrice Chotard
Thanks Patrick,
On Wed, 18 Jan 2023 at 18:53, Patrick DELAUNAY
<patrick.delaunay@foss.st.com> wrote:
>
> Hi
>
> On 1/18/23 16:38, Ilias Apalodimas wrote:
> > If we fail to probe the optee-rng device, we print a wrong message
> > referring to the firmware tpm.
> >
> > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > ---
> > drivers/tee/optee/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> > index a813a84a4f16..88e23d252bcd 100644
> > --- a/drivers/tee/optee/core.c
> > +++ b/drivers/tee/optee/core.c
> > @@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev)
> > ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng",
> > dev_ofnode(dev), NULL);
> > if (ret)
> > - dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret);
> > + dev_warn(dev, "optee-rng failed to bind: %d\n", ret);
> > }
> >
> > return 0;
>
>
> I think you can add:
>
> Fixes: 476a3d58dfeb ("tee: optee: don't fail probe because of optee-rng")
>
>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Sure I'll wait for additional reviews etc and respin
Cheers
/Ilias
>
> Thanks
> Patrick
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tee: optee: fix a print error on rng probing
2023-01-18 18:54 ` Ilias Apalodimas
@ 2023-01-18 22:51 ` Etienne Carriere
2023-01-19 6:45 ` Jens Wiklander
0 siblings, 1 reply; 5+ messages in thread
From: Etienne Carriere @ 2023-01-18 22:51 UTC (permalink / raw)
To: Ilias Apalodimas
Cc: Patrick DELAUNAY, u-boot, Jens Wiklander, Patrice Chotard
On Wed, 18 Jan 2023 at 19:54, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> Thanks Patrick,
>
> On Wed, 18 Jan 2023 at 18:53, Patrick DELAUNAY
> <patrick.delaunay@foss.st.com> wrote:
> >
> > Hi
> >
> > On 1/18/23 16:38, Ilias Apalodimas wrote:
> > > If we fail to probe the optee-rng device, we print a wrong message
> > > referring to the firmware tpm.
> > >
> > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > > ---
> > > drivers/tee/optee/core.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> > > index a813a84a4f16..88e23d252bcd 100644
> > > --- a/drivers/tee/optee/core.c
> > > +++ b/drivers/tee/optee/core.c
> > > @@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev)
> > > ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng",
> > > dev_ofnode(dev), NULL);
> > > if (ret)
> > > - dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret);
> > > + dev_warn(dev, "optee-rng failed to bind: %d\n", ret);
> > > }
> > >
> > > return 0;
> >
> >
> > I think you can add:
> >
> > Fixes: 476a3d58dfeb ("tee: optee: don't fail probe because of optee-rng")
> >
> >
> > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>
> Sure I'll wait for additional reviews etc and respin
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Sorry for that :|
etienne
>
> Cheers
> /Ilias
> >
> > Thanks
> > Patrick
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tee: optee: fix a print error on rng probing
2023-01-18 22:51 ` Etienne Carriere
@ 2023-01-19 6:45 ` Jens Wiklander
0 siblings, 0 replies; 5+ messages in thread
From: Jens Wiklander @ 2023-01-19 6:45 UTC (permalink / raw)
To: Etienne Carriere
Cc: Ilias Apalodimas, Patrick DELAUNAY, u-boot, Patrice Chotard
On Wed, Jan 18, 2023 at 11:51 PM Etienne Carriere
<etienne.carriere@linaro.org> wrote:
>
> On Wed, 18 Jan 2023 at 19:54, Ilias Apalodimas
> <ilias.apalodimas@linaro.org> wrote:
> >
> > Thanks Patrick,
> >
> > On Wed, 18 Jan 2023 at 18:53, Patrick DELAUNAY
> > <patrick.delaunay@foss.st.com> wrote:
> > >
> > > Hi
> > >
> > > On 1/18/23 16:38, Ilias Apalodimas wrote:
> > > > If we fail to probe the optee-rng device, we print a wrong message
> > > > referring to the firmware tpm.
> > > >
> > > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > > > ---
> > > > drivers/tee/optee/core.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> > > > index a813a84a4f16..88e23d252bcd 100644
> > > > --- a/drivers/tee/optee/core.c
> > > > +++ b/drivers/tee/optee/core.c
> > > > @@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev)
> > > > ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng",
> > > > dev_ofnode(dev), NULL);
> > > > if (ret)
> > > > - dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret);
> > > > + dev_warn(dev, "optee-rng failed to bind: %d\n", ret);
> > > > }
> > > >
> > > > return 0;
> > >
> > >
> > > I think you can add:
> > >
> > > Fixes: 476a3d58dfeb ("tee: optee: don't fail probe because of optee-rng")
> > >
> > >
> > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> >
> > Sure I'll wait for additional reviews etc and respin
>
> Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Cheers,
Jens
> Sorry for that :|
>
> etienne
>
> >
> > Cheers
> > /Ilias
> > >
> > > Thanks
> > > Patrick
> > >
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-19 6:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-18 15:38 [PATCH] tee: optee: fix a print error on rng probing Ilias Apalodimas
2023-01-18 16:53 ` Patrick DELAUNAY
2023-01-18 18:54 ` Ilias Apalodimas
2023-01-18 22:51 ` Etienne Carriere
2023-01-19 6:45 ` Jens Wiklander
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.