* [PATCH] cmd: efidebug: Add missing \n at the end of message
@ 2022-08-09 14:31 Michal Simek
2022-08-10 5:28 ` Heinrich Schuchardt
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2022-08-09 14:31 UTC (permalink / raw)
To: u-boot, git; +Cc: Heinrich Schuchardt, Ilias Apalodimas
Currently message is not intended that prompt end up at the end of debug
line. For example like this:
DFU alt info setting: done
DFU entities configuration failed!
(partition table does not match dfu_alt_info?)
Firmware update failed: <NULL>
Cannot handle a capsule at 10000000Zynq>
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
cmd/efidebug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index df928ce71dcf..84e6ff556508 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -77,7 +77,7 @@ static int do_efi_capsule_update(struct cmd_tbl *cmdtp, int flag,
ret = EFI_CALL(RT->update_capsule(&capsule, 1, 0));
if (ret) {
- printf("Cannot handle a capsule at %p", capsule);
+ printf("Cannot handle a capsule at %p\n", capsule);
return CMD_RET_FAILURE;
}
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cmd: efidebug: Add missing \n at the end of message
2022-08-09 14:31 [PATCH] cmd: efidebug: Add missing \n at the end of message Michal Simek
@ 2022-08-10 5:28 ` Heinrich Schuchardt
2022-08-10 6:32 ` Ilias Apalodimas
0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2022-08-10 5:28 UTC (permalink / raw)
To: Michal Simek; +Cc: Ilias Apalodimas, u-boot, git
On 8/9/22 16:31, Michal Simek wrote:
> Currently message is not intended that prompt end up at the end of debug
> line. For example like this:
>
> DFU alt info setting: done
> DFU entities configuration failed!
> (partition table does not match dfu_alt_info?)
> Firmware update failed: <NULL>
> Cannot handle a capsule at 10000000Zynq>
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>
> cmd/efidebug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/efidebug.c b/cmd/efidebug.c
> index df928ce71dcf..84e6ff556508 100644
> --- a/cmd/efidebug.c
> +++ b/cmd/efidebug.c
> @@ -77,7 +77,7 @@ static int do_efi_capsule_update(struct cmd_tbl *cmdtp, int flag,
>
> ret = EFI_CALL(RT->update_capsule(&capsule, 1, 0));
> if (ret) {
> - printf("Cannot handle a capsule at %p", capsule);
> + printf("Cannot handle a capsule at %p\n", capsule);
> return CMD_RET_FAILURE;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cmd: efidebug: Add missing \n at the end of message
2022-08-10 5:28 ` Heinrich Schuchardt
@ 2022-08-10 6:32 ` Ilias Apalodimas
0 siblings, 0 replies; 3+ messages in thread
From: Ilias Apalodimas @ 2022-08-10 6:32 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Michal Simek, u-boot, git
On Wed, 10 Aug 2022 at 08:28, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 8/9/22 16:31, Michal Simek wrote:
> > Currently message is not intended that prompt end up at the end of debug
> > line. For example like this:
> >
> > DFU alt info setting: done
> > DFU entities configuration failed!
> > (partition table does not match dfu_alt_info?)
> > Firmware update failed: <NULL>
> > Cannot handle a capsule at 10000000Zynq>
> >
> > Signed-off-by: Michal Simek <michal.simek@amd.com>
>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > ---
> >
> > cmd/efidebug.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/cmd/efidebug.c b/cmd/efidebug.c
> > index df928ce71dcf..84e6ff556508 100644
> > --- a/cmd/efidebug.c
> > +++ b/cmd/efidebug.c
> > @@ -77,7 +77,7 @@ static int do_efi_capsule_update(struct cmd_tbl *cmdtp, int flag,
> >
> > ret = EFI_CALL(RT->update_capsule(&capsule, 1, 0));
> > if (ret) {
> > - printf("Cannot handle a capsule at %p", capsule);
> > + printf("Cannot handle a capsule at %p\n", capsule);
> > return CMD_RET_FAILURE;
> > }
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-10 6:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-09 14:31 [PATCH] cmd: efidebug: Add missing \n at the end of message Michal Simek
2022-08-10 5:28 ` Heinrich Schuchardt
2022-08-10 6:32 ` Ilias Apalodimas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.