All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Unune <npcomplete13@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	devicetree@vger.kernel.org, "Hauke Mehrtens" <hauke@hauke-m.de>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: dts: BCM5301X: Linksys EA9500 add port 5 and port 7
Date: Thu, 8 Oct 2020 16:20:47 -0400	[thread overview]
Message-ID: <CAChtp75Yo2crLwUCWWNgya-JmDiXvOt+JRwWojQQNazgDaphLw@mail.gmail.com> (raw)
In-Reply-To: <9c6e4da5-033e-6b30-4525-9f3a7b4ba01f@gmail.com>

Thanks Florian, I'll do that!

On Thu, Oct 8, 2020 at 10:58 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
>
> On 10/7/2020 5:32 PM, Andrew Lunn wrote:
> >> This router is currently not enabled in Openwrt
> >
> > You have to be careful here. Not everything runs OpenWRT. You cannot
> > break backwards compatibility in mainline, simple as that. You need to
> > ensure that mainline does not see a change in the CPU port.
>
> I don't think this is breaking anything, in premise all 3 CPU interfaces
> are completely interchangeable, with the notable fact that port 8
> happens to have the flow accelerator block available for re-circulation
> of packets if we wanted to support a NATP offload at some point in the
> future.
>
> Vivek, maybe you can add ports 5 and 7 in the Device Tree and mark them
> as disabled for now.
> --
> Florian

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Unune <npcomplete13@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	devicetree@vger.kernel.org, "Hauke Mehrtens" <hauke@hauke-m.de>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: dts: BCM5301X: Linksys EA9500 add port 5 and port 7
Date: Thu, 8 Oct 2020 16:20:47 -0400	[thread overview]
Message-ID: <CAChtp75Yo2crLwUCWWNgya-JmDiXvOt+JRwWojQQNazgDaphLw@mail.gmail.com> (raw)
In-Reply-To: <9c6e4da5-033e-6b30-4525-9f3a7b4ba01f@gmail.com>

Thanks Florian, I'll do that!

On Thu, Oct 8, 2020 at 10:58 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
>
> On 10/7/2020 5:32 PM, Andrew Lunn wrote:
> >> This router is currently not enabled in Openwrt
> >
> > You have to be careful here. Not everything runs OpenWRT. You cannot
> > break backwards compatibility in mainline, simple as that. You need to
> > ensure that mainline does not see a change in the CPU port.
>
> I don't think this is breaking anything, in premise all 3 CPU interfaces
> are completely interchangeable, with the notable fact that port 8
> happens to have the flow accelerator block available for re-circulation
> of packets if we wanted to support a NATP offload at some point in the
> future.
>
> Vivek, maybe you can add ports 5 and 7 in the Device Tree and mark them
> as disabled for now.
> --
> Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-10-08 20:21 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 19:01 [PATCH 0/3] ARM: dts: BCM5301X: Linksys EA9500 device tree changes Vivek Unune
2020-10-07 19:01 ` Vivek Unune
2020-10-07 19:01 ` [PATCH 1/3] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl Vivek Unune
2020-10-07 19:01   ` Vivek Unune
2020-10-07 21:01   ` Andrew Lunn
2020-10-07 21:01     ` Andrew Lunn
2020-10-07 21:46     ` Vivek Unune
2020-10-07 21:46       ` Vivek Unune
2020-10-08  0:26       ` Andrew Lunn
2020-10-08  0:26         ` Andrew Lunn
2020-10-08 12:41         ` Vivek Unune
2020-10-08 12:41           ` Vivek Unune
2020-11-04 20:29   ` [PATCH v2 0/2] " Vivek Unune
2020-11-04 20:29     ` Vivek Unune
2020-11-04 20:29     ` [PATCH v2 1/2] ARM: dts: BCM5301X: pinctrl - use correct driver and define mdio pins Vivek Unune
2020-11-04 20:29       ` Vivek Unune
2020-11-09 17:21       ` Rafał Miłecki
2020-11-09 17:21         ` Rafał Miłecki
2020-11-09 17:25         ` Florian Fainelli
2020-11-09 17:25           ` Florian Fainelli
2020-11-04 20:29     ` [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl Vivek Unune
2020-11-04 20:29       ` Vivek Unune
2020-11-04 20:37       ` Florian Fainelli
2020-11-04 20:37         ` Florian Fainelli
2020-11-04 20:58         ` Vivek Unune
2020-11-04 20:58           ` Vivek Unune
2020-11-09 13:24           ` Vivek Unune
2020-11-09 13:24             ` Vivek Unune
2020-11-09 15:54             ` Florian Fainelli
2020-11-09 15:54               ` Florian Fainelli
2020-11-09 17:24       ` Florian Fainelli
2020-11-09 17:24         ` Florian Fainelli
2020-11-10 13:17         ` Vivek Unune
2020-11-10 13:17           ` Vivek Unune
2020-10-07 19:01 ` [PATCH 2/3] ARM: dts: BCM5301X: Linksys EA9500 add port 5 and port 7 Vivek Unune
2020-10-07 19:01   ` Vivek Unune
2020-10-07 21:03   ` Andrew Lunn
2020-10-07 21:03     ` Andrew Lunn
2020-10-07 22:07     ` Vivek Unune
2020-10-07 22:07       ` Vivek Unune
2020-10-08  0:32       ` Andrew Lunn
2020-10-08  0:32         ` Andrew Lunn
2020-10-08 14:58         ` Florian Fainelli
2020-10-08 14:58           ` Florian Fainelli
2020-10-08 20:20           ` Vivek Unune [this message]
2020-10-08 20:20             ` Vivek Unune
2020-10-07 19:01 ` [PATCH 3/3] ARM: dts: BCM5301X: Linksys EA9500 add fixed partitions Vivek Unune
2020-10-07 19:01   ` Vivek Unune

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAChtp75Yo2crLwUCWWNgya-JmDiXvOt+JRwWojQQNazgDaphLw@mail.gmail.com \
    --to=npcomplete13@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=hauke@hauke-m.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.