From: Jonas Jensen <jonas.jensen@gmail.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arm@kernel.org" <arm@kernel.org>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
"djbw@fb.com" <djbw@fb.com>, "arnd@arndb.de" <arnd@arndb.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v10] dmaengine: Add MOXA ART DMA engine driver
Date: Tue, 8 Oct 2013 11:53:36 +0200 [thread overview]
Message-ID: <CACmBeS1tYwJBGscOSC=F=oup_+WfYOZMW-Xu-UmD65KuKNxfQA@mail.gmail.com> (raw)
In-Reply-To: <20131007151212.GF15365@e106331-lin.cambridge.arm.com>
On 7 October 2013 17:12, Mark Rutland <mark.rutland@arm.com> wrote:
> Sorry I didn't notice this previously, but "moxa" isn't in
> Documentation/devicetree/bindings/vendor-prefixes.txt (despite several
> bindings using it). Could you cook up a separate patch to add an entry
> for Moxa, please?
Yes, I'll submit a separate patch.
> Also, given the SoC is called "ART" it's a shame that we're calling this
> "moxa,moxart-dma" rather than "moxa,art-dma". We already have precedent
> for "moxart" in bindings though, so changing that's likely to lead to
> more problems.
Sorry about that, I think the "moxart" contraction was suggested and
has been sticky ever since.
It's at least a little appropriate because the physical chip text
reads "MOXA ART" (photo):
https://lh4.googleusercontent.com/-A-2FXDrObU8/UMcMc_K2vEI/AAAAAAAABwg/ldaLZ7ps1P4/w1331-h998-no/UC-7112-LX-picture4.jpg
Currently three drivers in linux-next use the name with accompanying
device tree bindings.
Considering the amount of patches required, can we keep the name, please?
> Sorry for yet more pendantry, but could we instead have:
>
> - interrupts: Should contain an interrupt-specifier for the sole
> interrupt generated by the device.
Fixed in v11.
Regards,
Jonas
WARNING: multiple messages have this Message-ID (diff)
From: Jonas Jensen <jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"djbw-b10kYP2dOMg@public.gmane.org"
<djbw-b10kYP2dOMg@public.gmane.org>,
"arnd-r2nGTMty4D4@public.gmane.org"
<arnd-r2nGTMty4D4@public.gmane.org>,
"linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v10] dmaengine: Add MOXA ART DMA engine driver
Date: Tue, 8 Oct 2013 11:53:36 +0200 [thread overview]
Message-ID: <CACmBeS1tYwJBGscOSC=F=oup_+WfYOZMW-Xu-UmD65KuKNxfQA@mail.gmail.com> (raw)
In-Reply-To: <20131007151212.GF15365-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
On 7 October 2013 17:12, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> Sorry I didn't notice this previously, but "moxa" isn't in
> Documentation/devicetree/bindings/vendor-prefixes.txt (despite several
> bindings using it). Could you cook up a separate patch to add an entry
> for Moxa, please?
Yes, I'll submit a separate patch.
> Also, given the SoC is called "ART" it's a shame that we're calling this
> "moxa,moxart-dma" rather than "moxa,art-dma". We already have precedent
> for "moxart" in bindings though, so changing that's likely to lead to
> more problems.
Sorry about that, I think the "moxart" contraction was suggested and
has been sticky ever since.
It's at least a little appropriate because the physical chip text
reads "MOXA ART" (photo):
https://lh4.googleusercontent.com/-A-2FXDrObU8/UMcMc_K2vEI/AAAAAAAABwg/ldaLZ7ps1P4/w1331-h998-no/UC-7112-LX-picture4.jpg
Currently three drivers in linux-next use the name with accompanying
device tree bindings.
Considering the amount of patches required, can we keep the name, please?
> Sorry for yet more pendantry, but could we instead have:
>
> - interrupts: Should contain an interrupt-specifier for the sole
> interrupt generated by the device.
Fixed in v11.
Regards,
Jonas
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jonas.jensen@gmail.com (Jonas Jensen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10] dmaengine: Add MOXA ART DMA engine driver
Date: Tue, 8 Oct 2013 11:53:36 +0200 [thread overview]
Message-ID: <CACmBeS1tYwJBGscOSC=F=oup_+WfYOZMW-Xu-UmD65KuKNxfQA@mail.gmail.com> (raw)
In-Reply-To: <20131007151212.GF15365@e106331-lin.cambridge.arm.com>
On 7 October 2013 17:12, Mark Rutland <mark.rutland@arm.com> wrote:
> Sorry I didn't notice this previously, but "moxa" isn't in
> Documentation/devicetree/bindings/vendor-prefixes.txt (despite several
> bindings using it). Could you cook up a separate patch to add an entry
> for Moxa, please?
Yes, I'll submit a separate patch.
> Also, given the SoC is called "ART" it's a shame that we're calling this
> "moxa,moxart-dma" rather than "moxa,art-dma". We already have precedent
> for "moxart" in bindings though, so changing that's likely to lead to
> more problems.
Sorry about that, I think the "moxart" contraction was suggested and
has been sticky ever since.
It's at least a little appropriate because the physical chip text
reads "MOXA ART" (photo):
https://lh4.googleusercontent.com/-A-2FXDrObU8/UMcMc_K2vEI/AAAAAAAABwg/ldaLZ7ps1P4/w1331-h998-no/UC-7112-LX-picture4.jpg
Currently three drivers in linux-next use the name with accompanying
device tree bindings.
Considering the amount of patches required, can we keep the name, please?
> Sorry for yet more pendantry, but could we instead have:
>
> - interrupts: Should contain an interrupt-specifier for the sole
> interrupt generated by the device.
Fixed in v11.
Regards,
Jonas
next prev parent reply other threads:[~2013-10-08 9:53 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 8:51 [PATCH] dmaengine: Add MOXA ART DMA engine driver Jonas Jensen
2013-07-10 8:51 ` Jonas Jensen
2013-07-10 9:30 ` Russell King - ARM Linux
2013-07-10 9:30 ` Russell King - ARM Linux
2013-07-10 9:48 ` Jonas Jensen
2013-07-10 9:48 ` Jonas Jensen
2013-07-10 12:43 ` [PATCH v2] " Jonas Jensen
2013-07-10 12:43 ` Jonas Jensen
2013-07-17 10:06 ` [PATCH v3] " Jonas Jensen
2013-07-17 10:06 ` Jonas Jensen
2013-07-29 13:44 ` [PATCH v4] " Jonas Jensen
2013-07-29 13:44 ` Jonas Jensen
2013-07-29 16:35 ` Arnd Bergmann
2013-07-29 16:35 ` Arnd Bergmann
2013-08-02 12:28 ` Jonas Jensen
2013-08-02 12:28 ` Jonas Jensen
2013-08-02 19:28 ` Arnd Bergmann
2013-08-02 19:28 ` Arnd Bergmann
2013-08-02 12:03 ` [PATCH v5] " Jonas Jensen
2013-08-02 12:03 ` Jonas Jensen
2013-08-02 13:28 ` [PATCH v6] " Jonas Jensen
2013-08-02 13:28 ` Jonas Jensen
2013-08-02 13:51 ` Russell King - ARM Linux
2013-08-02 13:51 ` Russell King - ARM Linux
2013-08-02 14:09 ` Mark Rutland
2013-08-02 14:09 ` Mark Rutland
2013-08-05 14:37 ` [PATCH v7] " Jonas Jensen
2013-08-05 14:37 ` Jonas Jensen
2013-08-05 16:57 ` Mark Rutland
2013-08-05 16:57 ` Mark Rutland
2013-08-05 20:49 ` Arnd Bergmann
2013-08-05 20:49 ` Arnd Bergmann
2013-08-06 12:38 ` [PATCH v8] " Jonas Jensen
2013-08-06 12:38 ` Jonas Jensen
2013-08-06 18:42 ` Arnd Bergmann
2013-08-06 18:42 ` Arnd Bergmann
2013-08-07 15:13 ` Mark Rutland
2013-08-07 15:13 ` Mark Rutland
2013-10-07 13:42 ` Jonas Jensen
2013-10-07 13:42 ` Jonas Jensen
2013-10-07 13:13 ` [PATCH v9] " Jonas Jensen
2013-10-07 13:13 ` Jonas Jensen
2013-10-07 14:10 ` [PATCH v10] " Jonas Jensen
2013-10-07 14:10 ` Jonas Jensen
2013-10-07 15:12 ` Mark Rutland
2013-10-07 15:12 ` Mark Rutland
2013-10-07 15:12 ` Mark Rutland
2013-10-08 9:53 ` Jonas Jensen [this message]
2013-10-08 9:53 ` Jonas Jensen
2013-10-08 9:53 ` Jonas Jensen
2013-10-08 12:55 ` Mark Rutland
2013-10-08 12:55 ` Mark Rutland
2013-10-08 12:55 ` Mark Rutland
2013-10-08 8:42 ` [PATCH v11] " Jonas Jensen
2013-10-08 8:42 ` Jonas Jensen
2013-11-13 13:59 ` Vinod Koul
2013-11-13 13:59 ` Vinod Koul
2013-11-13 17:16 ` Arnd Bergmann
2013-11-13 17:16 ` Arnd Bergmann
2013-12-06 14:27 ` [PATCH v12] " Jonas Jensen
2013-12-06 14:27 ` Jonas Jensen
2013-12-11 15:13 ` [PATCH v13] " Jonas Jensen
2013-12-11 15:13 ` Jonas Jensen
2013-12-11 21:27 ` Arnd Bergmann
2013-12-11 21:27 ` Arnd Bergmann
2013-12-12 9:16 ` Andy Shevchenko
2013-12-12 9:16 ` Andy Shevchenko
2013-12-12 12:32 ` [PATCH v14] " Jonas Jensen
2013-12-12 12:32 ` Jonas Jensen
2013-12-13 16:02 ` Lars-Peter Clausen
2013-12-13 16:02 ` Lars-Peter Clausen
2013-12-16 10:24 ` [PATCH v15] " Jonas Jensen
2013-12-16 10:24 ` Jonas Jensen
2014-01-17 8:46 ` [PATCH v16] " Jonas Jensen
2014-01-17 8:46 ` Jonas Jensen
[not found] ` <1389948365-13999-1-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-17 13:29 ` Fwd: " Jonas Jensen
2014-01-17 14:42 ` Arnd Bergmann
2014-01-17 14:42 ` Arnd Bergmann
2014-01-20 7:07 ` Vinod Koul
2014-01-20 7:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACmBeS1tYwJBGscOSC=F=oup_+WfYOZMW-Xu-UmD65KuKNxfQA@mail.gmail.com' \
--to=jonas.jensen@gmail.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=djbw@fb.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.