From: Jonas Jensen <jonas.jensen@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, davem <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Michał Mirosław" <mirqus@gmail.com>
Subject: Re: [PATCH v5 1/2] net: moxa: clear TX descriptor length bits
Date: Mon, 25 Aug 2014 16:23:35 +0200 [thread overview]
Message-ID: <CACmBeS30_NUot6=FK3xNVDxfN+CPXNfNhEBcO4OPAOQ3Q9zQzw@mail.gmail.com> (raw)
In-Reply-To: <1408554610.5604.11.camel@edumazet-glaptop2.roam.corp.google.com>
Thanks for giving feedback.
On 20 August 2014 19:10, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Wouldnt it be faster to not use readl() at all here ?
On 22 August 2014 06:39, David Miller <davem@davemloft.net> wrote:
> Like others I wonder why the existing descriptor value is being read
> at all.
It makes sense and I have verified, transfers continue to work
clearing the whole thing, see update in v6.
Regards,
Jonas
WARNING: multiple messages have this Message-ID (diff)
From: jonas.jensen@gmail.com (Jonas Jensen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/2] net: moxa: clear TX descriptor length bits
Date: Mon, 25 Aug 2014 16:23:35 +0200 [thread overview]
Message-ID: <CACmBeS30_NUot6=FK3xNVDxfN+CPXNfNhEBcO4OPAOQ3Q9zQzw@mail.gmail.com> (raw)
In-Reply-To: <1408554610.5604.11.camel@edumazet-glaptop2.roam.corp.google.com>
Thanks for giving feedback.
On 20 August 2014 19:10, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Wouldnt it be faster to not use readl() at all here ?
On 22 August 2014 06:39, David Miller <davem@davemloft.net> wrote:
> Like others I wonder why the existing descriptor value is being read
> at all.
It makes sense and I have verified, transfers continue to work
clearing the whole thing, see update in v6.
Regards,
Jonas
next prev parent reply other threads:[~2014-08-25 14:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 14:49 [PATCH v4 1/2] net: moxa: clear TX descriptor length bits Jonas Jensen
2014-08-19 14:49 ` Jonas Jensen
2014-08-19 14:49 ` [PATCH v4 2/2] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy() Jonas Jensen
2014-08-19 14:49 ` Jonas Jensen
2014-08-19 18:31 ` Eric Dumazet
2014-08-19 18:31 ` Eric Dumazet
2014-08-20 14:24 ` Jonas Jensen
2014-08-20 14:24 ` Jonas Jensen
2014-08-20 14:24 ` Jonas Jensen
2014-08-20 14:19 ` [PATCH v5 " Jonas Jensen
2014-08-20 14:19 ` Jonas Jensen
2014-08-25 14:22 ` [PATCH v6 2/4] " Jonas Jensen
2014-08-25 14:22 ` Jonas Jensen
2014-08-26 0:26 ` David Miller
2014-08-26 0:26 ` David Miller
2014-08-26 9:04 ` Arnd Bergmann
2014-08-26 9:04 ` Arnd Bergmann
2014-08-26 9:10 ` David Laight
2014-08-26 9:10 ` David Laight
2014-08-26 9:10 ` David Laight
2014-08-26 10:55 ` Eric Dumazet
2014-08-26 10:55 ` Eric Dumazet
2014-08-26 10:55 ` Eric Dumazet
2014-08-21 21:43 ` [PATCH v4 2/2] " Michał Mirosław
2014-08-21 21:43 ` Michał Mirosław
2014-08-21 21:43 ` Michał Mirosław
2014-08-25 14:23 ` Jonas Jensen
2014-08-25 14:23 ` Jonas Jensen
2014-08-25 14:23 ` Jonas Jensen
2014-08-20 14:18 ` [PATCH v5 1/2] net: moxa: clear TX descriptor length bits Jonas Jensen
2014-08-20 14:18 ` Jonas Jensen
2014-08-20 17:10 ` Eric Dumazet
2014-08-20 17:10 ` Eric Dumazet
2014-08-25 14:23 ` Jonas Jensen [this message]
2014-08-25 14:23 ` Jonas Jensen
2014-08-22 4:39 ` David Miller
2014-08-22 4:39 ` David Miller
2014-08-25 14:22 ` [PATCH v6 1/4] net: moxa: clear DESC1 on ndo_start_xmit() Jonas Jensen
2014-08-25 14:22 ` Jonas Jensen
2014-08-26 0:25 ` David Miller
2014-08-26 0:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACmBeS30_NUot6=FK3xNVDxfN+CPXNfNhEBcO4OPAOQ3Q9zQzw@mail.gmail.com' \
--to=jonas.jensen@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.