drivers/usb/usb-skeleton.c:117:3: error: label ‘out_err’ used but not define

drivers/usb/usb-skeleton.c:117:3: error: label ‘out_err’ used but not define

[Thiago Farina]

Hi,

When compiling this source file with the following command line I get
this error:

$ make drivers/usb/usb-skeleton.o
drivers/usb/usb-skeleton.c: In function ‘skel_open’:
drivers/usb/usb-skeleton.c:117:3: error: label ‘out_err’ used but not defined
make[1]: *** [drivers/usb/usb-skeleton.o] Error 1
make: *** [drivers/usb/usb-skeleton.o] Error 2

Is this intentional? If not, what would be the right fix?

Thank you,

Re: drivers/usb/usb-skeleton.c:117:3: error: label ‘out_err’ used but not define

[Greg Kroah-Hartman]

On Sat, Nov 17, 2012 at 11:34:19PM -0200, Thiago Farina wrote:
> Hi,
> 
> When compiling this source file with the following command line I get
> this error:

What kernel version are you building?

> $ make drivers/usb/usb-skeleton.o
> drivers/usb/usb-skeleton.c: In function ‘skel_open’:
> drivers/usb/usb-skeleton.c:117:3: error: label ‘out_err’ used but not defined
> make[1]: *** [drivers/usb/usb-skeleton.o] Error 1
> make: *** [drivers/usb/usb-skeleton.o] Error 2
> 
> Is this intentional?

No :)

> If not, what would be the right fix?

Properly define out_err.

I thought this all got fixed up recently, what kernel version are you
looking at?

thanks,

greg k-h

Re: drivers/usb/usb-skeleton.c:117:3: error: label ‘out_err’ used but not define

[Thiago Farina]

On Sun, Nov 18, 2012 at 1:41 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>> If not, what would be the right fix?
>
> Properly define out_err.
>
> I thought this all got fixed up recently, what kernel version are you
> looking at?
>
That might explain why I'm seeing this.

Because I'm building the kernel I checked out from
git://github.com/torvalds/linux.git, currently at commit f4a75d2e
(Linux 3.7-rc6).

Re: drivers/usb/usb-skeleton.c:117:3: error: label ‘out_err’ used but not define

[Greg Kroah-Hartman]

On Sun, Nov 18, 2012 at 12:06:31PM -0200, Thiago Farina wrote:
> On Sun, Nov 18, 2012 at 1:41 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >> If not, what would be the right fix?
> >
> > Properly define out_err.
> >
> > I thought this all got fixed up recently, what kernel version are you
> > looking at?
> >
> That might explain why I'm seeing this.
> 
> Because I'm building the kernel I checked out from
> git://github.com/torvalds/linux.git, currently at commit f4a75d2e
> (Linux 3.7-rc6).

Yes, this fixed up in linux-next (just checked it), and will be resolved
in 3.8-rc1.

sorry about that.

greg k-h