[Patch] Add Apple wireless keyboard to the quirk list

[Patch] Add Apple wireless keyboard to the quirk list

[Daniel Nicoletti]

Hi,
some time ago I sent the patch to probe the battery status of devices,
but Jeremy improved it to go to hid-input and created a quirk list,
at that time I was quite busy with other projects that I didn't had the
chance to put my model on that list, so, now that the patch got upstream
I'm having I/O errors when reading that...

I'd also suggest to include all the other keyboard models between his and
mine, but I don't know if doing this without testing is ok.

I've tested and with this, it works just fine, thanks.

Daniel.

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 132b001..33d88d1 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -301,6 +301,9 @@ static const struct hid_device_id hid_battery_quirks[] = {
        { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
                               USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI),
          HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
+       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
+                              USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
+         HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
        {}
 };

Re: [Patch] Add Apple wireless keyboard to the quirk list

[Jiri Kosina]

On Mon, 28 May 2012, Daniel Nicoletti wrote:

> some time ago I sent the patch to probe the battery status of devices,
> but Jeremy improved it to go to hid-input and created a quirk list,
> at that time I was quite busy with other projects that I didn't had the
> chance to put my model on that list, so, now that the patch got upstream
> I'm having I/O errors when reading that...
> 
> I'd also suggest to include all the other keyboard models between his and
> mine, but I don't know if doing this without testing is ok.

Daniel,

I'd prefer adding those only after verification that the battery status is 
reported on those devices in compatible way as well.

> I've tested and with this, it works just fine, thanks.

Thanks for the patch. It's however missing your Signed-off-by: line, could 
you please resend the patch including it, so that I could apply it?

Thanks.

> 
> Daniel.
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 132b001..33d88d1 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -301,6 +301,9 @@ static const struct hid_device_id hid_battery_quirks[] = {
>         { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
>                                USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI),
>           HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
> +       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
> +                              USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
> +         HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
>         {}
>  };

-- 
Jiri Kosina
SUSE Labs

Re: [Patch] Add Apple wireless keyboard to the quirk list

[Daniel Nicoletti]

2012/6/5 Jiri Kosina <jkosina@suse.cz>
> > I've tested and with this, it works just fine, thanks.
>
> Thanks for the patch. It's however missing your Signed-off-by: line, could
> you please resend the patch including it, so that I could apply it?
Ok sorry for the delay (too much stuff),
I'm used to have commit access on the stuff I contribute so
I didn't know this git format-patch thing, which someone pointed out to me.
Should I use git send-email too?

Thanks.

>From cc0225ce44f037f7ce9ecb876e65b5e8079d5665 Mon Sep 17 00:00:00 2001
From: Daniel Nicoletti <dantti12@gmail.com>
Date: Wed, 4 Jul 2012 10:20:31 -0300
Subject: [PATCH 1/1] hid-input: Add Apple's Wireless keyboard
 (USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI), to the quirk
 list since it report wrong feature type and wrong
 percentage range.


Signed-off-by: Daniel Nicoletti <dantti12@gmail.com>
---
 drivers/hid/hid-input.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 132b001..33d88d1 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -301,6 +301,9 @@ static const struct hid_device_id hid_battery_quirks[] = {
        { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
                               USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI),
          HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
+       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
+                              USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
+         HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
        {}
 };

-- 
1.7.9.5

Re: [Patch] Add Apple wireless keyboard to the quirk list

[Jiri Kosina]

On Wed, 4 Jul 2012, Daniel Nicoletti wrote:

> Ok sorry for the delay (too much stuff),
> I'm used to have commit access on the stuff I contribute so
> I didn't know this git format-patch thing, which someone pointed out to me.
> Should I use git send-email too?
> 
> Thanks.
> 
> >From cc0225ce44f037f7ce9ecb876e65b5e8079d5665 Mon Sep 17 00:00:00 2001
> From: Daniel Nicoletti <dantti12@gmail.com>
> Date: Wed, 4 Jul 2012 10:20:31 -0300
> Subject: [PATCH 1/1] hid-input: Add Apple's Wireless keyboard
>  (USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI), to the quirk
>  list since it report wrong feature type and wrong
>  percentage range.
> 
> 
> Signed-off-by: Daniel Nicoletti <dantti12@gmail.com>
> ---
>  drivers/hid/hid-input.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 132b001..33d88d1 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -301,6 +301,9 @@ static const struct hid_device_id hid_battery_quirks[] = {
>         { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
>                                USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI),
>           HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
> +       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
> +                              USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
> +         HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },

Daniel,

the patch has been whitespace damaged. I have fixed it now and applied, 
but please fix your workflow (likely e-mail client) for further 
submissions in this respect.

-- 
Jiri Kosina
SUSE Labs

Re: [Patch] Add Apple wireless keyboard to the quirk list

[Daniel Nicoletti]

2012/7/4 Jiri Kosina <jkosina@suse.cz>:
> Daniel,
>
> the patch has been whitespace damaged. I have fixed it now and applied,
> but please fix your workflow (likely e-mail client) for further
> submissions in this respect.
Ok I've just used gmail web interface with plain text,
so I guess it's better to use git send email next time right?

Best,
Daniel.