[PATCH] leds: leds-lp5562 allow firmware files up to the maximum length

[PATCH] leds: leds-lp5562 allow firmware files up to the maximum length

[Nick Stoughton]

Firmware files are in ASCII, using 2 hex characters per byte. The
maximum length of a firmware string is therefore

16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64

Signed-off-by: Nick Stoughton <nstoughton@logitech.com>
---
 drivers/leds/leds-lp5562.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c
index 37632fc63741..e00117e3b50d 100644
--- a/drivers/leds/leds-lp5562.c
+++ b/drivers/leds/leds-lp5562.c
@@ -260,7 +260,11 @@ static void lp5562_firmware_loaded(struct
lp55xx_chip *chip)
 {
        const struct firmware *fw = chip->fw;

-       if (fw->size > LP5562_PROGRAM_LENGTH) {
+        /*
+         * the firmware is encoded in ascii hex character, with 2 chars
+         * per byte
+         */
+       if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) {
                dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
                        fw->size);
                return;
-- 
Nick Stoughton

Re: [PATCH] leds: leds-lp5562 allow firmware files up to the maximum length

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]


On Wed 2019-07-10 07:30:31, Nick Stoughton wrote:
> Firmware files are in ASCII, using 2 hex characters per byte. The
> maximum length of a firmware string is therefore
> 
> 16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64
> 
> Signed-off-by: Nick Stoughton <nstoughton@logitech.com>

Acked-by: Pavel Machek <pavel@ucw.cz>
								Pavel
> ---
>  drivers/leds/leds-lp5562.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c
> index 37632fc63741..e00117e3b50d 100644
> --- a/drivers/leds/leds-lp5562.c
> +++ b/drivers/leds/leds-lp5562.c
> @@ -260,7 +260,11 @@ static void lp5562_firmware_loaded(struct
> lp55xx_chip *chip)
>  {
>         const struct firmware *fw = chip->fw;
> 
> -       if (fw->size > LP5562_PROGRAM_LENGTH) {
> +        /*
> +         * the firmware is encoded in ascii hex character, with 2 chars
> +         * per byte
> +         */
> +       if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) {
>                 dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
>                         fw->size);
>                 return;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH] leds: leds-lp5562 allow firmware files up to the maximum length

[Jacek Anaszewski]

Hi Nick,

Thank you for the patch. Unfortunately it doesn't apply:

$ git am \[PATCH\]\ leds\:\ leds-lp5562\ allow\ firmware\ files\ up\ to\
the\ maximum\ length.eml
Applying: leds: leds-lp5562 allow firmware files up to the maximum length
error: corrupt patch at line 10
...

I don't know where is the problem exactly, but you seem to have copied
the patch created with "git format-patch" and copy-pasted it to the
message composer window. Please send the patch using
"git send-email".

Best regards,
Jacek Anaszewski


On 7/10/19 4:30 PM, Nick Stoughton wrote:
> Firmware files are in ASCII, using 2 hex characters per byte. The
> maximum length of a firmware string is therefore
> 
> 16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64
> 
> Signed-off-by: Nick Stoughton <nstoughton@logitech.com>
> ---
>  drivers/leds/leds-lp5562.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c
> index 37632fc63741..e00117e3b50d 100644
> --- a/drivers/leds/leds-lp5562.c
> +++ b/drivers/leds/leds-lp5562.c
> @@ -260,7 +260,11 @@ static void lp5562_firmware_loaded(struct
> lp55xx_chip *chip)
>  {
>         const struct firmware *fw = chip->fw;
> 
> -       if (fw->size > LP5562_PROGRAM_LENGTH) {
> +        /*
> +         * the firmware is encoded in ascii hex character, with 2 chars
> +         * per byte
> +         */
> +       if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) {
>                 dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
>                         fw->size);
>                 return;
>