trace libraries install path

trace libraries install path

[Tzvetomir Stoyanov]

Hi Steven,
While porting those two patches from linux to trace-cmd tree:
    [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file
    [PATCH 2/9] tools/lib/traceevent: Added support for pkg-config
I noticed a mismatch between linux and trace-cmd in logic installing
library header files, in main Makefile:
  linux code installs library headers in  "$(prefix)/include/traceevent"
  trace-cmd code nstalls library headers in "$(prefix)/include/trace-cmd"
This is the destination install path of traceevent library header files:
   event-parse.h, event-utils.h, trace-seq.h, kbuffer.h

We should make it consistent, what install folder to choose for those files ?
-- 
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center

Re: trace libraries install path

[Steven Rostedt]

On Mon, 3 Dec 2018 14:22:01 +0000
Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:

> Hi Steven,
> While porting those two patches from linux to trace-cmd tree:
>     [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file
>     [PATCH 2/9] tools/lib/traceevent: Added support for pkg-config
> I noticed a mismatch between linux and trace-cmd in logic installing
> library header files, in main Makefile:
>   linux code installs library headers in  "$(prefix)/include/traceevent"
>   trace-cmd code nstalls library headers in "$(prefix)/include/trace-cmd"
> This is the destination install path of traceevent library header files:
>    event-parse.h, event-utils.h, trace-seq.h, kbuffer.h
> 
> We should make it consistent, what install folder to choose for those files ?

Actually they should just follow the paths in trace-cmd.git. That is,
those in include/traceevent/* go into $(prefix)/include/traceevent and
those in include/trace-cmd/* go into $(prefix)/include/trace-cmd

Make sense?

-- Steve

Re: trace libraries install path

[Tzvetomir Stoyanov]

On Mon, Dec 3, 2018 at 5:22 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Mon, 3 Dec 2018 14:22:01 +0000
> Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:
>
> > Hi Steven,
> > While porting those two patches from linux to trace-cmd tree:
> >     [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file
> >     [PATCH 2/9] tools/lib/traceevent: Added support for pkg-config
> > I noticed a mismatch between linux and trace-cmd in logic installing
> > library header files, in main Makefile:
> >   linux code installs library headers in  "$(prefix)/include/traceevent"
> >   trace-cmd code nstalls library headers in "$(prefix)/include/trace-cmd"
> > This is the destination install path of traceevent library header files:
> >    event-parse.h, event-utils.h, trace-seq.h, kbuffer.h
> >
> > We should make it consistent, what install folder to choose for those files ?
>
> Actually they should just follow the paths in trace-cmd.git. That is,
> those in include/traceevent/* go into $(prefix)/include/traceevent and
> those in include/trace-cmd/* go into $(prefix)/include/trace-cmd
>
> Make sense?
>
> -- Steve

Yes, sounds logical. I'll do it this way.

-- 
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center