From: Arnaud Lacombe <lacombar@gmail.com>
To: Andrej Gelenberg <andrej.gelenberg@udo.edu>
Cc: Nir Tzachar <nir.tzachar@gmail.com>,
linux-kbuild@vger.kernel.org, mmarek@suse.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kconfig/nconf: prevent segfault on empty menu
Date: Tue, 12 Jul 2011 16:49:31 -0400 [thread overview]
Message-ID: <CACqU3MV0MCxa8Kb9wzk-_obe=KssHGYbvc1Oa4uxoUeHiksfag@mail.gmail.com> (raw)
In-Reply-To: <4E1CABBD.60901@udo.edu>
Hi,
On Tue, Jul 12, 2011 at 4:17 PM, Andrej Gelenberg
<andrej.gelenberg@udo.edu> wrote:
> Hi,
>
> here is one more patch, which make empty title instead of "(null)".
>
No. You are breaking front-ends which either properly use the API and
make use menu_has_prompt() before getting the prompt with
menu_get_prompt(), or test for NULL pointer and act accordingly. Btw,
by doing this, you potentially breaking nconf too, and there is rarely
any need to modify the back-end to fix display issue in the front-end.
- Arnaud
ps: could you please send inlined patched, that a real pain to review. thanks.
> Regards,
> Andrej Gelenberg
>
> On 07/11/2011 11:50 AM, Nir Tzachar wrote:
>> On Mon, Jul 11, 2011 at 11:51 AM, Andrej Gelenberg
>> <andrej.gelenberg@udo.edu> wrote:
>>> Hello,
>>>
>>> it show already "There is no help available for this option." message on
>>> F2. Only caption could be better as just "(null)". Besides ignore the
>>> key is much better as segfault.
>>
>> I agree. Then just add a proper caption and thats it.
>>
>> Cheers.
>>
>>> Regards
>>> Andrej Gelenberg
>
next prev parent reply other threads:[~2011-07-12 20:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 2:04 [PATCH] nconfig: prevent segfault on empty menu Andrej Gelenberg
2011-07-10 2:04 ` Andrej Gelenberg
2011-07-10 6:02 ` Arnaud Lacombe
2011-07-10 7:27 ` [PATCH 1/2] kconfig/nconf: use the generic menu_get_ext_help() Arnaud Lacombe
2011-07-10 7:27 ` [PATCH 2/2] kconfig/nconf: prevent segfault on empty menu Arnaud Lacombe
2011-07-10 10:32 ` Nir Tzachar
2011-07-10 16:18 ` Arnaud Lacombe
2011-07-11 6:19 ` Nir Tzachar
2011-07-11 8:51 ` Andrej Gelenberg
2011-07-11 9:50 ` Nir Tzachar
2011-07-12 20:17 ` Andrej Gelenberg
2011-07-12 20:17 ` Andrej Gelenberg
2011-07-12 20:49 ` Arnaud Lacombe [this message]
2011-07-13 11:49 ` Michal Marek
2011-07-18 18:11 ` [PATCH 1/2] kconfig/nconf: use the generic menu_get_ext_help() Arnaud Lacombe
2011-07-18 19:02 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACqU3MV0MCxa8Kb9wzk-_obe=KssHGYbvc1Oa4uxoUeHiksfag@mail.gmail.com' \
--to=lacombar@gmail.com \
--cc=andrej.gelenberg@udo.edu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=nir.tzachar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.