All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrej Gelenberg <andrej.gelenberg@udo.edu>
To: Nir Tzachar <nir.tzachar@gmail.com>
Cc: linux-kbuild@vger.kernel.org, mmarek@suse.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kconfig/nconf: prevent segfault on empty menu
Date: Tue, 12 Jul 2011 22:17:01 +0200	[thread overview]
Message-ID: <4E1CABBD.60901@udo.edu> (raw)
In-Reply-To: <CAMT+=WZV4TGfXY0=BjYtNVRDuWw6r-facK=q2S6HVOUTB3KWEg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi,

here is one more patch, which make empty title instead of "(null)".

Regards,
Andrej Gelenberg

On 07/11/2011 11:50 AM, Nir Tzachar wrote:
> On Mon, Jul 11, 2011 at 11:51 AM, Andrej Gelenberg
> <andrej.gelenberg@udo.edu> wrote:
>> Hello,
>>
>> it show already "There is no help available for this option." message on
>> F2. Only caption could be better as just "(null)". Besides ignore the
>> key is much better as segfault.
> 
> I agree. Then just add a proper caption and thats it.
> 
> Cheers.
> 
>> Regards
>> Andrej Gelenberg

[-- Attachment #2: 0001-nconfig-menu_get_prompt-return-if-no-promt.patch --]
[-- Type: text/plain, Size: 822 bytes --]

>From e5fa0e9a705c2e2092ba9c2879e85f8bef12f7f8 Mon Sep 17 00:00:00 2001
From: Andrej Gelenberg <andrej.gelenberg@udo.edu>
Date: Tue, 12 Jul 2011 18:36:50 +0200
Subject: [PATCH] nconfig: menu_get_prompt() return "", if no promt

Help message box has "" as titled instead of "(null)" on empty menu in
nconf.

Signed-off-by: Andrej Gelenberg <andrej.gelenberg@udo.edu>
---
 scripts/kconfig/menu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 6a09cc4..0783d8e 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -476,7 +476,7 @@ const char *menu_get_prompt(struct menu *menu)
 		else if (menu->sym)
 			return menu->sym->name;
 	}
-	return NULL;
+	return "";
 }
 
 struct menu *menu_get_root_menu(struct menu *menu)
-- 
1.7.6


WARNING: multiple messages have this Message-ID (diff)
From: Andrej Gelenberg <andrej.gelenberg@udo.edu>
To: Nir Tzachar <nir.tzachar@gmail.com>
Cc: linux-kbuild@vger.kernel.org, mmarek@suse.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kconfig/nconf: prevent segfault on empty menu
Date: Tue, 12 Jul 2011 22:17:01 +0200	[thread overview]
Message-ID: <4E1CABBD.60901@udo.edu> (raw)
In-Reply-To: <CAMT+=WZV4TGfXY0=BjYtNVRDuWw6r-facK=q2S6HVOUTB3KWEg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi,

here is one more patch, which make empty title instead of "(null)".

Regards,
Andrej Gelenberg

On 07/11/2011 11:50 AM, Nir Tzachar wrote:
> On Mon, Jul 11, 2011 at 11:51 AM, Andrej Gelenberg
> <andrej.gelenberg@udo.edu> wrote:
>> Hello,
>>
>> it show already "There is no help available for this option." message on
>> F2. Only caption could be better as just "(null)". Besides ignore the
>> key is much better as segfault.
> 
> I agree. Then just add a proper caption and thats it.
> 
> Cheers.
> 
>> Regards
>> Andrej Gelenberg

[-- Attachment #2: 0001-nconfig-menu_get_prompt-return-if-no-promt.patch --]
[-- Type: text/plain, Size: 821 bytes --]

From e5fa0e9a705c2e2092ba9c2879e85f8bef12f7f8 Mon Sep 17 00:00:00 2001
From: Andrej Gelenberg <andrej.gelenberg@udo.edu>
Date: Tue, 12 Jul 2011 18:36:50 +0200
Subject: [PATCH] nconfig: menu_get_prompt() return "", if no promt

Help message box has "" as titled instead of "(null)" on empty menu in
nconf.

Signed-off-by: Andrej Gelenberg <andrej.gelenberg@udo.edu>
---
 scripts/kconfig/menu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 6a09cc4..0783d8e 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -476,7 +476,7 @@ const char *menu_get_prompt(struct menu *menu)
 		else if (menu->sym)
 			return menu->sym->name;
 	}
-	return NULL;
+	return "";
 }
 
 struct menu *menu_get_root_menu(struct menu *menu)
-- 
1.7.6


  reply	other threads:[~2011-07-12 20:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-10  2:04 [PATCH] nconfig: prevent segfault on empty menu Andrej Gelenberg
2011-07-10  2:04 ` Andrej Gelenberg
2011-07-10  6:02 ` Arnaud Lacombe
2011-07-10  7:27   ` [PATCH 1/2] kconfig/nconf: use the generic menu_get_ext_help() Arnaud Lacombe
2011-07-10  7:27     ` [PATCH 2/2] kconfig/nconf: prevent segfault on empty menu Arnaud Lacombe
2011-07-10 10:32       ` Nir Tzachar
2011-07-10 16:18         ` Arnaud Lacombe
2011-07-11  6:19           ` Nir Tzachar
2011-07-11  8:51         ` Andrej Gelenberg
2011-07-11  9:50           ` Nir Tzachar
2011-07-12 20:17             ` Andrej Gelenberg [this message]
2011-07-12 20:17               ` Andrej Gelenberg
2011-07-12 20:49               ` Arnaud Lacombe
2011-07-13 11:49       ` Michal Marek
2011-07-18 18:11     ` [PATCH 1/2] kconfig/nconf: use the generic menu_get_ext_help() Arnaud Lacombe
2011-07-18 19:02       ` Arnaud Lacombe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1CABBD.60901@udo.edu \
    --to=andrej.gelenberg@udo.edu \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=nir.tzachar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.