All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 03/12 v3] xen/arm: vpl011: Add pl011 uart emulation in Xen
Date: Thu, 1 Jun 2017 19:04:38 +0530	[thread overview]
Message-ID: <CACtJ1JRQn9oLKpo8PAdxxuM-gJNJL6aZaU-OfkMkeUVxrny4-g@mail.gmail.com> (raw)
In-Reply-To: <CACtJ1JS_zeCrort324k0TxGVQ6dyr3ceW94rycPeNazxSB18Vw@mail.gmail.com>

Hi Julien,

On 26 May 2017 at 19:12, Bhupinder Thakur <bhupinder.thakur@linaro.org> wrote:
>>> +
>>> +    switch ( vpl011_reg )
>>> +    {
>>> +    case DR:
>>
>>
>> As mentioned above, you could do:
>>
>> {
>>      uint8_t ch;
>>      ....
>> }
>>
>>> +        vpl011_read_data(v->domain, &ch);
>>> +        *r = ch;
>>
>>
>> Please use vreg_reg32_extract(...).
>>
> ok.
>
>>> +        break;
>>
>>
>> I admit I would prefer the "return 1;" here rather than "break;". This makes
>> easier to follow the emulation for a given register.
>>
>> I would even be in favor of duplicating the "if ( !vpl011... )" in each case
>> for the same reason.

Do you mean that I should repeat the vpl011_reg32_check_access() and
return for each switch case?

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-06-01 13:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 14:24 [PATCH 01/12 v3] xen/arm: vpl011: Move vgic register access functions to vreg.h Bhupinder Thakur
2017-05-10 14:24 ` [PATCH 02/12 v3] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h Bhupinder Thakur
2017-05-22 12:21   ` Julien Grall
2017-05-23  6:14     ` Bhupinder Thakur
2017-05-10 14:24 ` [PATCH 03/12 v3] xen/arm: vpl011: Add pl011 uart emulation in Xen Bhupinder Thakur
2017-05-16 22:42   ` Stefano Stabellini
2017-05-22 14:24   ` Julien Grall
2017-05-26 13:42     ` Bhupinder Thakur
2017-05-29  7:13       ` Bhupinder Thakur
2017-05-29 18:26         ` Julien Grall
2017-06-01 13:34       ` Bhupinder Thakur [this message]
2017-06-01 13:56         ` Julien Grall
2017-06-01 10:33     ` Bhupinder Thakur
2017-06-01 12:42       ` Julien Grall
2017-05-22 12:18 ` [PATCH 01/12 v3] xen/arm: vpl011: Move vgic register access functions to vreg.h Julien Grall
2017-05-22 12:56   ` Bhupinder Thakur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACtJ1JRQn9oLKpo8PAdxxuM-gJNJL6aZaU-OfkMkeUVxrny4-g@mail.gmail.com \
    --to=bhupinder.thakur@linaro.org \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.