All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 03/12 v3] xen/arm: vpl011: Add pl011 uart emulation in Xen
Date: Thu, 1 Jun 2017 16:03:40 +0530	[thread overview]
Message-ID: <CACtJ1JRazKdv=jf4+HPG1DVC1dQ68zdLbyrbXNr_BMSJFNJu2Q@mail.gmail.com> (raw)
In-Reply-To: <ee9c0442-9d86-ac98-a30a-69c8ef1ed5de@arm.com>

Hi Julien,

On 22 May 2017 at 19:54, Julien Grall <julien.grall@arm.com> wrote:
>> +static const struct mmio_handler_ops vpl011_mmio_handler = {
>> +    .read = vpl011_mmio_read,
>> +    .write = vpl011_mmio_write,
>> +};
>> +
>> +int vpl011_map_guest_page(struct domain *d, xen_pfn_t gfn)
>
>
> This function should either have the prototype defined in an header if used
> outside or static.
>
> Also, I have asked to use gfn_t and not xen_pfn_t. The former is a typesafe
> avoiding mix between MFN and GFN.

The gfn is passed on from the domctl API to this function. Is the
gfn_t definition exposed to domctl interface? Currently, gfn_t is
defined in xen/include/xen/mm.h. So I would have to include this
header file in xen/include/public/domctl.h where I have defined the
vuart_ops structure containing gfn. Is it ok to include a xen header
file in the public header file?

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-06-01 10:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 14:24 [PATCH 01/12 v3] xen/arm: vpl011: Move vgic register access functions to vreg.h Bhupinder Thakur
2017-05-10 14:24 ` [PATCH 02/12 v3] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h Bhupinder Thakur
2017-05-22 12:21   ` Julien Grall
2017-05-23  6:14     ` Bhupinder Thakur
2017-05-10 14:24 ` [PATCH 03/12 v3] xen/arm: vpl011: Add pl011 uart emulation in Xen Bhupinder Thakur
2017-05-16 22:42   ` Stefano Stabellini
2017-05-22 14:24   ` Julien Grall
2017-05-26 13:42     ` Bhupinder Thakur
2017-05-29  7:13       ` Bhupinder Thakur
2017-05-29 18:26         ` Julien Grall
2017-06-01 13:34       ` Bhupinder Thakur
2017-06-01 13:56         ` Julien Grall
2017-06-01 10:33     ` Bhupinder Thakur [this message]
2017-06-01 12:42       ` Julien Grall
2017-05-22 12:18 ` [PATCH 01/12 v3] xen/arm: vpl011: Move vgic register access functions to vreg.h Julien Grall
2017-05-22 12:56   ` Bhupinder Thakur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACtJ1JRazKdv=jf4+HPG1DVC1dQ68zdLbyrbXNr_BMSJFNJu2Q@mail.gmail.com' \
    --to=bhupinder.thakur@linaro.org \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.