* [PATCH v1] net: macvlan: Use built-in RCU list checking
@ 2022-11-08 12:52 Chuang Wang
2022-11-10 10:57 ` Paolo Abeni
0 siblings, 1 reply; 4+ messages in thread
From: Chuang Wang @ 2022-11-08 12:52 UTC (permalink / raw)
Cc: Chuang Wang, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel
hlist_for_each_entry_rcu() has built-in RCU and lock checking.
Pass cond argument to hlist_for_each_entry_rcu() to silence false
lockdep warning when CONFIG_PROVE_RCU_LIST is enabled.
Execute as follow:
ip link add link eth0 type macvlan mode source macaddr add <MAC-ADDR>
The rtnl_lock is held when macvlan_hash_lookup_source() or
macvlan_fill_info_macaddr() are called in the non-RCU read side section.
So, pass lockdep_rtnl_is_held() to silence false lockdep warning.
Signed-off-by: Chuang Wang <nashuiliang@gmail.com>
---
v0 -> v1:
- fix typo
drivers/net/macvlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index c58fea63be7d..deb7929004a7 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -141,7 +141,7 @@ static struct macvlan_source_entry *macvlan_hash_lookup_source(
u32 idx = macvlan_eth_hash(addr);
struct hlist_head *h = &vlan->port->vlan_source_hash[idx];
- hlist_for_each_entry_rcu(entry, h, hlist) {
+ hlist_for_each_entry_rcu(entry, h, hlist, lockdep_rtnl_is_held()) {
if (ether_addr_equal_64bits(entry->addr, addr) &&
entry->vlan == vlan)
return entry;
@@ -1645,7 +1645,7 @@ static int macvlan_fill_info_macaddr(struct sk_buff *skb,
struct hlist_head *h = &vlan->port->vlan_source_hash[i];
struct macvlan_source_entry *entry;
- hlist_for_each_entry_rcu(entry, h, hlist) {
+ hlist_for_each_entry_rcu(entry, h, hlist, lockdep_rtnl_is_held()) {
if (entry->vlan != vlan)
continue;
if (nla_put(skb, IFLA_MACVLAN_MACADDR, ETH_ALEN, entry->addr))
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] net: macvlan: Use built-in RCU list checking
2022-11-08 12:52 [PATCH v1] net: macvlan: Use built-in RCU list checking Chuang Wang
@ 2022-11-10 10:57 ` Paolo Abeni
2022-11-10 11:27 ` Chuang W
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Abeni @ 2022-11-10 10:57 UTC (permalink / raw)
To: Chuang Wang
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, netdev, linux-kernel
Hello,
On Tue, 2022-11-08 at 20:52 +0800, Chuang Wang wrote:
> hlist_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to hlist_for_each_entry_rcu() to silence false
> lockdep warning when CONFIG_PROVE_RCU_LIST is enabled.
>
> Execute as follow:
>
> ip link add link eth0 type macvlan mode source macaddr add <MAC-ADDR>
>
> The rtnl_lock is held when macvlan_hash_lookup_source() or
> macvlan_fill_info_macaddr() are called in the non-RCU read side section.
> So, pass lockdep_rtnl_is_held() to silence false lockdep warning.
>
> Signed-off-by: Chuang Wang <nashuiliang@gmail.com>
The patch LGTM, but IMHO this should target the -net tree, as it's
addressing an issue bothering people.
Can you please re-submit, specifying the target tree into the subj and
including a suitable Fixes tag?
Thanks!
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] net: macvlan: Use built-in RCU list checking
2022-11-10 10:57 ` Paolo Abeni
@ 2022-11-10 11:27 ` Chuang W
2022-11-10 16:46 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Chuang W @ 2022-11-10 11:27 UTC (permalink / raw)
To: Paolo Abeni
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, netdev, linux-kernel
Hi,
On Thu, Nov 10, 2022 at 6:57 PM Paolo Abeni <pabeni@redhat.com> wrote:
>
> Hello,
>
> On Tue, 2022-11-08 at 20:52 +0800, Chuang Wang wrote:
> > hlist_for_each_entry_rcu() has built-in RCU and lock checking.
> >
> > Pass cond argument to hlist_for_each_entry_rcu() to silence false
> > lockdep warning when CONFIG_PROVE_RCU_LIST is enabled.
> >
> > Execute as follow:
> >
> > ip link add link eth0 type macvlan mode source macaddr add <MAC-ADDR>
> >
> > The rtnl_lock is held when macvlan_hash_lookup_source() or
> > macvlan_fill_info_macaddr() are called in the non-RCU read side section.
> > So, pass lockdep_rtnl_is_held() to silence false lockdep warning.
> >
> > Signed-off-by: Chuang Wang <nashuiliang@gmail.com>
>
> The patch LGTM, but IMHO this should target the -net tree, as it's
> addressing an issue bothering people.
Sorry, can I sincerely ask if the -net tree is
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git or
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git ?
>
> Can you please re-submit, specifying the target tree into the subj and
> including a suitable Fixes tag?
ok, I will add a suitable Fixed tag and resubmit. Thanks.
>
> Thanks!
>
> Paolo
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] net: macvlan: Use built-in RCU list checking
2022-11-10 11:27 ` Chuang W
@ 2022-11-10 16:46 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-11-10 16:46 UTC (permalink / raw)
To: Chuang W; +Cc: Paolo Abeni, David S. Miller, Eric Dumazet, netdev, linux-kernel
On Thu, 10 Nov 2022 19:27:52 +0800 Chuang W wrote:
> > The patch LGTM, but IMHO this should target the -net tree, as it's
> > addressing an issue bothering people.
>
> Sorry, can I sincerely ask if the -net tree is
> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git or
This one, but you should also put the name in the subject, like this:
[PATCH net v2] net: macvlan: Use built-in RCU list checking
> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git ?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-10 16:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-08 12:52 [PATCH v1] net: macvlan: Use built-in RCU list checking Chuang Wang
2022-11-10 10:57 ` Paolo Abeni
2022-11-10 11:27 ` Chuang W
2022-11-10 16:46 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.