* [PATCH libdrm] android: make symbols hidden by default
@ 2018-09-20 6:05 Lucas De Marchi
2018-09-20 12:24 ` Eric Engestrom
0 siblings, 1 reply; 3+ messages in thread
From: Lucas De Marchi @ 2018-09-20 6:05 UTC (permalink / raw)
To: dri-devel; +Cc: Eric Engestrom
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
Android.common.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/Android.common.mk b/Android.common.mk
index e3de1069..d0e5d559 100644
--- a/Android.common.mk
+++ b/Android.common.mk
@@ -2,6 +2,7 @@
LOCAL_CFLAGS += \
-DMAJOR_IN_SYSMACROS=1 \
-DHAVE_VISIBILITY=1 \
+ -fvisibility=hidden \
-DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
LOCAL_CFLAGS += \
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH libdrm] android: make symbols hidden by default
2018-09-20 6:05 [PATCH libdrm] android: make symbols hidden by default Lucas De Marchi
@ 2018-09-20 12:24 ` Eric Engestrom
2018-10-04 13:44 ` Emil Velikov
0 siblings, 1 reply; 3+ messages in thread
From: Eric Engestrom @ 2018-09-20 12:24 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: dri-devel
On Wednesday, 2018-09-19 23:05:48 -0700, Lucas De Marchi wrote:
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
But it'd be good to have a confirmation from Rob that it actually works:
Cc: Rob Herring <robh@kernel.org>
> ---
> Android.common.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Android.common.mk b/Android.common.mk
> index e3de1069..d0e5d559 100644
> --- a/Android.common.mk
> +++ b/Android.common.mk
> @@ -2,6 +2,7 @@
> LOCAL_CFLAGS += \
> -DMAJOR_IN_SYSMACROS=1 \
> -DHAVE_VISIBILITY=1 \
> + -fvisibility=hidden \
> -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>
> LOCAL_CFLAGS += \
> --
> 2.17.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH libdrm] android: make symbols hidden by default
2018-09-20 12:24 ` Eric Engestrom
@ 2018-10-04 13:44 ` Emil Velikov
0 siblings, 0 replies; 3+ messages in thread
From: Emil Velikov @ 2018-10-04 13:44 UTC (permalink / raw)
To: Eric Engestrom; +Cc: Lucas De Marchi, ML dri-devel
On Thu, 20 Sep 2018 at 13:25, Eric Engestrom <eric.engestrom@intel.com> wrote:
>
> On Wednesday, 2018-09-19 23:05:48 -0700, Lucas De Marchi wrote:
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
>
> But it'd be good to have a confirmation from Rob that it actually works:
> Cc: Rob Herring <robh@kernel.org>
>
Yes it does. Older Androids can use GCC which is new enough. While
latest ones exclusively use clang which also has the flag.
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Will push that in a moment.
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-04 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-20 6:05 [PATCH libdrm] android: make symbols hidden by default Lucas De Marchi
2018-09-20 12:24 ` Eric Engestrom
2018-10-04 13:44 ` Emil Velikov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.