From: Emil Velikov <emil.l.velikov@gmail.com>
To: Sidong Yang <realwakka@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
David Airlie <airlied@linux.ie>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()
Date: Sun, 31 May 2020 18:18:12 +0100 [thread overview]
Message-ID: <CACvgo50SzjUe6usELF33qXW3BWZmH5U4ynPTBorZLDrG-Nx2Pw@mail.gmail.com> (raw)
In-Reply-To: <20200531131237.24781-1-realwakka@gmail.com>
On Sun, 31 May 2020 at 14:12, Sidong Yang <realwakka@gmail.com> wrote:
>
> Optimize looping pixels in compute_crc() and blend(). Calculate
> src_offset in start of looping horizontally and increase it.
> It's better than calculating in every pixels.
>
When you say "optimize" have you observed any actual benefits of the
patch - be that smaller binary, faster execution time, etc?
If there are - mentioned them in the commit message. Otherwise, it
doesn't optimise anything.
A while back, I've suggested something similar [1] mostly for cosmetic
purposes - doubt there's much benefits beyond that.
HTH
-Emil
[1] https://patchwork.freedesktop.org/patch/365177/#comment_674314
WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Sidong Yang <realwakka@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
David Airlie <airlied@linux.ie>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()
Date: Sun, 31 May 2020 18:18:12 +0100 [thread overview]
Message-ID: <CACvgo50SzjUe6usELF33qXW3BWZmH5U4ynPTBorZLDrG-Nx2Pw@mail.gmail.com> (raw)
In-Reply-To: <20200531131237.24781-1-realwakka@gmail.com>
On Sun, 31 May 2020 at 14:12, Sidong Yang <realwakka@gmail.com> wrote:
>
> Optimize looping pixels in compute_crc() and blend(). Calculate
> src_offset in start of looping horizontally and increase it.
> It's better than calculating in every pixels.
>
When you say "optimize" have you observed any actual benefits of the
patch - be that smaller binary, faster execution time, etc?
If there are - mentioned them in the commit message. Otherwise, it
doesn't optimise anything.
A while back, I've suggested something similar [1] mostly for cosmetic
purposes - doubt there's much benefits beyond that.
HTH
-Emil
[1] https://patchwork.freedesktop.org/patch/365177/#comment_674314
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-31 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 13:12 [PATCH] drm/vkms: Optimize compute_crc(), blend() Sidong Yang
2020-05-31 13:12 ` Sidong Yang
2020-05-31 17:18 ` Emil Velikov [this message]
2020-05-31 17:18 ` Emil Velikov
2020-06-01 0:25 ` Rodrigo Siqueira
2020-06-01 0:25 ` Rodrigo Siqueira
2020-06-02 12:18 ` Emil Velikov
2020-06-02 12:18 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACvgo50SzjUe6usELF33qXW3BWZmH5U4ynPTBorZLDrG-Nx2Pw@mail.gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=realwakka@gmail.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.