From: Emil Velikov <emil.l.velikov@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Andy Gross <agross@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
David Airlie <airlied@linux.ie>, Jonathan Corbet <corbet@lwn.net>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-pwm@vger.kernel.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>,
patches@opensource.cirrus.com,
Support Opensource <support.opensource@diasemi.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH v3 0/16] backlight updates
Date: Tue, 2 Jun 2020 15:04:39 +0100 [thread overview]
Message-ID: <CACvgo51z0Vvz9LkfqePmuwx19+NhaMEBHe9r5=uYWqhEdnia_Q@mail.gmail.com> (raw)
In-Reply-To: <20200601065207.492614-1-sam@ravnborg.org>
Hi Sam,
On Mon, 1 Jun 2020 at 07:52, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> v3:
> - Dropped video patch that was reviewd and thus applied
> - Updated kernel-doc so all fields now have a short intro
> - Improved readability in a lot of places, thanks to review
> feedback from Daniel - thanks!
> - Added better intro to backlight
> - Added acks
>
> Several other smaller changes documented in the
> patches.
> I left out patches to make functions static as
> there are dependencies to drm-misc-next for these.
> When this is landed I have a pile of follow-up patches waiting,
> mostly introducing backlight_is_blank() all over.
>
What happened with my suggestion to use backlight_is_blank() in fbdev
core itself?
It effectively makes 13/13 and the above mentioned follow-up series obsolete.
That said, series look spot on. With the documentation fixed (pointer
by Daniel) patches 1-12 are:
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
-Emil
WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Andy Gross <agross@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
David Airlie <airlied@linux.ie>, Jonathan Corbet <corbet@lwn.net>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-pwm@vger.kernel.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>,
patches@opensource.cirrus.com,
Support Opensource <support.opensource@diasemi.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas
Subject: Re: [PATCH v3 0/16] backlight updates
Date: Tue, 2 Jun 2020 15:04:39 +0100 [thread overview]
Message-ID: <CACvgo51z0Vvz9LkfqePmuwx19+NhaMEBHe9r5=uYWqhEdnia_Q@mail.gmail.com> (raw)
In-Reply-To: <20200601065207.492614-1-sam@ravnborg.org>
Hi Sam,
On Mon, 1 Jun 2020 at 07:52, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> v3:
> - Dropped video patch that was reviewd and thus applied
> - Updated kernel-doc so all fields now have a short intro
> - Improved readability in a lot of places, thanks to review
> feedback from Daniel - thanks!
> - Added better intro to backlight
> - Added acks
>
> Several other smaller changes documented in the
> patches.
> I left out patches to make functions static as
> there are dependencies to drm-misc-next for these.
> When this is landed I have a pile of follow-up patches waiting,
> mostly introducing backlight_is_blank() all over.
>
What happened with my suggestion to use backlight_is_blank() in fbdev
core itself?
It effectively makes 13/13 and the above mentioned follow-up series obsolete.
That said, series look spot on. With the documentation fixed (pointer
by Daniel) patches 1-12 are:
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
-Emil
WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
linux-pwm@vger.kernel.org,
Michael Hennerich <michael.hennerich@analog.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Support Opensource <support.opensource@diasemi.com>,
Jingoo Han <jingoohan1@gmail.com>, Andy Gross <agross@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
patches@opensource.cirrus.com
Subject: Re: [PATCH v3 0/16] backlight updates
Date: Tue, 2 Jun 2020 15:04:39 +0100 [thread overview]
Message-ID: <CACvgo51z0Vvz9LkfqePmuwx19+NhaMEBHe9r5=uYWqhEdnia_Q@mail.gmail.com> (raw)
In-Reply-To: <20200601065207.492614-1-sam@ravnborg.org>
Hi Sam,
On Mon, 1 Jun 2020 at 07:52, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> v3:
> - Dropped video patch that was reviewd and thus applied
> - Updated kernel-doc so all fields now have a short intro
> - Improved readability in a lot of places, thanks to review
> feedback from Daniel - thanks!
> - Added better intro to backlight
> - Added acks
>
> Several other smaller changes documented in the
> patches.
> I left out patches to make functions static as
> there are dependencies to drm-misc-next for these.
> When this is landed I have a pile of follow-up patches waiting,
> mostly introducing backlight_is_blank() all over.
>
What happened with my suggestion to use backlight_is_blank() in fbdev
core itself?
It effectively makes 13/13 and the above mentioned follow-up series obsolete.
That said, series look spot on. With the documentation fixed (pointer
by Daniel) patches 1-12 are:
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-02 14:07 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 6:51 [PATCH v3 0/16] backlight updates Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 6:51 ` [PATCH v3 01/13] backlight: refactor fb_notifier_callback() Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 6:51 ` [PATCH v3 02/13] backlight: add backlight_is_blank() Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 12:27 ` Peter Ujfalusi
2020-06-01 12:27 ` Peter Ujfalusi
2020-06-01 12:27 ` Peter Ujfalusi
2020-06-01 6:51 ` [PATCH v3 03/13] backlight: improve backlight_ops documentation Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 6:51 ` [PATCH v3 04/13] backlight: improve backlight_properties documentation Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 10:10 ` Daniel Thompson
2020-06-01 10:10 ` Daniel Thompson
2020-06-01 10:10 ` Daniel Thompson
2020-06-01 6:51 ` [PATCH v3 05/13] backlight: improve backlight_device documentation Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 6:51 ` Sam Ravnborg
2020-06-01 10:23 ` Daniel Thompson
2020-06-01 10:23 ` Daniel Thompson
2020-06-01 10:23 ` Daniel Thompson
2020-06-01 6:52 ` [PATCH v3 06/13] backlight: document inline functions in backlight.h Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 07/13] backlight: document enums " Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 08/13] backlight: remove the unused backlight_bl driver Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 09/13] backlight: drop extern from prototypes Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 10/13] backlight: add overview and update existing doc Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 10:34 ` Daniel Thompson
2020-06-01 10:34 ` Daniel Thompson
2020-06-01 10:34 ` Daniel Thompson
2020-06-01 6:52 ` [PATCH v3 11/13] backlight: wire up kernel-doc documentation Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` [PATCH v3 12/13] backlight: as3711_bl: introduce backlight_is_blank() Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 10:35 ` Daniel Thompson
2020-06-01 10:35 ` Daniel Thompson
2020-06-01 10:35 ` Daniel Thompson
2020-06-01 6:52 ` [PATCH v3 13/13] backlight: use backlight_is_blank() in all backlight drivers Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 6:52 ` Sam Ravnborg
2020-06-01 12:28 ` Peter Ujfalusi
2020-06-01 12:28 ` Peter Ujfalusi
2020-06-01 12:28 ` Peter Ujfalusi
2020-06-01 12:39 ` Sam Ravnborg
2020-06-01 12:39 ` Sam Ravnborg
2020-06-01 12:39 ` Sam Ravnborg
2020-06-02 14:04 ` Emil Velikov [this message]
2020-06-02 14:04 ` [PATCH v3 0/16] backlight updates Emil Velikov
2020-06-02 14:04 ` Emil Velikov
2020-07-02 8:01 ` Sam Ravnborg
2020-07-02 8:01 ` Sam Ravnborg
2020-07-02 8:01 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo51z0Vvz9LkfqePmuwx19+NhaMEBHe9r5=uYWqhEdnia_Q@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michael.hennerich@analog.com \
--cc=mripard@kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@ti.com \
--cc=sam@ravnborg.org \
--cc=support.opensource@diasemi.com \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.