All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: Heiko Becker <heirecka@exherbo.org>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	Timo Gurr <timo.gurr@gmail.com>
Subject: Re: [PATCH libdrm v2] *-symbol-check: Don't hard-code nm executable
Date: Fri, 23 Feb 2018 00:25:27 +0000	[thread overview]
Message-ID: <CACvgo527nU7ZS870swjPnvP-ZEq6Xm4hzgPA1dNxiPBLkv1U=g@mail.gmail.com> (raw)
In-Reply-To: <20180219163533.8943-1-eric.engestrom@imgtec.com>

On 19 February 2018 at 16:35, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> From: Heiko Becker <heirecka@exherbo.org>
>
> Helpful if your nm executable has a prefix based on the
> architecture, for example.
>

> +env_test = environment()
> +env_test.set('NM', find_program('nm').path())
> +
Everything else is great, just not too sure about this hunk.
Are you sure it does what the commit message says?

I know meson needs special configuration file for cross compilation -
one example where nm has prefix.
Yet the manual [1] does not say anything about nm. I cannot find any
instances of nm in the docs all together :-\

If Meson does not handle it currently, please open a bug and add a
comment with the bug number/link.

Thanks
Emil
[1] http://mesonbuild.com/Cross-compilation.html
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-02-23  0:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 14:34 [Bug 105163] *-symbol-checks hard-code the nm executable bugzilla-daemon
2018-02-19 16:35 ` [PATCH libdrm v2] *-symbol-check: Don't hard-code " Eric Engestrom
2018-02-22 23:27   ` Eric Anholt
2018-02-23  0:25   ` Emil Velikov [this message]
2018-02-23 15:02     ` Eric Engestrom
2018-02-23 15:04       ` Eric Engestrom
2018-02-23 16:56       ` Emil Velikov
2018-02-26 15:18 ` [Bug 105163] *-symbol-checks hard-code the " bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACvgo527nU7ZS870swjPnvP-ZEq6Xm4hzgPA1dNxiPBLkv1U=g@mail.gmail.com' \
    --to=emil.l.velikov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric.engestrom@imgtec.com \
    --cc=heirecka@exherbo.org \
    --cc=timo.gurr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.