Re: [PATCH libdrm v2] *-symbol-check: Don't hard-code nm executable

[Emil Velikov <emil.l.velikov@gmail.com>]

On 23 February 2018 at 15:02, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> On Friday, 2018-02-23 00:25:27 +0000, Emil Velikov wrote:
>> On 19 February 2018 at 16:35, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
>> > From: Heiko Becker <heirecka@exherbo.org>
>> >
>> > Helpful if your nm executable has a prefix based on the
>> > architecture, for example.
>> >
>>
>> > +env_test = environment()
>> > +env_test.set('NM', find_program('nm').path())
>> > +
>> Everything else is great, just not too sure about this hunk.
>> Are you sure it does what the commit message says?
>
> It does, I even asked the meson devs to be sure. find_program()
> respects the crossfile, unless `native: true` is added [2].
>
I was thinking of cases where a) you're doing a native build and b)
the program name has a prefix.
In reality that shouldn't happen, often, so let's worry if we get
multiple bug reports.

>>
>> I know meson needs special configuration file for cross compilation -
>> one example where nm has prefix.
>> Yet the manual [1] does not say anything about nm. I cannot find any
>> instances of nm in the docs all together :-\
>
> There's nothing special about `nm` here, it's just a program that can be
> set via the crossfile, like `cc` or `ar`.
> I guess the documentation on the cross-compilation page [1] could be
> improved to make the behaviour of find_program() more explicit; care to
> send a patch? :)
>
Great, I'll let you do the honours of tweaking Meson/its documentation.

Thank you very much for the clarification.

The patch is
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel