All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] intel: fix a conversion format mismatch
@ 2017-03-09  2:12 Chih-Wei Huang
  2017-03-09 16:16 ` Emil Velikov
  0 siblings, 1 reply; 2+ messages in thread
From: Chih-Wei Huang @ 2017-03-09  2:12 UTC (permalink / raw)
  To: dri-devel; +Cc: Chih-Wei Huang

To avoid the warning:

external/libdrm/intel/intel_bufmgr.c:362:20: warning: more '%' conversions than data arguments [-Wformat]
        fprintf(stderr, "%s: Mappable aperture size hardcoded to 64MiB\n");
                         ~^

Change-Id: I6c1b0a9e3004aacde0d64662de1144cadff30132
---
 intel/intel_bufmgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/intel/intel_bufmgr.c b/intel/intel_bufmgr.c
index 42f5f62..5bad93f 100644
--- a/intel/intel_bufmgr.c
+++ b/intel/intel_bufmgr.c
@@ -359,7 +359,7 @@ static size_t
 drm_intel_probe_agp_aperture_size(int fd)
 {
 	/* Nothing seems to rely on this value on Android anyway... */
-	fprintf(stderr, "%s: Mappable aperture size hardcoded to 64MiB\n");
+	fprintf(stderr, "%s: Mappable aperture size hardcoded to 64MiB\n", __func__);
 	return 64 * 1024 * 1024;
 }
 #endif
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] intel: fix a conversion format mismatch
  2017-03-09  2:12 [PATCH] intel: fix a conversion format mismatch Chih-Wei Huang
@ 2017-03-09 16:16 ` Emil Velikov
  0 siblings, 0 replies; 2+ messages in thread
From: Emil Velikov @ 2017-03-09 16:16 UTC (permalink / raw)
  To: Chih-Wei Huang; +Cc: Chih-Wei Huang, ML dri-devel

Hi Chih-Wei,

On 9 March 2017 at 02:12, Chih-Wei Huang <cwhuang@android-x86.org> wrote:
> To avoid the warning:
>
> external/libdrm/intel/intel_bufmgr.c:362:20: warning: more '%' conversions than data arguments [-Wformat]
>         fprintf(stderr, "%s: Mappable aperture size hardcoded to 64MiB\n");
>                          ~^
>
This seems to depend on the patch from Tomasz, which removes the
libpciaccess dependency and stubs the API.
Personally I don't mind having that one land and if so, this fix
should be squashed.

> Change-Id: I6c1b0a9e3004aacde0d64662de1144cadff30132
Please drop these and use your s-o-b for upstream submissions.

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-09 16:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-09  2:12 [PATCH] intel: fix a conversion format mismatch Chih-Wei Huang
2017-03-09 16:16 ` Emil Velikov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.