From: Emil Velikov <emil.l.velikov@gmail.com>
To: Laura Abbott <labbott@redhat.com>
Cc: "Sumit Semwal" <sumit.semwal@linaro.org>,
"Riley Andrews" <riandrews@android.com>,
"Arve Hjønnevåg" <arve@android.com>,
devel@driverdev.osuosl.org, "Rom Lemarchand" <romlem@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org,
"Mark Brown" <broonie@kernel.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
LAKML <linux-arm-kernel@lists.infradead.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCHv3 17/22] staging: android: ion: Collapse internal header files
Date: Sat, 8 Apr 2017 19:12:25 +0100 [thread overview]
Message-ID: <CACvgo52qr=oBoiMnrww3cgoKozEMi3DwBV55c_GMi0mR_p0GcA@mail.gmail.com> (raw)
In-Reply-To: <1491245884-15852-18-git-send-email-labbott@redhat.com>
Hi Laura,
Couple of trivial nitpicks below.
On 3 April 2017 at 19:57, Laura Abbott <labbott@redhat.com> wrote:
> --- a/drivers/staging/android/ion/ion.h
> +++ b/drivers/staging/android/ion/ion.h
> @@ -1,5 +1,5 @@
> /*
> - * drivers/staging/android/ion/ion.h
> + * drivers/staging/android/ion/ion_priv.h
Does not match the actual filename.
> *
> * Copyright (C) 2011 Google, Inc.
> *
> @@ -14,24 +14,26 @@
> *
> */
>
> -#ifndef _LINUX_ION_H
> -#define _LINUX_ION_H
> +#ifndef _ION_PRIV_H
> +#define _ION_PRIV_H
>
Ditto.
> +#include <linux/device.h>
> +#include <linux/dma-direction.h>
> +#include <linux/kref.h>
> +#include <linux/mm_types.h>
> +#include <linux/mutex.h>
> +#include <linux/rbtree.h>
> +#include <linux/sched.h>
> +#include <linux/shrinker.h>
> #include <linux/types.h>
> +#include <linux/miscdevice.h>
>
> #include "../uapi/ion.h"
>
You don't want to use "../" in includes. Perhaps address with another
patch, if you haven't already ?
Regards,
Emil
WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Laura Abbott <labbott@redhat.com>
Cc: "Sumit Semwal" <sumit.semwal@linaro.org>,
"Riley Andrews" <riandrews@android.com>,
"Arve Hjønnevåg" <arve@android.com>,
devel@driverdev.osuosl.org, "Rom Lemarchand" <romlem@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org,
"Mark Brown" <broonie@kernel.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
LAKML <linux-arm-kernel@lists.infradead.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCHv3 17/22] staging: android: ion: Collapse internal header files
Date: Sat, 8 Apr 2017 19:12:25 +0100 [thread overview]
Message-ID: <CACvgo52qr=oBoiMnrww3cgoKozEMi3DwBV55c_GMi0mR_p0GcA@mail.gmail.com> (raw)
In-Reply-To: <1491245884-15852-18-git-send-email-labbott@redhat.com>
Hi Laura,
Couple of trivial nitpicks below.
On 3 April 2017 at 19:57, Laura Abbott <labbott@redhat.com> wrote:
> --- a/drivers/staging/android/ion/ion.h
> +++ b/drivers/staging/android/ion/ion.h
> @@ -1,5 +1,5 @@
> /*
> - * drivers/staging/android/ion/ion.h
> + * drivers/staging/android/ion/ion_priv.h
Does not match the actual filename.
> *
> * Copyright (C) 2011 Google, Inc.
> *
> @@ -14,24 +14,26 @@
> *
> */
>
> -#ifndef _LINUX_ION_H
> -#define _LINUX_ION_H
> +#ifndef _ION_PRIV_H
> +#define _ION_PRIV_H
>
Ditto.
> +#include <linux/device.h>
> +#include <linux/dma-direction.h>
> +#include <linux/kref.h>
> +#include <linux/mm_types.h>
> +#include <linux/mutex.h>
> +#include <linux/rbtree.h>
> +#include <linux/sched.h>
> +#include <linux/shrinker.h>
> #include <linux/types.h>
> +#include <linux/miscdevice.h>
>
> #include "../uapi/ion.h"
>
You don't want to use "../" in includes. Perhaps address with another
patch, if you haven't already ?
Regards,
Emil
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: emil.l.velikov@gmail.com (Emil Velikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 17/22] staging: android: ion: Collapse internal header files
Date: Sat, 8 Apr 2017 19:12:25 +0100 [thread overview]
Message-ID: <CACvgo52qr=oBoiMnrww3cgoKozEMi3DwBV55c_GMi0mR_p0GcA@mail.gmail.com> (raw)
In-Reply-To: <1491245884-15852-18-git-send-email-labbott@redhat.com>
Hi Laura,
Couple of trivial nitpicks below.
On 3 April 2017 at 19:57, Laura Abbott <labbott@redhat.com> wrote:
> --- a/drivers/staging/android/ion/ion.h
> +++ b/drivers/staging/android/ion/ion.h
> @@ -1,5 +1,5 @@
> /*
> - * drivers/staging/android/ion/ion.h
> + * drivers/staging/android/ion/ion_priv.h
Does not match the actual filename.
> *
> * Copyright (C) 2011 Google, Inc.
> *
> @@ -14,24 +14,26 @@
> *
> */
>
> -#ifndef _LINUX_ION_H
> -#define _LINUX_ION_H
> +#ifndef _ION_PRIV_H
> +#define _ION_PRIV_H
>
Ditto.
> +#include <linux/device.h>
> +#include <linux/dma-direction.h>
> +#include <linux/kref.h>
> +#include <linux/mm_types.h>
> +#include <linux/mutex.h>
> +#include <linux/rbtree.h>
> +#include <linux/sched.h>
> +#include <linux/shrinker.h>
> #include <linux/types.h>
> +#include <linux/miscdevice.h>
>
> #include "../uapi/ion.h"
>
You don't want to use "../" in includes. Perhaps address with another
patch, if you haven't already ?
Regards,
Emil
next prev parent reply other threads:[~2017-04-08 18:12 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 18:57 [PATCHv3 00/22] Ion clean up in preparation in moving out of staging Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 01/22] cma: Store a name in the cma structure Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 02/22] cma: Introduce cma_for_each_area Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 03/22] staging: android: ion: Remove dmap_cnt Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 04/22] staging: android: ion: Remove alignment from allocation field Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 05/22] staging: android: ion: Duplicate sg_table Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 06/22] staging: android: ion: Call dma_map_sg for syncing and mapping Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 07/22] staging: android: ion: Remove page faulting support Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-11 6:00 ` Archit Taneja
2017-04-11 6:00 ` Archit Taneja
2017-04-11 6:00 ` Archit Taneja
2017-04-03 18:57 ` [PATCHv3 08/22] staging: android: ion: Remove crufty cache support Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-11 5:08 ` Archit Taneja
2017-04-11 5:08 ` Archit Taneja
2017-04-11 5:08 ` Archit Taneja
2017-04-03 18:57 ` [PATCHv3 09/22] staging: android: ion: Remove custom ioctl interface Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 10/22] staging: android: ion: Remove import interface Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 11/22] staging: android: ion: Remove duplicate ION_IOC_MAP Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 12/22] staging: android: ion: Remove old platform support Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 13/22] staging: android: ion: Use CMA APIs directly Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-11 6:47 ` Laurent Pinchart
2017-04-11 6:47 ` Laurent Pinchart
2017-04-11 6:47 ` Laurent Pinchart
2017-04-11 16:48 ` Laura Abbott
2017-04-11 16:48 ` Laura Abbott
2017-04-11 16:48 ` Laura Abbott
2017-04-11 16:48 ` Laura Abbott
2017-04-18 14:07 ` Greg Kroah-Hartman
2017-04-18 14:07 ` Greg Kroah-Hartman
2017-04-18 14:07 ` Greg Kroah-Hartman
2017-04-18 14:07 ` Greg Kroah-Hartman
2017-04-03 18:57 ` [PATCHv3 14/22] staging: android: ion: Stop butchering the DMA address Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 15/22] staging: android: ion: Break the ABI in the name of forward progress Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 16/22] staging: android: ion: Get rid of ion_phys_addr_t Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` [PATCHv3 17/22] staging: android: ion: Collapse internal header files Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-03 18:57 ` Laura Abbott
2017-04-08 18:12 ` Emil Velikov [this message]
2017-04-08 18:12 ` Emil Velikov
2017-04-08 18:12 ` Emil Velikov
2017-04-10 15:10 ` Laura Abbott
2017-04-10 15:10 ` Laura Abbott
2017-04-10 15:10 ` Laura Abbott
2017-04-03 18:58 ` [PATCHv3 18/22] staging: android: ion: Rework heap registration/enumeration Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` [PATCHv3 19/22] staging: android: ion: Drop ion_map_kernel interface Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` [PATCHv3 20/22] staging: android: ion: Remove ion_handle and ion_client Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` [PATCHv3 21/22] staging: android: ion: Set query return value Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` [PATCHv3 22/22] staging/android: Update Ion TODO list Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-03 18:58 ` Laura Abbott
2017-04-08 10:38 ` [PATCHv3 00/22] Ion clean up in preparation in moving out of staging Greg Kroah-Hartman
2017-04-08 10:38 ` Greg Kroah-Hartman
2017-04-08 10:38 ` Greg Kroah-Hartman
2017-04-10 16:20 ` Laura Abbott
2017-04-10 16:20 ` Laura Abbott
2017-04-10 16:20 ` Laura Abbott
2017-04-10 16:25 ` Greg Kroah-Hartman
2017-04-10 16:25 ` Greg Kroah-Hartman
2017-04-10 16:25 ` Greg Kroah-Hartman
2017-04-10 16:25 ` Greg Kroah-Hartman
2017-04-10 17:20 ` Laura Abbott
2017-04-10 17:20 ` Laura Abbott
2017-04-10 17:20 ` Laura Abbott
2017-04-10 17:20 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo52qr=oBoiMnrww3cgoKozEMi3DwBV55c_GMi0mR_p0GcA@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=arve@android.com \
--cc=broonie@kernel.org \
--cc=daniel.vetter@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riandrews@android.com \
--cc=romlem@google.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.