From: Bongsu Jeon <bongsu.jeon2@gmail.com>
To: krzk@kernel.org
Cc: Krzysztof Opasiak <k.opasiak@samsung.com>,
linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers
Date: Fri, 27 Nov 2020 14:41:25 +0900 [thread overview]
Message-ID: <CACwDmQA5acuCpUcjf7Q0biG9KnfK+3WGjTDbDaFpnMMMhBv9sg@mail.gmail.com> (raw)
In-Reply-To: <CAEx-X7esGyZ2QiTGbE1H7M7z1dqT47awmqrOtN+p0FbwtwfPOg@mail.gmail.com>
On 11/27/20, Bongsu Jeon <bs.jeon87@gmail.com> wrote:
> On Fri, Nov 27, 2020 at 2:06 AM Krzysztof Kozlowski <krzk@kernel.org>
> wrote:
>>
>> On Fri, Nov 27, 2020 at 12:33:37AM +0900, bongsu.jeon2@gmail.com wrote:
>> > From: Krzysztof Kozlowski <krzk@kernel.org>
>> >
>> > GPIOs - as returned by of_get_named_gpio() and used by the gpiolib -
>> > are
>> > signed integers, where negative number indicates error. The return
>> > value of of_get_named_gpio() should not be assigned to an unsigned int
>> > because in case of !CONFIG_GPIOLIB such number would be a valid GPIO.
>> >
>> > Fixes: c04c674fadeb ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC
>> > Chip")
>> > Cc: <stable@vger.kernel.org>
>> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> Why do you send my patch?
>>
>
> I think that your patch should be applied before refactoring for this
> driver.
> So, I applied your patch to net-next branch and included your patch at
> my patch list.
> Is this the wrong process?
>
Sorry to confuse you.
I found your patch when i updated my workspace using git pull.
>> Best regards,
>> Krzysztof
>
WARNING: multiple messages have this Message-ID (diff)
From: Bongsu Jeon <bongsu.jeon2@gmail.com>
To: linux-nfc@lists.01.org
Subject: [linux-nfc] Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers
Date: Fri, 27 Nov 2020 14:41:25 +0900 [thread overview]
Message-ID: <CACwDmQA5acuCpUcjf7Q0biG9KnfK+3WGjTDbDaFpnMMMhBv9sg@mail.gmail.com> (raw)
In-Reply-To: CAEx-X7esGyZ2QiTGbE1H7M7z1dqT47awmqrOtN+p0FbwtwfPOg@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]
On 11/27/20, Bongsu Jeon <bs.jeon87@gmail.com> wrote:
> On Fri, Nov 27, 2020@2:06 AM Krzysztof Kozlowski <krzk@kernel.org>
> wrote:
>>
>> On Fri, Nov 27, 2020@12:33:37AM +0900, bongsu.jeon2@gmail.com wrote:
>> > From: Krzysztof Kozlowski <krzk@kernel.org>
>> >
>> > GPIOs - as returned by of_get_named_gpio() and used by the gpiolib -
>> > are
>> > signed integers, where negative number indicates error. The return
>> > value of of_get_named_gpio() should not be assigned to an unsigned int
>> > because in case of !CONFIG_GPIOLIB such number would be a valid GPIO.
>> >
>> > Fixes: c04c674fadeb ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC
>> > Chip")
>> > Cc: <stable@vger.kernel.org>
>> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> Why do you send my patch?
>>
>
> I think that your patch should be applied before refactoring for this
> driver.
> So, I applied your patch to net-next branch and included your patch at
> my patch list.
> Is this the wrong process?
>
Sorry to confuse you.
I found your patch when i updated my workspace using git pull.
>> Best regards,
>> Krzysztof
>
WARNING: multiple messages have this Message-ID (diff)
From: Bongsu Jeon <bongsu.jeon2@gmail.com>
To: linux-nfc@lists.01.org
Subject: Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers
Date: Fri, 27 Nov 2020 14:41:25 +0900 [thread overview]
Message-ID: <CACwDmQA5acuCpUcjf7Q0biG9KnfK+3WGjTDbDaFpnMMMhBv9sg@mail.gmail.com> (raw)
In-Reply-To: <CAEx-X7esGyZ2QiTGbE1H7M7z1dqT47awmqrOtN+p0FbwtwfPOg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]
On 11/27/20, Bongsu Jeon <bs.jeon87@gmail.com> wrote:
> On Fri, Nov 27, 2020 at 2:06 AM Krzysztof Kozlowski <krzk@kernel.org>
> wrote:
>>
>> On Fri, Nov 27, 2020 at 12:33:37AM +0900, bongsu.jeon2(a)gmail.com wrote:
>> > From: Krzysztof Kozlowski <krzk@kernel.org>
>> >
>> > GPIOs - as returned by of_get_named_gpio() and used by the gpiolib -
>> > are
>> > signed integers, where negative number indicates error. The return
>> > value of of_get_named_gpio() should not be assigned to an unsigned int
>> > because in case of !CONFIG_GPIOLIB such number would be a valid GPIO.
>> >
>> > Fixes: c04c674fadeb ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC
>> > Chip")
>> > Cc: <stable@vger.kernel.org>
>> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> Why do you send my patch?
>>
>
> I think that your patch should be applied before refactoring for this
> driver.
> So, I applied your patch to net-next branch and included your patch at
> my patch list.
> Is this the wrong process?
>
Sorry to confuse you.
I found your patch when i updated my workspace using git pull.
>> Best regards,
>> Krzysztof
>
next prev parent reply other threads:[~2020-11-27 5:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 15:33 [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers bongsu.jeon2
2020-11-26 15:33 ` bongsu.jeon2
2020-11-26 15:33 ` [linux-nfc] " bongsu.jeon2
2020-11-26 15:33 ` [PATCH net-next 2/3] nfc: s3fwrn5: reduce the EN_WAIT_TIME bongsu.jeon2
2020-11-26 15:33 ` bongsu.jeon2
2020-11-26 15:33 ` [linux-nfc] " bongsu.jeon2
2020-11-26 17:03 ` Krzysztof Kozlowski
2020-11-26 17:03 ` Krzysztof Kozlowski
2020-11-26 17:03 ` [linux-nfc] " Krzysztof Kozlowski
2020-11-26 15:33 ` [PATCH net-next 3/3] nfc: s3fwrn5: extract the common phy blocks bongsu.jeon2
2020-11-26 15:33 ` bongsu.jeon2
2020-11-26 15:33 ` [linux-nfc] " bongsu.jeon2
2020-11-26 17:12 ` Krzysztof Kozlowski
2020-11-26 17:12 ` Krzysztof Kozlowski
2020-11-26 17:12 ` [linux-nfc] " Krzysztof Kozlowski
2020-11-26 23:09 ` Bongsu Jeon
2020-11-26 23:09 ` Bongsu Jeon
2020-11-26 23:09 ` [linux-nfc] " Bongsu Jeon
2020-11-28 11:45 ` Krzysztof Kozlowski
2020-11-28 11:45 ` Krzysztof Kozlowski
2020-11-28 11:45 ` [linux-nfc] " Krzysztof Kozlowski
2020-11-26 17:01 ` [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers Krzysztof Kozlowski
2020-11-26 17:01 ` Krzysztof Kozlowski
2020-11-26 17:01 ` [linux-nfc] " Krzysztof Kozlowski
2020-11-26 22:53 ` Bongsu Jeon
2020-11-27 5:41 ` Bongsu Jeon [this message]
2020-11-27 5:41 ` Bongsu Jeon
2020-11-27 5:41 ` [linux-nfc] " Bongsu Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACwDmQA5acuCpUcjf7Q0biG9KnfK+3WGjTDbDaFpnMMMhBv9sg@mail.gmail.com \
--to=bongsu.jeon2@gmail.com \
--cc=k.opasiak@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.