All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yongji Xie <xieyongji@bytedance.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Stefano Garzarella" <sgarzare@redhat.com>,
	"Parav Pandit" <parav@nvidia.com>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Christian Brauner" <christian.brauner@canonical.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Jens Axboe" <axboe@kernel.dk>,
	bcrl@kvack.org, "Jonathan Corbet" <corbet@lwn.net>,
	"Mika Penttilä" <mika.penttila@nextfour.com>,
	"Dan Carpenter" <dan.carpenter@oracle.com>,
	joro@8bytes.org, "Greg KH" <gregkh@linuxfoundation.org>,
	"He Zhe" <zhe.he@windriver.com>,
	"Liu Xiaodong" <xiaodong.liu@intel.com>,
	"Joe Perches" <joe@perches.com>,
	songmuchun@bytedance.com,
	virtualization <virtualization@lists.linux-foundation.org>,
	netdev@vger.kernel.org, kvm <kvm@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 02/17] file: Export receive_fd() to modules
Date: Tue, 3 Aug 2021 17:01:57 +0800	[thread overview]
Message-ID: <CACycT3sdx8nA8fh3pjO_=pbiM+Bs5y+h4fuGkFQEsRSaBnph7Q@mail.gmail.com> (raw)
In-Reply-To: <a0ab081a-db06-6b7a-b22e-4ace96a5c7db@redhat.com>

On Tue, Aug 3, 2021 at 3:46 PM Jason Wang <jasowang@redhat.com> wrote:
>
>
> 在 2021/7/29 下午3:34, Xie Yongji 写道:
> > Export receive_fd() so that some modules can use
> > it to pass file descriptor between processes without
> > missing any security stuffs.
> >
> > Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> > ---
> >   fs/file.c            | 6 ++++++
> >   include/linux/file.h | 7 +++----
> >   2 files changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/file.c b/fs/file.c
> > index 86dc9956af32..210e540672aa 100644
> > --- a/fs/file.c
> > +++ b/fs/file.c
> > @@ -1134,6 +1134,12 @@ int receive_fd_replace(int new_fd, struct file *file, unsigned int o_flags)
> >       return new_fd;
> >   }
> >
> > +int receive_fd(struct file *file, unsigned int o_flags)
> > +{
> > +     return __receive_fd(file, NULL, o_flags);
>
>
> Any reason that receive_fd_user() can live in the file.h?
>

Since no modules use it.

Thanks,
Yongji

WARNING: multiple messages have this Message-ID (diff)
From: Yongji Xie <xieyongji@bytedance.com>
To: Jason Wang <jasowang@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>,
	virtualization <virtualization@lists.linux-foundation.org>,
	"Christian Brauner" <christian.brauner@canonical.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Dan Carpenter" <dan.carpenter@oracle.com>,
	"Stefano Garzarella" <sgarzare@redhat.com>,
	"Liu Xiaodong" <xiaodong.liu@intel.com>,
	linux-fsdevel@vger.kernel.org,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	songmuchun@bytedance.com, "Jens Axboe" <axboe@kernel.dk>,
	"He Zhe" <zhe.he@windriver.com>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	iommu@lists.linux-foundation.org, bcrl@kvack.org,
	netdev@vger.kernel.org, "Joe Perches" <joe@perches.com>,
	"Mika Penttilä" <mika.penttila@nextfour.com>
Subject: Re: [PATCH v10 02/17] file: Export receive_fd() to modules
Date: Tue, 3 Aug 2021 17:01:57 +0800	[thread overview]
Message-ID: <CACycT3sdx8nA8fh3pjO_=pbiM+Bs5y+h4fuGkFQEsRSaBnph7Q@mail.gmail.com> (raw)
In-Reply-To: <a0ab081a-db06-6b7a-b22e-4ace96a5c7db@redhat.com>

On Tue, Aug 3, 2021 at 3:46 PM Jason Wang <jasowang@redhat.com> wrote:
>
>
> 在 2021/7/29 下午3:34, Xie Yongji 写道:
> > Export receive_fd() so that some modules can use
> > it to pass file descriptor between processes without
> > missing any security stuffs.
> >
> > Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> > ---
> >   fs/file.c            | 6 ++++++
> >   include/linux/file.h | 7 +++----
> >   2 files changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/file.c b/fs/file.c
> > index 86dc9956af32..210e540672aa 100644
> > --- a/fs/file.c
> > +++ b/fs/file.c
> > @@ -1134,6 +1134,12 @@ int receive_fd_replace(int new_fd, struct file *file, unsigned int o_flags)
> >       return new_fd;
> >   }
> >
> > +int receive_fd(struct file *file, unsigned int o_flags)
> > +{
> > +     return __receive_fd(file, NULL, o_flags);
>
>
> Any reason that receive_fd_user() can live in the file.h?
>

Since no modules use it.

Thanks,
Yongji
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-08-03  9:02 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  7:34 [PATCH v10 00/17] Introduce VDUSE - vDPA Device in Userspace Xie Yongji
2021-07-29  7:34 ` Xie Yongji
2021-07-29  7:34 ` [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast() Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-08-03  7:41   ` Jason Wang
2021-08-03  7:41     ` Jason Wang
2021-08-03  7:41     ` Jason Wang
2021-08-03  7:41   ` Jason Wang
2021-08-03  7:41     ` Jason Wang
2021-08-03  7:41     ` Jason Wang
2021-08-03  8:54     ` Yongji Xie
2021-08-03  8:54       ` Yongji Xie
2021-08-03 10:53       ` Robin Murphy
2021-08-03 10:53         ` Robin Murphy
2021-08-03 10:53         ` Robin Murphy
2021-08-04  5:02         ` Yongji Xie
2021-08-04  5:02           ` Yongji Xie
2021-08-04 15:43           ` Robin Murphy
2021-08-04 15:43             ` Robin Murphy
2021-08-04 15:43             ` Robin Murphy
2021-08-05 12:34             ` Yongji Xie
2021-08-05 12:34               ` Yongji Xie
2021-08-05 13:31               ` Jason Wang
2021-08-05 13:31                 ` Jason Wang
2021-08-05 13:31                 ` Jason Wang
2021-08-09  5:56                 ` Yongji Xie
2021-08-09  5:56                   ` Yongji Xie
2021-08-10  3:02                   ` Jason Wang
2021-08-10  3:02                     ` Jason Wang
2021-08-10  3:02                     ` Jason Wang
2021-08-10  7:43                     ` Yongji Xie
2021-08-10  7:43                       ` Yongji Xie
2021-07-29  7:34 ` [PATCH v10 02/17] file: Export receive_fd() to modules Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-08-03  7:45   ` Jason Wang
2021-08-03  7:45     ` Jason Wang
2021-08-03  7:45     ` Jason Wang
2021-08-03  9:01     ` Yongji Xie [this message]
2021-08-03  9:01       ` Yongji Xie
2021-08-04  8:27       ` Jason Wang
2021-08-04  8:27         ` Jason Wang
2021-08-04  8:27         ` Jason Wang
2021-07-29  7:34 ` [PATCH v10 03/17] vdpa: Fix code indentation Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-08-03  7:50   ` Jason Wang
2021-08-03  7:50     ` Jason Wang
2021-08-03  7:50     ` Jason Wang
2021-08-03  9:13     ` Yongji Xie
2021-08-03  9:13       ` Yongji Xie
2021-07-29  7:34 ` [PATCH v10 04/17] vdpa: Fail the vdpa_reset() if fail to set device status to zero Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-08-03  7:58   ` Jason Wang
2021-08-03  7:58     ` Jason Wang
2021-08-03  7:58     ` Jason Wang
2021-08-03  9:31     ` Yongji Xie
2021-08-03  9:31       ` Yongji Xie
2021-08-04  8:30       ` Jason Wang
2021-08-04  8:30         ` Jason Wang
2021-08-04  8:30         ` Jason Wang
2021-07-29  7:34 ` [PATCH v10 05/17] vhost-vdpa: Fail the vhost_vdpa_set_status() on reset failure Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-08-03  8:10   ` Jason Wang
2021-08-03  8:10     ` Jason Wang
2021-08-03  8:10     ` Jason Wang
2021-08-03  9:50     ` Yongji Xie
2021-08-03  9:50       ` Yongji Xie
2021-08-04  8:33       ` Jason Wang
2021-08-04  8:33         ` Jason Wang
2021-08-04  8:33         ` Jason Wang
2021-07-29  7:34 ` [PATCH v10 06/17] vhost-vdpa: Handle the failure of vdpa_reset() Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-07-29  7:34 ` [PATCH v10 07/17] virtio: Don't set FAILED status bit on device index allocation failure Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-08-03  8:02   ` Jason Wang
2021-08-03  8:02     ` Jason Wang
2021-08-03  8:02     ` Jason Wang
2021-08-03  9:17     ` Yongji Xie
2021-08-03  9:17       ` Yongji Xie
2021-07-29  7:34 ` [PATCH v10 08/17] virtio_config: Add a return value to reset function Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-07-29  7:34 ` [PATCH v10 09/17] virtio-vdpa: Handle the failure of vdpa_reset() Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-07-29  7:34 ` [PATCH v10 10/17] virtio: Handle device reset failure in register_virtio_device() Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-08-03  8:09   ` Jason Wang
2021-08-03  8:09     ` Jason Wang
2021-08-03  8:09     ` Jason Wang
2021-08-03  9:38     ` Yongji Xie
2021-08-03  9:38       ` Yongji Xie
2021-08-04  8:32       ` Jason Wang
2021-08-04  8:32         ` Jason Wang
2021-08-04  8:32         ` Jason Wang
2021-08-04  8:50         ` Yongji Xie
2021-08-04  8:50           ` Yongji Xie
2021-08-04  8:54           ` Jason Wang
2021-08-04  8:54             ` Jason Wang
2021-08-04  8:54             ` Jason Wang
2021-08-04  9:07             ` Yongji Xie
2021-08-04  9:07               ` Yongji Xie
2021-08-05  7:12               ` Jason Wang
2021-08-05  7:12                 ` Jason Wang
2021-08-05  7:12                 ` Jason Wang
2021-07-29  7:34 ` [PATCH v10 11/17] vhost-iotlb: Add an opaque pointer for vhost IOTLB Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-07-29  7:34 ` [PATCH v10 12/17] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map() Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-07-29  7:34 ` [PATCH v10 13/17] vdpa: factor out vhost_vdpa_pa_map() and vhost_vdpa_pa_unmap() Xie Yongji
2021-07-29  7:34   ` Xie Yongji
2021-07-29  7:35 ` [PATCH v10 14/17] vdpa: Support transferring virtual addressing during DMA mapping Xie Yongji
2021-07-29  7:35   ` Xie Yongji
2021-07-29  7:35 ` [PATCH v10 15/17] vduse: Implement an MMU-based software IOTLB Xie Yongji
2021-07-29  7:35   ` Xie Yongji
2021-07-29  7:35 ` [PATCH v10 16/17] vduse: Introduce VDUSE - vDPA Device in Userspace Xie Yongji
2021-07-29  7:35   ` Xie Yongji
2021-07-29  9:00   ` Greg KH
2021-07-29  9:00     ` Greg KH
2021-07-29  9:00     ` Greg KH
2021-07-29  9:57     ` Yongji Xie
2021-07-29  9:57       ` Yongji Xie
2021-08-03  7:30   ` Jason Wang
2021-08-03  7:30     ` Jason Wang
2021-08-03  7:30     ` Jason Wang
2021-08-03  8:39     ` Yongji Xie
2021-08-03  8:39       ` Yongji Xie
2021-07-29  7:35 ` [PATCH v10 17/17] Documentation: Add documentation for VDUSE Xie Yongji
2021-07-29  7:35   ` Xie Yongji
2021-08-03  7:35   ` Jason Wang
2021-08-03  7:35     ` Jason Wang
2021-08-03  7:35     ` Jason Wang
2021-08-03  8:52     ` Yongji Xie
2021-08-03  8:52       ` Yongji Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACycT3sdx8nA8fh3pjO_=pbiM+Bs5y+h4fuGkFQEsRSaBnph7Q@mail.gmail.com' \
    --to=xieyongji@bytedance.com \
    --cc=axboe@kernel.dk \
    --cc=bcrl@kvack.org \
    --cc=christian.brauner@canonical.com \
    --cc=corbet@lwn.net \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jasowang@redhat.com \
    --cc=joe@perches.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.penttila@nextfour.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=rdunlap@infradead.org \
    --cc=sgarzare@redhat.com \
    --cc=songmuchun@bytedance.com \
    --cc=stefanha@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willy@infradead.org \
    --cc=xiaodong.liu@intel.com \
    --cc=zhe.he@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.