From: Jack Wang <xjtuwjp@gmail.com> To: Christoph Hellwig <hch@lst.de> Cc: "Justin Sanders" <justin@coraid.com>, "Mike Snitzer" <snitzer@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Jason Wang" <jasowang@redhat.com>, linux-nvme@lists.infradead.org, "Song Liu" <song@kernel.org>, dm-devel@redhat.com, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, "Ilya Dryomov" <idryomov@gmail.com>, "Jack Wang" <jinpu.wang@cloud.ionos.com>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, "Josef Bacik" <josef@toxicpanda.com>, nbd@other.debian.org, linux-raid@vger.kernel.org, "Stefan Hajnoczi" <stefanha@redhat.com>, drbd-dev@tron.linbit.com, ceph-devel@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>, linux-block@vger.kernel.org, "Martin K. Petersen" <martin.petersen@oracle.com>, "Minchan Kim" <minchan@kernel.org>, linux-fsdevel@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>, "Roger Pau Monné" <roger.pau@citrix.com> Subject: Re: [dm-devel] [PATCH 24/24] block: unexport revalidate_disk_size Date: Sat, 7 Nov 2020 05:43:14 +0100 [thread overview] Message-ID: <CAD+HZHUaPLB0T2A3vAPq6gSr5gEGK3XLMSAmO0FLhkWaLzPBpg@mail.gmail.com> (raw) In-Reply-To: <20201106190337.1973127-25-hch@lst.de> [-- Attachment #1.1: Type: text/plain, Size: 937 bytes --] Christoph Hellwig <hch@lst.de>于2020年11月6日 周五20:15写道: > revalidate_disk_size is not only called from set_capacity_and_notify, > so drop the export. s/not/now > > > Signed-off-by: Christoph Hellwig <hch@lst.de> Thanks! Jack Wang > > --- > fs/block_dev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index 66ebf594c97f47..d8664f5c1ff669 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -1362,7 +1362,6 @@ void revalidate_disk_size(struct gendisk *disk, bool > verbose) > bdput(bdev); > } > } > -EXPORT_SYMBOL(revalidate_disk_size); > > void bd_set_nr_sectors(struct block_device *bdev, sector_t sectors) > { > -- > 2.28.0 > > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme > [-- Attachment #1.2: Type: text/html, Size: 1971 bytes --] [-- Attachment #2: Type: text/plain, Size: 93 bytes --] -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jack Wang <xjtuwjp@gmail.com> To: Christoph Hellwig <hch@lst.de> Cc: "Ilya Dryomov" <idryomov@gmail.com>, "Jack Wang" <jinpu.wang@cloud.ionos.com>, "Jason Wang" <jasowang@redhat.com>, "Jens Axboe" <axboe@kernel.dk>, "Josef Bacik" <josef@toxicpanda.com>, "Justin Sanders" <justin@coraid.com>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Mike Snitzer" <snitzer@redhat.com>, "Minchan Kim" <minchan@kernel.org>, "Paolo Bonzini" <pbonzini@redhat.com>, "Roger Pau Monné" <roger.pau@citrix.com>, "Song Liu" <song@kernel.org>, "Stefan Hajnoczi" <stefanha@redhat.com>, ceph-devel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, nbd@other.debian.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 24/24] block: unexport revalidate_disk_size Date: Sat, 7 Nov 2020 05:43:14 +0100 [thread overview] Message-ID: <CAD+HZHUaPLB0T2A3vAPq6gSr5gEGK3XLMSAmO0FLhkWaLzPBpg@mail.gmail.com> (raw) In-Reply-To: <20201106190337.1973127-25-hch@lst.de> [-- Attachment #1: Type: text/plain, Size: 937 bytes --] Christoph Hellwig <hch@lst.de>于2020年11月6日 周五20:15写道: > revalidate_disk_size is not only called from set_capacity_and_notify, > so drop the export. s/not/now > > > Signed-off-by: Christoph Hellwig <hch@lst.de> Thanks! Jack Wang > > --- > fs/block_dev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index 66ebf594c97f47..d8664f5c1ff669 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -1362,7 +1362,6 @@ void revalidate_disk_size(struct gendisk *disk, bool > verbose) > bdput(bdev); > } > } > -EXPORT_SYMBOL(revalidate_disk_size); > > void bd_set_nr_sectors(struct block_device *bdev, sector_t sectors) > { > -- > 2.28.0 > > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme > [-- Attachment #2: Type: text/html, Size: 1971 bytes --]
next prev parent reply other threads:[~2020-11-08 17:05 UTC|newest] Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-06 19:03 cleanup updating the size of block devices Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 01/24] block: remove the call to __invalidate_device in check_disk_size_change Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 02/24] loop: remove loop_set_size Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-09 7:53 ` Hannes Reinecke 2020-11-09 7:53 ` [dm-devel] " Hannes Reinecke 2020-11-09 7:53 ` Hannes Reinecke 2020-11-09 8:53 ` Christoph Hellwig 2020-11-09 8:53 ` [dm-devel] " Christoph Hellwig 2020-11-09 8:53 ` Christoph Hellwig 2020-11-09 9:25 ` Hannes Reinecke 2020-11-09 9:25 ` [dm-devel] " Hannes Reinecke 2020-11-09 9:25 ` Hannes Reinecke 2020-11-09 23:28 ` Sagi Grimberg 2020-11-09 23:28 ` [dm-devel] " Sagi Grimberg 2020-11-09 23:28 ` Sagi Grimberg 2020-11-10 7:00 ` Hannes Reinecke 2020-11-10 7:00 ` [dm-devel] " Hannes Reinecke 2020-11-10 7:00 ` Hannes Reinecke 2020-11-06 19:03 ` [PATCH 04/24] sd: update the bdev size in sd_revalidate_disk Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-11 4:18 ` Martin K. Petersen 2020-11-11 4:18 ` [dm-devel] " Martin K. Petersen 2020-11-11 4:18 ` Martin K. Petersen 2020-11-06 19:03 ` [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 06/24] block: add a return value to set_capacity_and_notify Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 07/24] nbd: remove the call to set_blocksize Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 08/24] nbd: move the task_recv check into nbd_size_update Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 09/24] nbd: refactor size updates Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 10/24] nbd: validate the block size in nbd_set_size Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 11/24] nbd: use set_capacity_and_notify Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 12/24] aoe: don't call set_capacity from irq context Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 13/24] dm: use set_capacity_and_notify Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 14/24] pktcdvd: " Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 15/24] nvme: use set_capacity_and_notify in nvme_set_queue_dying Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 16/24] drbd: use set_capacity_and_notify Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 17/24] rbd: " Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-09 13:52 ` Ilya Dryomov 2020-11-09 13:52 ` [dm-devel] " Ilya Dryomov 2020-11-09 13:52 ` Ilya Dryomov 2020-11-06 19:03 ` [PATCH 18/24] rnbd: " Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-09 6:56 ` Jinpu Wang 2020-11-09 6:56 ` [dm-devel] " Jinpu Wang 2020-11-09 6:56 ` Jinpu Wang 2020-11-06 19:03 ` [PATCH 19/24] zram: " Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 20/24] dm-raid: " Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-06 19:03 ` [PATCH 21/24] md: " Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-07 0:32 ` Song Liu 2020-11-07 0:32 ` [dm-devel] " Song Liu 2020-11-07 0:32 ` Song Liu 2020-11-06 19:03 ` [PATCH 22/24] md: remove a spurious call to revalidate_disk_size in update_size Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-07 0:39 ` Song Liu 2020-11-07 0:39 ` [dm-devel] " Song Liu 2020-11-07 0:39 ` Song Liu 2020-11-06 19:03 ` [PATCH 23/24] virtio-blk: remove a spurious call to revalidate_disk_size Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-08 15:15 ` Paolo Bonzini 2020-11-08 15:15 ` [dm-devel] " Paolo Bonzini 2020-11-08 15:15 ` Paolo Bonzini 2020-11-09 10:22 ` Stefan Hajnoczi 2020-11-09 10:22 ` [dm-devel] " Stefan Hajnoczi 2020-11-09 10:22 ` Stefan Hajnoczi 2020-11-09 11:30 ` Michael S. Tsirkin 2020-11-09 11:30 ` [dm-devel] " Michael S. Tsirkin 2020-11-09 11:30 ` Michael S. Tsirkin 2020-11-06 19:03 ` [PATCH 24/24] block: unexport revalidate_disk_size Christoph Hellwig 2020-11-06 19:03 ` [dm-devel] " Christoph Hellwig 2020-11-06 19:03 ` Christoph Hellwig 2020-11-07 4:43 ` Jack Wang [this message] 2020-11-07 4:43 ` Jack Wang 2020-11-09 18:07 ` cleanup updating the size of block devices Josef Bacik 2020-11-09 18:07 ` [dm-devel] " Josef Bacik 2020-11-09 18:07 ` Josef Bacik 2020-11-11 8:26 cleanup updating the size of block devices v2 Christoph Hellwig 2020-11-11 8:26 ` [dm-devel] [PATCH 24/24] block: unexport revalidate_disk_size Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAD+HZHUaPLB0T2A3vAPq6gSr5gEGK3XLMSAmO0FLhkWaLzPBpg@mail.gmail.com \ --to=xjtuwjp@gmail.com \ --cc=axboe@kernel.dk \ --cc=ceph-devel@vger.kernel.org \ --cc=dm-devel@redhat.com \ --cc=drbd-dev@tron.linbit.com \ --cc=hch@lst.de \ --cc=idryomov@gmail.com \ --cc=jasowang@redhat.com \ --cc=jinpu.wang@cloud.ionos.com \ --cc=josef@toxicpanda.com \ --cc=justin@coraid.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-raid@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=minchan@kernel.org \ --cc=mst@redhat.com \ --cc=nbd@other.debian.org \ --cc=pbonzini@redhat.com \ --cc=roger.pau@citrix.com \ --cc=snitzer@redhat.com \ --cc=song@kernel.org \ --cc=stefanha@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.