NFC: CONFIG_NFC_DEBUG not defined

NFC: CONFIG_NFC_DEBUG not defined

[Valentin Rothberg]

Hi Clément,

your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI
chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the
following line:

+ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG

The Kconfig option NFC_DEBUG is not defined so the line turns out to
be a nop.  There is another reference in drivers/nfc/Makefile.  Is
there a patch queued somewhere to add the option?

I found this issue with ./scripts/checkkconfigsymbols.py by diffing
v4.0 and v4.1-rc1.

Kind regards,
 Valentin

Re: NFC: CONFIG_NFC_DEBUG not defined

[Valentin Rothberg]

I took the email from the author field of the commit, which does not
exists anymore.  Now I added Clément's correct email address.

On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg
<valentinrothberg@gmail.com> wrote:
> Hi Clément,
>
> your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI
> chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the
> following line:
>
> +ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
>
> The Kconfig option NFC_DEBUG is not defined so the line turns out to
> be a nop.  There is another reference in drivers/nfc/Makefile.  Is
> there a patch queued somewhere to add the option?
>
> I found this issue with ./scripts/checkkconfigsymbols.py by diffing
> v4.0 and v4.1-rc1.
>
> Kind regards,
>  Valentin

Re: NFC: CONFIG_NFC_DEBUG not defined

[Clément Perrochaud]

On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg wrote:
> Hi Clément,
>
> your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI
> chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the
> following line:
>
> +ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
>
> The Kconfig option NFC_DEBUG is not defined so the line turns out to
> be a nop.  There is another reference in drivers/nfc/Makefile.  Is
> there a patch queued somewhere to add the option?
>
> I found this issue with ./scripts/checkkconfigsymbols.py by diffing
> v4.0 and v4.1-rc1.

Hi Valentin,

I only included this line because it was present in the upper-level
Makefile drivers/nfc/Makefile . As far as I know, there is no plan to
add this option to the configuration.

What would the most sensible solution to this issue be ? Add the NFC
Debug feature to the configuration ? Remove it altogether ?

Regards,

-- 
Clément Perrochaud

Eff'Innov Technologies
Caen, Aix-En-Provence, Grenoble

Eff'Innov Technologies
Campus EffiScience
2, Esplanade Anton Philips
14460 Colombelles, FRANCE

http://www.effinnov.com

Re: NFC: CONFIG_NFC_DEBUG not defined

[Valentin Rothberg]

Hi Clément,

thanks for your answer.

On Tue, Apr 28, 2015 at 10:23 AM, Clément Perrochaud
<clement.perrochaud@effinnov.com> wrote:
> On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg wrote:
>> Hi Clément,
>>
>> your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI
>> chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the
>> following line:
>>
>> +ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
>>
>> The Kconfig option NFC_DEBUG is not defined so the line turns out to
>> be a nop.  There is another reference in drivers/nfc/Makefile.  Is
>> there a patch queued somewhere to add the option?
>>
>> I found this issue with ./scripts/checkkconfigsymbols.py by diffing
>> v4.0 and v4.1-rc1.
>
> Hi Valentin,
>
> I only included this line because it was present in the upper-level
> Makefile drivers/nfc/Makefile . As far as I know, there is no plan to
> add this option to the configuration.
>
> What would the most sensible solution to this issue be ? Add the NFC
> Debug feature to the configuration ? Remove it altogether ?

DEBUG is not used in any of the files in drivers/nfc/ so I think we
can safely remove the two lines from the Makefiles.  Do you want me to
prepare a patch?

Kind regards,
 Valentin

> Regards,
>
> --
> Clément Perrochaud
>
> Eff'Innov Technologies
> Caen, Aix-En-Provence, Grenoble
>
> Eff'Innov Technologies
> Campus EffiScience
> 2, Esplanade Anton Philips
> 14460 Colombelles, FRANCE
>
> http://www.effinnov.com

Re: NFC: CONFIG_NFC_DEBUG not defined

[Clément Perrochaud]

On 04/28/2015 10:35 AM, Valentin Rothberg wrote:
> DEBUG is not used in any of the files in drivers/nfc/ so I think we
> can safely remove the two lines from the Makefiles.  Do you want me to
> prepare a patch?

That would be great, thanks.

-- 
Clément Perrochaud

Eff'Innov Technologies
Caen, Aix-En-Provence, Grenoble

Eff'Innov Technologies
Campus EffiScience
2, Esplanade Anton Philips
14460 Colombelles, FRANCE

http://www.effinnov.com