[master][morty][PATCH 1/2] ltp: Fix QA warning

[master][morty][PATCH 1/2] ltp: Fix QA warning

[Jagadeesh Krishnanjanappa]

It solves below QA issue WARNING while building ltp, when
LICENSE_CREATE_PACKAGE is set to "1"

-- snip --
WARNING: ltp-20160126-r0 do_package_qa: QA Issue: /opt/ltp/share/licenses/ltp/run_freezer.sh contained in package ltp-lic requires /bin/bash, but no providers found in RDEPENDS_ltp-lic? [file-rdeps]
-- snip --

Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
---
 meta/recipes-extended/ltp/ltp_20160126.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-extended/ltp/ltp_20160126.bb b/meta/recipes-extended/ltp/ltp_20160126.bb
index 7631e0e..c731f42 100644
--- a/meta/recipes-extended/ltp/ltp_20160126.bb
+++ b/meta/recipes-extended/ltp/ltp_20160126.bb
@@ -105,6 +105,7 @@ do_install(){
 }
 
 RDEPENDS_${PN} = "perl e2fsprogs-mke2fs python-core libaio bash gawk expect ldd"
+RDEPENDS_${PN}-lic = "bash"
 
 FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a"
 
-- 
2.7.4

[master][morty][PATCH 2/2] hdparm: Fix QA warning

[Jagadeesh Krishnanjanappa]

It solves below QA issue WARNING while building hdparm, when
LICENSE_CREATE_PACKAGE is set to "1"

-- snip --
WARNING: hdparm-9.48-r0 do_package_qa: QA Issue: /usr/share/licenses/hdparm/wiper.sh contained in package hdparm-lic requires /bin/bash, but no providers found in RDEPENDS_hdparm-lic? [file-rdeps]
-- snip --

Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
---
 meta/recipes-extended/hdparm/hdparm_9.48.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/hdparm/hdparm_9.48.bb b/meta/recipes-extended/hdparm/hdparm_9.48.bb
index cd85776..2c1e77d 100644
--- a/meta/recipes-extended/hdparm/hdparm_9.48.bb
+++ b/meta/recipes-extended/hdparm/hdparm_9.48.bb
@@ -38,3 +38,5 @@ do_install () {
 	oe_runmake 'DESTDIR=${D}' 'sbindir=${base_sbindir}' install
 	cp ${S}/wiper/wiper.sh ${D}/${bindir}
 }
+
+RDEPENDS_${PN}-lic = "bash"
-- 
2.7.4

Re: [master][morty][PATCH 1/2] ltp: Fix QA warning

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

On 3 November 2016 at 18:04, Jagadeesh Krishnanjanappa <
jkrishnanjanappa@mvista.com> wrote:

> WARNING: ltp-20160126-r0 do_package_qa: QA Issue:
> /opt/ltp/share/licenses/ltp/run_freezer.sh contained in package ltp-lic
> requires /bin/bash, but no providers found in RDEPENDS_ltp-lic? [file-rdeps]
>

So the common problem "if PN-lic contains a license statement embedded in a
file with a hashbang, file-rdeps is triggered", so I'd say file-rdeps
should be added to INSANE_SKIP_${PN}-lic in bitbake.conf instead of dealing
with this per recipe.

Ross

[-- Attachment #2: Type: text/html, Size: 988 bytes --]

Re: [master][morty][PATCH 1/2] ltp: Fix QA warning

[Jagadeesh Krishnanjanappa]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

>
>
> On 3 November 2016 at 18:04, Jagadeesh Krishnanjanappa <
> jkrishnanjanappa@mvista.com> wrote:
>
>> WARNING: ltp-20160126-r0 do_package_qa: QA Issue:
>> /opt/ltp/share/licenses/ltp/run_freezer.sh contained in package ltp-lic
>> requires /bin/bash, but no providers found in RDEPENDS_ltp-lic? [file-rdeps]
>>
>
> So the common problem "if PN-lic contains a license statement embedded in
> a file with a hashbang, file-rdeps is triggered", so I'd say file-rdeps
> should be added to INSANE_SKIP_${PN}-lic in bitbake.conf instead of dealing
> with this per recipe.
>
>  Thanks for the review. I will send v2 adding INSANE_SKIP_${PN}-lic =
"file-rdeps" in bitbake.conf file.

Regards,
Jagadeesh


Ross
>

[-- Attachment #2: Type: text/html, Size: 2015 bytes --]