* [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting
@ 2019-02-13 10:03 David Santamaría Rogado via dri-devel
2019-02-13 10:13 ` Fwd: " David Santamaría Rogado via dri-devel
0 siblings, 1 reply; 4+ messages in thread
From: David Santamaría Rogado via dri-devel @ 2019-02-13 10:03 UTC (permalink / raw)
To: Jani Nikula, David Airlie, Daniel Vetter, Thierry Reding, dri-devel
The (void *) casting in the driver_data variable assignment is superfluous.
Spotted by Jani Nikula.
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 52e445bb1aa58..61d3361381b73 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
},
- .driver_data = (void *)&acer_s1003,
+ .driver_data = &acer_s1003,
}, { /* Asus T100HA */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
},
- .driver_data = (void *)&asus_t100ha,
+ .driver_data = &asus_t100ha,
}, { /*
* GPD Pocket, note that the the DMI data is less generic then
* it seems, devices with a board-vendor of "AMI Corporation"
@@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
},
- .driver_data = (void *)&gpd_pocket,
+ .driver_data = &gpd_pocket,
}, { /* GPD Win (same note on DMI match as GPD Pocket) */
.matches = {
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
@@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
},
- .driver_data = (void *)&gpd_win,
+ .driver_data = &gpd_win,
}, { /* GPD Win 2 (too generic strings, also match on bios date) */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
@@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
},
- .driver_data = (void *)&gpd_win2,
+ .driver_data = &gpd_win2,
}, { /* I.T.Works TW891 */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
@@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."),
DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
},
- .driver_data = (void *)&itworks_tw891,
+ .driver_data = &itworks_tw891,
}, { /*
* Lenovo Ideapad Miix 310 laptop, only some production batches
* have a portrait screen, the resolution checks makes the quirk
@@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
},
- .driver_data = (void *)&lcd800x1280_rightside_up,
+ .driver_data = &lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad Miix 320 */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
},
- .driver_data = (void *)&lcd800x1280_rightside_up,
+ .driver_data = &lcd800x1280_rightside_up,
}, { /* VIOS LTH17 */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
},
- .driver_data = (void *)&lcd800x1280_rightside_up,
+ .driver_data = &lcd800x1280_rightside_up,
},
{}
};
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting
2019-02-13 10:03 [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting David Santamaría Rogado via dri-devel
@ 2019-02-13 10:13 ` David Santamaría Rogado via dri-devel
2019-02-13 12:41 ` Thierry Reding via dri-devel
0 siblings, 1 reply; 4+ messages in thread
From: David Santamaría Rogado via dri-devel @ 2019-02-13 10:13 UTC (permalink / raw)
To: Jani Nikula, David Airlie, Daniel Vetter, Thierry Reding, dri-devel
Sorry previous one wasn't signed off by.
The (void *) casting in the driver_data variable assignment is superfluous.
Spotted by Jani Nikula.
Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 52e445bb1aa58..61d3361381b73 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
},
- .driver_data = (void *)&acer_s1003,
+ .driver_data = &acer_s1003,
}, { /* Asus T100HA */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
},
- .driver_data = (void *)&asus_t100ha,
+ .driver_data = &asus_t100ha,
}, { /*
* GPD Pocket, note that the the DMI data is less generic then
* it seems, devices with a board-vendor of "AMI Corporation"
@@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
},
- .driver_data = (void *)&gpd_pocket,
+ .driver_data = &gpd_pocket,
}, { /* GPD Win (same note on DMI match as GPD Pocket) */
.matches = {
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
@@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
},
- .driver_data = (void *)&gpd_win,
+ .driver_data = &gpd_win,
}, { /* GPD Win 2 (too generic strings, also match on bios date) */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
@@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
},
- .driver_data = (void *)&gpd_win2,
+ .driver_data = &gpd_win2,
}, { /* I.T.Works TW891 */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
@@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."),
DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
},
- .driver_data = (void *)&itworks_tw891,
+ .driver_data = &itworks_tw891,
}, { /*
* Lenovo Ideapad Miix 310 laptop, only some production batches
* have a portrait screen, the resolution checks makes the quirk
@@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
},
- .driver_data = (void *)&lcd800x1280_rightside_up,
+ .driver_data = &lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad Miix 320 */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
},
- .driver_data = (void *)&lcd800x1280_rightside_up,
+ .driver_data = &lcd800x1280_rightside_up,
}, { /* VIOS LTH17 */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
},
- .driver_data = (void *)&lcd800x1280_rightside_up,
+ .driver_data = &lcd800x1280_rightside_up,
},
{}
};
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting
2019-02-13 10:13 ` Fwd: " David Santamaría Rogado via dri-devel
@ 2019-02-13 12:41 ` Thierry Reding via dri-devel
2019-02-14 10:55 ` Jani Nikula via dri-devel
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding via dri-devel @ 2019-02-13 12:41 UTC (permalink / raw)
To: David Santamaría Rogado; +Cc: David Airlie, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 709 bytes --]
On Wed, Feb 13, 2019 at 11:13:23AM +0100, David Santamaría Rogado wrote:
> Sorry previous one wasn't signed off by.
And now you've got this comment in the commit message that's going to
confuse people looking at the log.
It's usually to put this kind of comment below the --- line...
> The (void *) casting in the driver_data variable assignment is superfluous.
> Spotted by Jani Nikula.
>
> Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
> ---
... right here.
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Otherwise, looks good to me:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting
2019-02-13 12:41 ` Thierry Reding via dri-devel
@ 2019-02-14 10:55 ` Jani Nikula via dri-devel
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula via dri-devel @ 2019-02-14 10:55 UTC (permalink / raw)
To: Thierry Reding, David Santamaría Rogado; +Cc: David Airlie, dri-devel
On Wed, 13 Feb 2019, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Wed, Feb 13, 2019 at 11:13:23AM +0100, David Santamaría Rogado wrote:
>> Sorry previous one wasn't signed off by.
>
> And now you've got this comment in the commit message that's going to
> confuse people looking at the log.
>
> It's usually to put this kind of comment below the --- line...
>
>> The (void *) casting in the driver_data variable assignment is superfluous.
>> Spotted by Jani Nikula.
Please either make that
Suggested-by: Jani Nikula <jani.nikula@intel.com>
or leave out completely.
>>
>> Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
>> ---
>
> ... right here.
>
>> drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> Otherwise, looks good to me:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
With Thierry's suggestion fixed,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-14 10:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 10:03 [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting David Santamaría Rogado via dri-devel
2019-02-13 10:13 ` Fwd: " David Santamaría Rogado via dri-devel
2019-02-13 12:41 ` Thierry Reding via dri-devel
2019-02-14 10:55 ` Jani Nikula via dri-devel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.