* [U-Boot] [PATCH] gpio: sunxi: Add compatible string for H5 PIO
@ 2018-01-15 22:28 Chris Blake
2018-01-23 19:09 ` Jagan Teki
2018-01-24 16:43 ` Jagan Teki
0 siblings, 2 replies; 6+ messages in thread
From: Chris Blake @ 2018-01-15 22:28 UTC (permalink / raw)
To: u-boot
Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards.
Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
---
drivers/gpio/sunxi_gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c
index b47cc66..856b7ef 100644
--- a/drivers/gpio/sunxi_gpio.c
+++ b/drivers/gpio/sunxi_gpio.c
@@ -345,6 +345,7 @@ static const struct udevice_id sunxi_gpio_ids[] = {
ID("allwinner,sun4i-a10-pinctrl", a_all),
ID("allwinner,sun5i-a10s-pinctrl", a_all),
ID("allwinner,sun5i-a13-pinctrl", a_all),
+ ID("allwinner,sun50i-h5-pinctrl", a_all),
ID("allwinner,sun6i-a31-pinctrl", a_all),
ID("allwinner,sun6i-a31s-pinctrl", a_all),
ID("allwinner,sun7i-a20-pinctrl", a_all),
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] gpio: sunxi: Add compatible string for H5 PIO
2018-01-15 22:28 [U-Boot] [PATCH] gpio: sunxi: Add compatible string for H5 PIO Chris Blake
@ 2018-01-23 19:09 ` Jagan Teki
2018-01-23 19:12 ` Chris Blake
2018-01-24 16:43 ` Jagan Teki
1 sibling, 1 reply; 6+ messages in thread
From: Jagan Teki @ 2018-01-23 19:09 UTC (permalink / raw)
To: u-boot
On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote:
> Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards.
What is the issue observed w/o this?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] gpio: sunxi: Add compatible string for H5 PIO
2018-01-23 19:09 ` Jagan Teki
@ 2018-01-23 19:12 ` Chris Blake
2018-01-23 19:15 ` Jagan Teki
0 siblings, 1 reply; 6+ messages in thread
From: Chris Blake @ 2018-01-23 19:12 UTC (permalink / raw)
To: u-boot
On Tue, Jan 23, 2018 at 1:09 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote:
>> Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards.
>
> What is the issue observed w/o this?
Without this, H5 boards that rely on CONFIG_MACPWR for Ethernet do not
support networking in u-boot. This also breaks access to GPIOs via the
gpio cmd.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] gpio: sunxi: Add compatible string for H5 PIO
2018-01-23 19:12 ` Chris Blake
@ 2018-01-23 19:15 ` Jagan Teki
2018-01-23 19:16 ` Chris Blake
0 siblings, 1 reply; 6+ messages in thread
From: Jagan Teki @ 2018-01-23 19:15 UTC (permalink / raw)
To: u-boot
On Wed, Jan 24, 2018 at 12:42 AM, Chris Blake <chrisrblake93@gmail.com> wrote:
> On Tue, Jan 23, 2018 at 1:09 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
>> On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote:
>>> Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards.
>>
>> What is the issue observed w/o this?
>
> Without this, H5 boards that rely on CONFIG_MACPWR for Ethernet do not
> support networking in u-boot. This also breaks access to GPIOs via the
> gpio cmd.
Ok, did you verify it on opi-pc2?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] gpio: sunxi: Add compatible string for H5 PIO
2018-01-23 19:15 ` Jagan Teki
@ 2018-01-23 19:16 ` Chris Blake
0 siblings, 0 replies; 6+ messages in thread
From: Chris Blake @ 2018-01-23 19:16 UTC (permalink / raw)
To: u-boot
On Tue, Jan 23, 2018 at 1:15 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> On Wed, Jan 24, 2018 at 12:42 AM, Chris Blake <chrisrblake93@gmail.com> wrote:
>> On Tue, Jan 23, 2018 at 1:09 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
>>> On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote:
>>>> Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards.
>>>
>>> What is the issue observed w/o this?
>>
>> Without this, H5 boards that rely on CONFIG_MACPWR for Ethernet do not
>> support networking in u-boot. This also breaks access to GPIOs via the
>> gpio cmd.
>
> Ok, did you verify it on opi-pc2?
This was verified on a FriendlyARM NanoPi Neo2 and FriendlyARM NanoPi Neo Core2.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] gpio: sunxi: Add compatible string for H5 PIO
2018-01-15 22:28 [U-Boot] [PATCH] gpio: sunxi: Add compatible string for H5 PIO Chris Blake
2018-01-23 19:09 ` Jagan Teki
@ 2018-01-24 16:43 ` Jagan Teki
1 sibling, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2018-01-24 16:43 UTC (permalink / raw)
To: u-boot
On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote:
> Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards.
>
> Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> ---
> drivers/gpio/sunxi_gpio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c
> index b47cc66..856b7ef 100644
> --- a/drivers/gpio/sunxi_gpio.c
> +++ b/drivers/gpio/sunxi_gpio.c
> @@ -345,6 +345,7 @@ static const struct udevice_id sunxi_gpio_ids[] = {
> ID("allwinner,sun4i-a10-pinctrl", a_all),
> ID("allwinner,sun5i-a10s-pinctrl", a_all),
> ID("allwinner,sun5i-a13-pinctrl", a_all),
> + ID("allwinner,sun50i-h5-pinctrl", a_all),
Reviewed-by: Jagan Teki <jagan@openedev.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-24 16:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15 22:28 [U-Boot] [PATCH] gpio: sunxi: Add compatible string for H5 PIO Chris Blake
2018-01-23 19:09 ` Jagan Teki
2018-01-23 19:12 ` Chris Blake
2018-01-23 19:15 ` Jagan Teki
2018-01-23 19:16 ` Chris Blake
2018-01-24 16:43 ` Jagan Teki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.