* [U-Boot] [PATCH] mtd: spi: spi_flash: fix build with dma enabled
@ 2018-06-28 19:26 Grygorii Strashko
2018-07-16 8:56 ` Jagan Teki
0 siblings, 1 reply; 3+ messages in thread
From: Grygorii Strashko @ 2018-06-28 19:26 UTC (permalink / raw)
To: u-boot
Fix build with CONFIG_DMA enabled
drivers/mtd/spi/spi_flash.c:376: undefined reference to `dma_memcpy'
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/mtd/spi/spi_flash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
index c159124..d6cbdf2 100644
--- a/drivers/mtd/spi/spi_flash.c
+++ b/drivers/mtd/spi/spi_flash.c
@@ -457,7 +457,7 @@ int spi_flash_read_common(struct spi_flash *flash, const u8 *cmd,
*/
void __weak spi_flash_copy_mmap(void *data, void *offset, size_t len)
{
-#ifdef CONFIG_DMA
+#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_DMA)
if (!dma_memcpy(data, offset, len))
return;
#endif
--
2.10.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mtd: spi: spi_flash: fix build with dma enabled
2018-06-28 19:26 [U-Boot] [PATCH] mtd: spi: spi_flash: fix build with dma enabled Grygorii Strashko
@ 2018-07-16 8:56 ` Jagan Teki
2018-07-20 21:43 ` Grygorii Strashko
0 siblings, 1 reply; 3+ messages in thread
From: Jagan Teki @ 2018-07-16 8:56 UTC (permalink / raw)
To: u-boot
On Fri, Jun 29, 2018 at 12:56 AM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
> Fix build with CONFIG_DMA enabled
> drivers/mtd/spi/spi_flash.c:376: undefined reference to `dma_memcpy'
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/mtd/spi/spi_flash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
> index c159124..d6cbdf2 100644
> --- a/drivers/mtd/spi/spi_flash.c
> +++ b/drivers/mtd/spi/spi_flash.c
> @@ -457,7 +457,7 @@ int spi_flash_read_common(struct spi_flash *flash, const u8 *cmd,
> */
> void __weak spi_flash_copy_mmap(void *data, void *offset, size_t len)
> {
> -#ifdef CONFIG_DMA
> +#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_DMA)
What if SPI flash using in SPL with DMA enabled?
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mtd: spi: spi_flash: fix build with dma enabled
2018-07-16 8:56 ` Jagan Teki
@ 2018-07-20 21:43 ` Grygorii Strashko
0 siblings, 0 replies; 3+ messages in thread
From: Grygorii Strashko @ 2018-07-20 21:43 UTC (permalink / raw)
To: u-boot
On 07/16/2018 03:56 AM, Jagan Teki wrote:
> On Fri, Jun 29, 2018 at 12:56 AM, Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
>> Fix build with CONFIG_DMA enabled
>> drivers/mtd/spi/spi_flash.c:376: undefined reference to `dma_memcpy'
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> drivers/mtd/spi/spi_flash.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
>> index c159124..d6cbdf2 100644
>> --- a/drivers/mtd/spi/spi_flash.c
>> +++ b/drivers/mtd/spi/spi_flash.c
>> @@ -457,7 +457,7 @@ int spi_flash_read_common(struct spi_flash *flash, const u8 *cmd,
>> */
>> void __weak spi_flash_copy_mmap(void *data, void *offset, size_t len)
>> {
>> -#ifdef CONFIG_DMA
>> +#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_DMA)
>
> What if SPI flash using in SPL with DMA enabled?
>
It'd require to do additional fix/rework. I've been thinking about it,
but I don't know how to fix it other way - any advice?
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-20 21:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-28 19:26 [U-Boot] [PATCH] mtd: spi: spi_flash: fix build with dma enabled Grygorii Strashko
2018-07-16 8:56 ` Jagan Teki
2018-07-20 21:43 ` Grygorii Strashko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.