All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
@ 2017-10-30 23:36 Icenowy Zheng
  2017-10-31  7:57 ` Jagan Teki
  0 siblings, 1 reply; 15+ messages in thread
From: Icenowy Zheng @ 2017-10-30 23:36 UTC (permalink / raw)
  To: u-boot

Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano Pi
NEO2), which may not work properly at 1008MHz if the chip's quality is
not so good.

Lower the default CPUx frequency of H5 to 816MHz.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 arch/arm/mach-sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
index 09cfec6f57..1fededd0a3 100644
--- a/arch/arm/mach-sunxi/Kconfig
+++ b/arch/arm/mach-sunxi/Kconfig
@@ -397,9 +397,9 @@ config SYS_CLK_FREQ
 	default 1008000000 if MACH_SUN5I
 	default 1008000000 if MACH_SUN6I
 	default 912000000 if MACH_SUN7I
+	default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
 	default 1008000000 if MACH_SUN8I
 	default 1008000000 if MACH_SUN9I
-	default 816000000 if MACH_SUN50I
 
 config SYS_CONFIG_NAME
 	default "sun4i" if MACH_SUN4I
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-10-30 23:36 [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz Icenowy Zheng
@ 2017-10-31  7:57 ` Jagan Teki
  2017-10-31  8:05   ` icenowy at aosc.io
  0 siblings, 1 reply; 15+ messages in thread
From: Jagan Teki @ 2017-10-31  7:57 UTC (permalink / raw)
  To: u-boot

On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano Pi
> NEO2), which may not work properly at 1008MHz if the chip's quality is
> not so good.
>
> Lower the default CPUx frequency of H5 to 816MHz.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  arch/arm/mach-sunxi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index 09cfec6f57..1fededd0a3 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
>         default 1008000000 if MACH_SUN5I
>         default 1008000000 if MACH_SUN6I
>         default 912000000 if MACH_SUN7I
> +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
>         default 1008000000 if MACH_SUN8I

Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
you find an issue with neo2?

[1] http://linux-sunxi.org/Xunlong_Orange_Pi_PC_2#CPU_clock_speed_limit

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-10-31  7:57 ` Jagan Teki
@ 2017-10-31  8:05   ` icenowy at aosc.io
  2017-10-31  8:53     ` Jagan Teki
  2017-10-31 13:54     ` Maxime Ripard
  0 siblings, 2 replies; 15+ messages in thread
From: icenowy at aosc.io @ 2017-10-31  8:05 UTC (permalink / raw)
  To: u-boot

在 2017-10-31 15:57,Jagan Teki 写道:
> On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>> Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano 
>> Pi
>> NEO2), which may not work properly at 1008MHz if the chip's quality is
>> not so good.
>> 
>> Lower the default CPUx frequency of H5 to 816MHz.
>> 
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> ---
>>  arch/arm/mach-sunxi/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
>> index 09cfec6f57..1fededd0a3 100644
>> --- a/arch/arm/mach-sunxi/Kconfig
>> +++ b/arch/arm/mach-sunxi/Kconfig
>> @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
>>         default 1008000000 if MACH_SUN5I
>>         default 1008000000 if MACH_SUN6I
>>         default 912000000 if MACH_SUN7I
>> +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
>>         default 1008000000 if MACH_SUN8I
> 
> Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
> you find an issue with neo2?

Yes, the boot process randomly hang at SPL stage -- but when it enters
ATF it will run smoothly as the ATF will re-configure CPUx frequency
to 816MHz.

According to the official operating point table [2], 1008MHz is bound
to 1.2V, and 816MHz is bound to 1.1V.

Allwinner chips usually have not-so-good quality control to reach the
low price, and different chips may work differently in situations
that is beyond the official the OPP table.

[2] 
https://github.com/OrangePiLibra/OrangePi_H5SDK/blob/master/external/sys_config.fex#L1367

> 
> [1] http://linux-sunxi.org/Xunlong_Orange_Pi_PC_2#CPU_clock_speed_limit
> 
> thanks!

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-10-31  8:05   ` icenowy at aosc.io
@ 2017-10-31  8:53     ` Jagan Teki
  2017-10-31  9:08       ` Icenowy Zheng
  2017-10-31 13:54     ` Maxime Ripard
  1 sibling, 1 reply; 15+ messages in thread
From: Jagan Teki @ 2017-10-31  8:53 UTC (permalink / raw)
  To: u-boot

On Tue, Oct 31, 2017 at 1:35 PM,  <icenowy@aosc.io> wrote:
> 在 2017-10-31 15:57,Jagan Teki 写道:
>>
>> On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>>>
>>> Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano Pi
>>> NEO2), which may not work properly at 1008MHz if the chip's quality is
>>> not so good.
>>>
>>> Lower the default CPUx frequency of H5 to 816MHz.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> ---
>>>  arch/arm/mach-sunxi/Kconfig | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
>>> index 09cfec6f57..1fededd0a3 100644
>>> --- a/arch/arm/mach-sunxi/Kconfig
>>> +++ b/arch/arm/mach-sunxi/Kconfig
>>> @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
>>>         default 1008000000 if MACH_SUN5I
>>>         default 1008000000 if MACH_SUN6I
>>>         default 912000000 if MACH_SUN7I
>>> +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
>>>         default 1008000000 if MACH_SUN8I
>>
>>
>> Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
>> you find an issue with neo2?
>
>
> Yes, the boot process randomly hang at SPL stage -- but when it enters
> ATF it will run smoothly as the ATF will re-configure CPUx frequency
> to 816MHz.

OK, Linux has similar issue, I will check it meanwhile.

>
> According to the official operating point table [2], 1008MHz is bound
> to 1.2V, and 816MHz is bound to 1.1V.

Does this common for all H5 SDK or orangepi design?

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-10-31  8:53     ` Jagan Teki
@ 2017-10-31  9:08       ` Icenowy Zheng
  0 siblings, 0 replies; 15+ messages in thread
From: Icenowy Zheng @ 2017-10-31  9:08 UTC (permalink / raw)
  To: u-boot


于 2017年10月31日 GMT+08:00 下午4:53:57, Jagan Teki <jagannadh.teki@gmail.com> 
写到:
> On Tue, Oct 31, 2017 at 1:35 PM,  <icenowy@aosc.io> wrote:
>> 在 2017-10-31 15:57,Jagan Teki 写道:
>>> 
>>> On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io>
> wrote:
>>>> 
>>>> Some H5 boards are designed to start at 1.1V CPUx voltage (e.g.
> Nano Pi
>>>> NEO2), which may not work properly at 1008MHz if the chip's quality
> is
>>>> not so good.
>>>> 
>>>> Lower the default CPUx frequency of H5 to 816MHz.
>>>> 
>>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>>> ---
>>>>  arch/arm/mach-sunxi/Kconfig | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>> 
>>>> diff --git a/arch/arm/mach-sunxi/Kconfig
> b/arch/arm/mach-sunxi/Kconfig
>>>> index 09cfec6f57..1fededd0a3 100644
>>>> --- a/arch/arm/mach-sunxi/Kconfig
>>>> +++ b/arch/arm/mach-sunxi/Kconfig
>>>> @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
>>>>         default 1008000000 if MACH_SUN5I
>>>>         default 1008000000 if MACH_SUN6I
>>>>         default 912000000 if MACH_SUN7I
>>>> +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
>>>>         default 1008000000 if MACH_SUN8I
>>> 
>>> 
>>> Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
>>> you find an issue with neo2?
>> 
>> 
>> Yes, the boot process randomly hang at SPL stage -- but when it
> enters
>> ATF it will run smoothly as the ATF will re-configure CPUx frequency
>> to 816MHz.
> 
> OK, Linux has similar issue, I will check it meanwhile.
> 
>> 
>> According to the official operating point table [2], 1008MHz is bound
>> to 1.2V, and 816MHz is bound to 1.1V.
> 
> Does this common for all H5 SDK or orangepi design?

For all H5 SDK. It's the original comment in H5 SDK from AW.

> 
> thanks!

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-10-31  8:05   ` icenowy at aosc.io
  2017-10-31  8:53     ` Jagan Teki
@ 2017-10-31 13:54     ` Maxime Ripard
  2017-11-01  0:31       ` Icenowy Zheng
  1 sibling, 1 reply; 15+ messages in thread
From: Maxime Ripard @ 2017-10-31 13:54 UTC (permalink / raw)
  To: u-boot

On Tue, Oct 31, 2017 at 04:05:36PM +0800, icenowy at aosc.io wrote:
> 在 2017-10-31 15:57,Jagan Teki 写道:
> > On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> > > Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano
> > > Pi
> > > NEO2), which may not work properly at 1008MHz if the chip's quality is
> > > not so good.
> > > 
> > > Lower the default CPUx frequency of H5 to 816MHz.
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > ---
> > >  arch/arm/mach-sunxi/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> > > index 09cfec6f57..1fededd0a3 100644
> > > --- a/arch/arm/mach-sunxi/Kconfig
> > > +++ b/arch/arm/mach-sunxi/Kconfig
> > > @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
> > >         default 1008000000 if MACH_SUN5I
> > >         default 1008000000 if MACH_SUN6I
> > >         default 912000000 if MACH_SUN7I
> > > +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
> > >         default 1008000000 if MACH_SUN8I
> > 
> > Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
> > you find an issue with neo2?

So you have one single model that fails, and you change the default
frequency of all the boards using that SoC?

It seems a bit overkill.

I guess we have two solutions:
  1) Change the frequency in that board config
  2) Change the voltage in that board config

There's no need to enforce a SoC-wide change.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171031/74509f18/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-10-31 13:54     ` Maxime Ripard
@ 2017-11-01  0:31       ` Icenowy Zheng
  2017-11-01  2:10         ` [U-Boot] [linux-sunxi] " Ondřej Jirman
  2017-11-02 13:56         ` [U-Boot] " Maxime Ripard
  0 siblings, 2 replies; 15+ messages in thread
From: Icenowy Zheng @ 2017-11-01  0:31 UTC (permalink / raw)
  To: u-boot

在 2017-10-31 21:54,Maxime Ripard 写道:
> On Tue, Oct 31, 2017 at 04:05:36PM +0800, icenowy at aosc.io wrote:
>> 在 2017-10-31 15:57,Jagan Teki 写道:
>> > On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>> > > Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano
>> > > Pi
>> > > NEO2), which may not work properly at 1008MHz if the chip's quality is
>> > > not so good.
>> > >
>> > > Lower the default CPUx frequency of H5 to 816MHz.
>> > >
>> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> > > ---
>> > >  arch/arm/mach-sunxi/Kconfig | 2 +-
>> > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
>> > > index 09cfec6f57..1fededd0a3 100644
>> > > --- a/arch/arm/mach-sunxi/Kconfig
>> > > +++ b/arch/arm/mach-sunxi/Kconfig
>> > > @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
>> > >         default 1008000000 if MACH_SUN5I
>> > >         default 1008000000 if MACH_SUN6I
>> > >         default 912000000 if MACH_SUN7I
>> > > +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
>> > >         default 1008000000 if MACH_SUN8I
>> >
>> > Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
>> > you find an issue with neo2?
> 
> So you have one single model that fails, and you change the default
> frequency of all the boards using that SoC?

But I think we have already set the default frequency to 816MHz for
A64, and it seems that several H5 boards are designed to start at 1.1v
(see the notes by Jagan above).

> 
> It seems a bit overkill.
> 
> I guess we have two solutions:
>   1) Change the frequency in that board config
>   2) Change the voltage in that board config

NEO2 don't have any voltage adjusting, it's fixed at 1.1V.

And according to the Orange Pi PC2 and Prime schematics, they both
start at 1.1V. (The Prime schematics even says "For H5 adjust
VDD-CPUX to 1.1V).

> 
> There's no need to enforce a SoC-wide change.
> 
> Maxime

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [linux-sunxi] Re: [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-11-01  0:31       ` Icenowy Zheng
@ 2017-11-01  2:10         ` Ondřej Jirman
  2017-11-01  2:20           ` Ondřej Jirman
  2017-11-01  9:16           ` Jagan Teki
  2017-11-02 13:56         ` [U-Boot] " Maxime Ripard
  1 sibling, 2 replies; 15+ messages in thread
From: Ondřej Jirman @ 2017-11-01  2:10 UTC (permalink / raw)
  To: u-boot

Hi,

Icenowy Zheng píše v St 01. 11. 2017 v 08:31 +0800:
> 
> And according to the Orange Pi PC2 and Prime schematics, they both
> start at 1.1V. (The Prime schematics even says "For H5 adjust
> VDD-CPUX to 1.1V).
> 

Orange Pi PC2 starts at the same voltage as Orange Pi PC. That is at
1.308V.

It can be calculated from 0.6×(1+11.8÷10) as per the values of Ru1/Ru2
resistors in the schema. It is also my experience of working with these
boards and writing the sy8106a driver.

regards,
  Ondrej

> > 
> > There's no need to enforce a SoC-wide change.
> > 
> > Maxime
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 850 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171101/5dd9748f/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [linux-sunxi] Re: [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-11-01  2:10         ` [U-Boot] [linux-sunxi] " Ondřej Jirman
@ 2017-11-01  2:20           ` Ondřej Jirman
  2017-11-01  9:16           ` Jagan Teki
  1 sibling, 0 replies; 15+ messages in thread
From: Ondřej Jirman @ 2017-11-01  2:20 UTC (permalink / raw)
  To: u-boot

'Ondřej Jirman' via linux-sunxi píše v St 01. 11. 2017 v 03:10 +0100:
> Hi,
> 
> Icenowy Zheng píše v St 01. 11. 2017 v 08:31 +0800:
> > 
> > And according to the Orange Pi PC2 and Prime schematics, they both
> > start at 1.1V. (The Prime schematics even says "For H5 adjust
> > VDD-CPUX to 1.1V).
> > 
> 
> Orange Pi PC2 starts at the same voltage as Orange Pi PC. That is at
> 1.308V.
> 
> It can be calculated from 0.6×(1+11.8÷10) as per the values of Ru1/Ru2
> resistors in the schema. It is also my experience of working with these
> boards and writing the sy8106a driver.

Anyway, I may be mis-remembering in the case of PC2. So please ignore
me. :) I'm only sure in the case of Orange Pi PC, which is not relevant
here. Sorry.

> regards,
>   Ondrej
> 
> > > 
> > > There's no need to enforce a SoC-wide change.
> > > 
> > > Maxime
> > 
> > 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171101/5401e4c4/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [linux-sunxi] Re: [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-11-01  2:10         ` [U-Boot] [linux-sunxi] " Ondřej Jirman
  2017-11-01  2:20           ` Ondřej Jirman
@ 2017-11-01  9:16           ` Jagan Teki
  1 sibling, 0 replies; 15+ messages in thread
From: Jagan Teki @ 2017-11-01  9:16 UTC (permalink / raw)
  To: u-boot

On Wed, Nov 1, 2017 at 7:40 AM, Ondřej Jirman <megi@xff.cz> wrote:
> Hi,
>
> Icenowy Zheng píše v St 01. 11. 2017 v 08:31 +0800:
>>
>> And according to the Orange Pi PC2 and Prime schematics, they both
>> start at 1.1V. (The Prime schematics even says "For H5 adjust
>> VDD-CPUX to 1.1V).
>>
>
> Orange Pi PC2 starts at the same voltage as Orange Pi PC. That is at
> 1.308V.
>
> It can be calculated from 0.6×(1+11.8÷10) as per the values of Ru1/Ru2
> resistors in the schema. It is also my experience of working with these
> boards and writing the sy8106a driver.

I think you reverse the Ru values according to pc2 and prime schematic
 CPUX Vout = 0.6x(1+Ru1/Ru2)

so Ru1 10K and Ru2 11.8K then Vout = 0.6x(1+10/11.8) => 1.10V

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-11-01  0:31       ` Icenowy Zheng
  2017-11-01  2:10         ` [U-Boot] [linux-sunxi] " Ondřej Jirman
@ 2017-11-02 13:56         ` Maxime Ripard
  2017-11-03  8:51           ` Jagan Teki
  1 sibling, 1 reply; 15+ messages in thread
From: Maxime Ripard @ 2017-11-02 13:56 UTC (permalink / raw)
  To: u-boot

On Wed, Nov 01, 2017 at 08:31:46AM +0800, Icenowy Zheng wrote:
> 在 2017-10-31 21:54,Maxime Ripard 写道:
> > On Tue, Oct 31, 2017 at 04:05:36PM +0800, icenowy at aosc.io wrote:
> > > 在 2017-10-31 15:57,Jagan Teki 写道:
> > > > On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> > > > > Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano
> > > > > Pi
> > > > > NEO2), which may not work properly at 1008MHz if the chip's quality is
> > > > > not so good.
> > > > >
> > > > > Lower the default CPUx frequency of H5 to 816MHz.
> > > > >
> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > > > ---
> > > > >  arch/arm/mach-sunxi/Kconfig | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> > > > > index 09cfec6f57..1fededd0a3 100644
> > > > > --- a/arch/arm/mach-sunxi/Kconfig
> > > > > +++ b/arch/arm/mach-sunxi/Kconfig
> > > > > @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
> > > > >         default 1008000000 if MACH_SUN5I
> > > > >         default 1008000000 if MACH_SUN6I
> > > > >         default 912000000 if MACH_SUN7I
> > > > > +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
> > > > >         default 1008000000 if MACH_SUN8I
> > > >
> > > > Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
> > > > you find an issue with neo2?
> > 
> > So you have one single model that fails, and you change the default
> > frequency of all the boards using that SoC?
> 
> But I think we have already set the default frequency to 816MHz for
> A64, and it seems that several H5 boards are designed to start at 1.1v
> (see the notes by Jagan above).
> 
> > 
> > It seems a bit overkill.
> > 
> > I guess we have two solutions:
> >   1) Change the frequency in that board config
> >   2) Change the voltage in that board config
> 
> NEO2 don't have any voltage adjusting, it's fixed at 1.1V.
> 
> And according to the Orange Pi PC2 and Prime schematics, they both
> start at 1.1V. (The Prime schematics even says "For H5 adjust
> VDD-CPUX to 1.1V).

And what about the Zero Plus 2 ?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171102/cf3c708a/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-11-02 13:56         ` [U-Boot] " Maxime Ripard
@ 2017-11-03  8:51           ` Jagan Teki
  2017-11-03 16:30             ` Maxime Ripard
  0 siblings, 1 reply; 15+ messages in thread
From: Jagan Teki @ 2017-11-03  8:51 UTC (permalink / raw)
  To: u-boot

On Thu, Nov 2, 2017 at 7:26 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Wed, Nov 01, 2017 at 08:31:46AM +0800, Icenowy Zheng wrote:
>> 在 2017-10-31 21:54,Maxime Ripard 写道:
>> > On Tue, Oct 31, 2017 at 04:05:36PM +0800, icenowy at aosc.io wrote:
>> > > 在 2017-10-31 15:57,Jagan Teki 写道:
>> > > > On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>> > > > > Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano
>> > > > > Pi
>> > > > > NEO2), which may not work properly at 1008MHz if the chip's quality is
>> > > > > not so good.
>> > > > >
>> > > > > Lower the default CPUx frequency of H5 to 816MHz.
>> > > > >
>> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> > > > > ---
>> > > > >  arch/arm/mach-sunxi/Kconfig | 2 +-
>> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > > > >
>> > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
>> > > > > index 09cfec6f57..1fededd0a3 100644
>> > > > > --- a/arch/arm/mach-sunxi/Kconfig
>> > > > > +++ b/arch/arm/mach-sunxi/Kconfig
>> > > > > @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
>> > > > >         default 1008000000 if MACH_SUN5I
>> > > > >         default 1008000000 if MACH_SUN6I
>> > > > >         default 912000000 if MACH_SUN7I
>> > > > > +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
>> > > > >         default 1008000000 if MACH_SUN8I
>> > > >
>> > > > Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
>> > > > you find an issue with neo2?
>> >
>> > So you have one single model that fails, and you change the default
>> > frequency of all the boards using that SoC?
>>
>> But I think we have already set the default frequency to 816MHz for
>> A64, and it seems that several H5 boards are designed to start at 1.1v
>> (see the notes by Jagan above).
>>
>> >
>> > It seems a bit overkill.
>> >
>> > I guess we have two solutions:
>> >   1) Change the frequency in that board config
>> >   2) Change the voltage in that board config
>>
>> NEO2 don't have any voltage adjusting, it's fixed at 1.1V.
>>
>> And according to the Orange Pi PC2 and Prime schematics, they both
>> start at 1.1V. (The Prime schematics even says "For H5 adjust
>> VDD-CPUX to 1.1V).
>
> And what about the Zero Plus 2 ?

Same equation with same reg values, but missing reg names on specific
register area Page 7 [4] but hope both were same.

[4] http://linux-sunxi.org/images/f/f6/ORANGE_PI-ZERO-PLUS2_V1_0.pdf

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-11-03  8:51           ` Jagan Teki
@ 2017-11-03 16:30             ` Maxime Ripard
  2017-11-06  8:10               ` Jagan Teki
  0 siblings, 1 reply; 15+ messages in thread
From: Maxime Ripard @ 2017-11-03 16:30 UTC (permalink / raw)
  To: u-boot

On Fri, Nov 03, 2017 at 02:21:51PM +0530, Jagan Teki wrote:
> On Thu, Nov 2, 2017 at 7:26 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Wed, Nov 01, 2017 at 08:31:46AM +0800, Icenowy Zheng wrote:
> >> 在 2017-10-31 21:54,Maxime Ripard 写道:
> >> > On Tue, Oct 31, 2017 at 04:05:36PM +0800, icenowy at aosc.io wrote:
> >> > > 在 2017-10-31 15:57,Jagan Teki 写道:
> >> > > > On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> >> > > > > Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano
> >> > > > > Pi
> >> > > > > NEO2), which may not work properly at 1008MHz if the chip's quality is
> >> > > > > not so good.
> >> > > > >
> >> > > > > Lower the default CPUx frequency of H5 to 816MHz.
> >> > > > >
> >> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> >> > > > > ---
> >> > > > >  arch/arm/mach-sunxi/Kconfig | 2 +-
> >> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> > > > >
> >> > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> >> > > > > index 09cfec6f57..1fededd0a3 100644
> >> > > > > --- a/arch/arm/mach-sunxi/Kconfig
> >> > > > > +++ b/arch/arm/mach-sunxi/Kconfig
> >> > > > > @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
> >> > > > >         default 1008000000 if MACH_SUN5I
> >> > > > >         default 1008000000 if MACH_SUN6I
> >> > > > >         default 912000000 if MACH_SUN7I
> >> > > > > +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
> >> > > > >         default 1008000000 if MACH_SUN8I
> >> > > >
> >> > > > Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
> >> > > > you find an issue with neo2?
> >> >
> >> > So you have one single model that fails, and you change the default
> >> > frequency of all the boards using that SoC?
> >>
> >> But I think we have already set the default frequency to 816MHz for
> >> A64, and it seems that several H5 boards are designed to start at 1.1v
> >> (see the notes by Jagan above).
> >>
> >> >
> >> > It seems a bit overkill.
> >> >
> >> > I guess we have two solutions:
> >> >   1) Change the frequency in that board config
> >> >   2) Change the voltage in that board config
> >>
> >> NEO2 don't have any voltage adjusting, it's fixed at 1.1V.
> >>
> >> And according to the Orange Pi PC2 and Prime schematics, they both
> >> start at 1.1V. (The Prime schematics even says "For H5 adjust
> >> VDD-CPUX to 1.1V).
> >
> > And what about the Zero Plus 2 ?
> 
> Same equation with same reg values, but missing reg names on specific
> register area Page 7 [4] but hope both were same.

Ok, so it's not some H5 boards, it's all of them. It makes sense then,
once the commit log has been changed.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171103/18800f63/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-11-03 16:30             ` Maxime Ripard
@ 2017-11-06  8:10               ` Jagan Teki
  2017-12-02 16:27                 ` Jagan Teki
  0 siblings, 1 reply; 15+ messages in thread
From: Jagan Teki @ 2017-11-06  8:10 UTC (permalink / raw)
  To: u-boot

On Fri, Nov 3, 2017 at 10:00 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Fri, Nov 03, 2017 at 02:21:51PM +0530, Jagan Teki wrote:
>> On Thu, Nov 2, 2017 at 7:26 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > On Wed, Nov 01, 2017 at 08:31:46AM +0800, Icenowy Zheng wrote:
>> >> 在 2017-10-31 21:54,Maxime Ripard 写道:
>> >> > On Tue, Oct 31, 2017 at 04:05:36PM +0800, icenowy at aosc.io wrote:
>> >> > > 在 2017-10-31 15:57,Jagan Teki 写道:
>> >> > > > On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>> >> > > > > Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano
>> >> > > > > Pi
>> >> > > > > NEO2), which may not work properly at 1008MHz if the chip's quality is
>> >> > > > > not so good.
>> >> > > > >
>> >> > > > > Lower the default CPUx frequency of H5 to 816MHz.
>> >> > > > >
>> >> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> >> > > > > ---
>> >> > > > >  arch/arm/mach-sunxi/Kconfig | 2 +-
>> >> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >> > > > >
>> >> > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
>> >> > > > > index 09cfec6f57..1fededd0a3 100644
>> >> > > > > --- a/arch/arm/mach-sunxi/Kconfig
>> >> > > > > +++ b/arch/arm/mach-sunxi/Kconfig
>> >> > > > > @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
>> >> > > > >         default 1008000000 if MACH_SUN5I
>> >> > > > >         default 1008000000 if MACH_SUN6I
>> >> > > > >         default 912000000 if MACH_SUN7I
>> >> > > > > +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
>> >> > > > >         default 1008000000 if MACH_SUN8I
>> >> > > >
>> >> > > > Even orangepi pc2 has 1.1v after power-on and it's work fine [1] did
>> >> > > > you find an issue with neo2?
>> >> >
>> >> > So you have one single model that fails, and you change the default
>> >> > frequency of all the boards using that SoC?
>> >>
>> >> But I think we have already set the default frequency to 816MHz for
>> >> A64, and it seems that several H5 boards are designed to start at 1.1v
>> >> (see the notes by Jagan above).
>> >>
>> >> >
>> >> > It seems a bit overkill.
>> >> >
>> >> > I guess we have two solutions:
>> >> >   1) Change the frequency in that board config
>> >> >   2) Change the voltage in that board config
>> >>
>> >> NEO2 don't have any voltage adjusting, it's fixed at 1.1V.
>> >>
>> >> And according to the Orange Pi PC2 and Prime schematics, they both
>> >> start at 1.1V. (The Prime schematics even says "For H5 adjust
>> >> VDD-CPUX to 1.1V).
>> >
>> > And what about the Zero Plus 2 ?
>>
>> Same equation with same reg values, but missing reg names on specific
>> register area Page 7 [4] but hope both were same.
>
> Ok, so it's not some H5 boards, it's all of them. It makes sense then,
> once the commit log has been changed.

Let me test and will apply all fine.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz
  2017-11-06  8:10               ` Jagan Teki
@ 2017-12-02 16:27                 ` Jagan Teki
  0 siblings, 0 replies; 15+ messages in thread
From: Jagan Teki @ 2017-12-02 16:27 UTC (permalink / raw)
  To: u-boot

On Mon, Nov 6, 2017 at 1:40 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> On Fri, Nov 3, 2017 at 10:00 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
>> On Fri, Nov 03, 2017 at 02:21:51PM +0530, Jagan Teki wrote:
>>> On Thu, Nov 2, 2017 at 7:26 PM, Maxime Ripard
>>> <maxime.ripard@free-electrons.com> wrote:
>>> > On Wed, Nov 01, 2017 at 08:31:46AM +0800, Icenowy Zheng wrote:
>>> >> 在 2017-10-31 21:54,Maxime Ripard 写道:
>>> >> > On Tue, Oct 31, 2017 at 04:05:36PM +0800, icenowy at aosc.io wrote:
>>> >> > > 在 2017-10-31 15:57,Jagan Teki 写道:
>>> >> > > > On Tue, Oct 31, 2017 at 5:06 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>>> >> > > > > Some H5 boards are designed to start at 1.1V CPUx voltage (e.g. Nano
>>> >> > > > > Pi
>>> >> > > > > NEO2), which may not work properly at 1008MHz if the chip's quality is
>>> >> > > > > not so good.
>>> >> > > > >
>>> >> > > > > Lower the default CPUx frequency of H5 to 816MHz.
>>> >> > > > >
>>> >> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> >> > > > > ---
>>> >> > > > >  arch/arm/mach-sunxi/Kconfig | 2 +-
>>> >> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
>>> >> > > > >
>>> >> > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
>>> >> > > > > index 09cfec6f57..1fededd0a3 100644
>>> >> > > > > --- a/arch/arm/mach-sunxi/Kconfig
>>> >> > > > > +++ b/arch/arm/mach-sunxi/Kconfig
>>> >> > > > > @@ -397,9 +397,9 @@ config SYS_CLK_FREQ
>>> >> > > > >         default 1008000000 if MACH_SUN5I
>>> >> > > > >         default 1008000000 if MACH_SUN6I
>>> >> > > > >         default 912000000 if MACH_SUN7I
>>> >> > > > > +       default 816000000 if MACH_SUN50I || MACH_SUN50I_H5
>>> >> > > > >         default 1008000000 if MACH_SUN8I

Applied to u-boot-sunxi/master

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2017-12-02 16:27 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30 23:36 [U-Boot] [PATCH] sunxi: set the default CPUx frequency of H5 to 816MHz Icenowy Zheng
2017-10-31  7:57 ` Jagan Teki
2017-10-31  8:05   ` icenowy at aosc.io
2017-10-31  8:53     ` Jagan Teki
2017-10-31  9:08       ` Icenowy Zheng
2017-10-31 13:54     ` Maxime Ripard
2017-11-01  0:31       ` Icenowy Zheng
2017-11-01  2:10         ` [U-Boot] [linux-sunxi] " Ondřej Jirman
2017-11-01  2:20           ` Ondřej Jirman
2017-11-01  9:16           ` Jagan Teki
2017-11-02 13:56         ` [U-Boot] " Maxime Ripard
2017-11-03  8:51           ` Jagan Teki
2017-11-03 16:30             ` Maxime Ripard
2017-11-06  8:10               ` Jagan Teki
2017-12-02 16:27                 ` Jagan Teki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.